Skip to content

Fix Windows test failure for temurin signature verification and add e2e coverage - #5

Merged
johnoliver merged 1 commit into
copilot/include-signature-verificationfrom
copilot/fix-github-actions-job-failure
Jun 17, 2026
Merged

Fix Windows test failure for temurin signature verification and add e2e coverage#5
johnoliver merged 1 commit into
copilot/include-signature-verificationfrom
copilot/fix-github-actions-job-failure

Conversation

CopilotAI commented Jun 17, 2026

Copy link
Copy Markdown

Description:
On windows-latest, process.platform === 'win32' causes renameWinArchive() to run fs.renameSync on the mocked download path /tmp/jdk.tar.gz, which doesn't exist on disk — throwing ENOENT. Fix mocks util.renameWinArchive in the downloadTool test suite alongside the other already-mocked util functions. Also adds an e2e job exercising the full verify-signature: true flow for Temurin.

  • __tests__/distributors/temurin-installer.test.ts — add spyRenameWinArchive mock in downloadToolbeforeEach to prevent fs.renameSync from touching the filesystem during the signature verification test
  • .github/workflows/e2e-versions.yml — new setup-java-temurin-signature-verification job running verify-signature: true for Temurin 17 and 21 across macOS, Windows, and Linux

Related issue:
Check run 81923318772

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

CopilotAI changed the title Fix Windows test failure and add temurin GPG signature e2e testFix Windows test failure for temurin signature verification and add e2e coverageJun 17, 2026
CopilotAI requested a review from johnoliverJune 17, 2026 14:53
@johnoliver
johnoliver marked this pull request as ready for review June 17, 2026 14:55
@johnoliver
johnoliver merged commit c607d20 into copilot/include-signature-verificationJun 17, 2026
240 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@johnoliver