Skip to content

Support xread block - #36

Merged
mikhailmaslo merged 1 commit into
masterfrom
feature/support-xread-block
Jun 5, 2026
Merged

Support xread block#36
mikhailmaslo merged 1 commit into
masterfrom
feature/support-xread-block

Conversation

@mikhailmaslo

@mikhailmaslomikhailmaslo commented Jun 5, 2026•
edited by g7r
Loading

Copy link
Copy Markdown
Contributor

I'm fixing two issues:

  • The xread block won't start because the block becomes the key for the cluster (see redis/request.go)
  • This is an optional change, but it's better to check command validity by looking at CommandName(), which takes the first command up to the space

@atikhono
atikhono requested a review from g7rJune 5, 2026 15:44
g7r
g7r approved these changes Jun 5, 2026
View reviewed changes
@mikhailmaslo
mikhailmaslo merged commit 2088b16 into masterJun 5, 2026
15 of 18 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@g7rg7rg7r approved these changes
@atikhonoatikhonoAwaiting requested review from atikhono

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikhailmaslo@g7r