Improve bailouts

[wilsonge]

Re-opens #109 which was merged in error

Improves error handling in cases such as joomla/joomla-cms#38524 where we boot a web application from the cli. Clearly in this case we shouldn't try and form a mis-shaped URL. And from a framework perspective - if we can't find a host then it likely makes sense to bail early rather than miss a domain in a web app's primary url

Summary of Changes

So none of the tests actually have a http host. so most fail where we create a concrete instance. But in a way that shows how our behaviour is kinda unexpected. Should we fail if we can't parse a url. or try and continue. if we try and continue should we set these properties??

Testing Instructions

Code Review

Documentation Changes Required

Not really

[rdeutz]

This here is so old that the drone log are deleted, I would like to see passing tests before we think about merging :-)

[wilsonge]

Good luck. Pretty much all tests fail because we're testing web apps from the CLI.... We can mock the full thing but I'm not going to try and fix every single test in here.

[wilsonge]

Re-opens #109 which was merged in error

Improves error handling in cases such as joomla/joomla-cms#38524 where we boot a web application from the cli. Clearly in this case we shouldn't try and form a mis-shaped URL. And from a framework perspective - if we can't find a host then it likely makes sense to bail early rather than miss a domain in a web app's primary url

Summary of Changes

So none of the tests actually have a http host. so most fail where we create a concrete instance. But in a way that shows how our behaviour is kinda unexpected. Should we fail if we can't parse a url. or try and continue. if we try and continue should we set these properties??

Testing Instructions

Code Review

Documentation Changes Required

Not really

[rdeutz]

This here is so old that the drone log are deleted, I would like to see passing tests before we think about merging :-)

[wilsonge]

Good luck. Pretty much all tests fail because we're testing web apps from the CLI.... We can mock the full thing but I'm not going to try and fix every single test in here.

[wilsonge]

Re-opens #109 which was merged in error

Improves error handling in cases such as joomla/joomla-cms#38524 where we boot a web application from the cli. Clearly in this case we shouldn't try and form a mis-shaped URL. And from a framework perspective - if we can't find a host then it likely makes sense to bail early rather than miss a domain in a web app's primary url

Summary of Changes

So none of the tests actually have a http host. so most fail where we create a concrete instance. But in a way that shows how our behaviour is kinda unexpected. Should we fail if we can't parse a url. or try and continue. if we try and continue should we set these properties??

Testing Instructions

Code Review

Documentation Changes Required

Not really

[rdeutz]

This here is so old that the drone log are deleted, I would like to see passing tests before we think about merging :-)

[wilsonge]

Good luck. Pretty much all tests fail because we're testing web apps from the CLI.... We can mock the full thing but I'm not going to try and fix every single test in here.

[wilsonge]

Re-opens #109 which was merged in error

Improves error handling in cases such as joomla/joomla-cms#38524 where we boot a web application from the cli. Clearly in this case we shouldn't try and form a mis-shaped URL. And from a framework perspective - if we can't find a host then it likely makes sense to bail early rather than miss a domain in a web app's primary url

Summary of Changes

So none of the tests actually have a http host. so most fail where we create a concrete instance. But in a way that shows how our behaviour is kinda unexpected. Should we fail if we can't parse a url. or try and continue. if we try and continue should we set these properties??

Testing Instructions

Code Review

Documentation Changes Required

Not really

[rdeutz]

This here is so old that the drone log are deleted, I would like to see passing tests before we think about merging :-)

[wilsonge]

Good luck. Pretty much all tests fail because we're testing web apps from the CLI.... We can mock the full thing but I'm not going to try and fix every single test in here.

[wilsonge]

Re-opens #109 which was merged in error

Improves error handling in cases such as joomla/joomla-cms#38524 where we boot a web application from the cli. Clearly in this case we shouldn't try and form a mis-shaped URL. And from a framework perspective - if we can't find a host then it likely makes sense to bail early rather than miss a domain in a web app's primary url

Summary of Changes

So none of the tests actually have a http host. so most fail where we create a concrete instance. But in a way that shows how our behaviour is kinda unexpected. Should we fail if we can't parse a url. or try and continue. if we try and continue should we set these properties??

Testing Instructions

Code Review

Documentation Changes Required

Not really

[rdeutz]

This here is so old that the drone log are deleted, I would like to see passing tests before we think about merging :-)

[wilsonge]

Good luck. Pretty much all tests fail because we're testing web apps from the CLI.... We can mock the full thing but I'm not going to try and fix every single test in here.

[wilsonge]

Re-opens #109 which was merged in error

Improves error handling in cases such as joomla/joomla-cms#38524 where we boot a web application from the cli. Clearly in this case we shouldn't try and form a mis-shaped URL. And from a framework perspective - if we can't find a host then it likely makes sense to bail early rather than miss a domain in a web app's primary url

Summary of Changes

So none of the tests actually have a http host. so most fail where we create a concrete instance. But in a way that shows how our behaviour is kinda unexpected. Should we fail if we can't parse a url. or try and continue. if we try and continue should we set these properties??

Testing Instructions

Code Review

Documentation Changes Required

Not really

[rdeutz]

This here is so old that the drone log are deleted, I would like to see passing tests before we think about merging :-)

[wilsonge]

Good luck. Pretty much all tests fail because we're testing web apps from the CLI.... We can mock the full thing but I'm not going to try and fix every single test in here.

[wilsonge]

Re-opens #109 which was merged in error

Improves error handling in cases such as joomla/joomla-cms#38524 where we boot a web application from the cli. Clearly in this case we shouldn't try and form a mis-shaped URL. And from a framework perspective - if we can't find a host then it likely makes sense to bail early rather than miss a domain in a web app's primary url

Summary of Changes

So none of the tests actually have a http host. so most fail where we create a concrete instance. But in a way that shows how our behaviour is kinda unexpected. Should we fail if we can't parse a url. or try and continue. if we try and continue should we set these properties??

Testing Instructions

Code Review

Documentation Changes Required

Not really

[rdeutz]

This here is so old that the drone log are deleted, I would like to see passing tests before we think about merging :-)

[wilsonge]

Good luck. Pretty much all tests fail because we're testing web apps from the CLI.... We can mock the full thing but I'm not going to try and fix every single test in here.

[wilsonge]

Re-opens #109 which was merged in error

Improves error handling in cases such as joomla/joomla-cms#38524 where we boot a web application from the cli. Clearly in this case we shouldn't try and form a mis-shaped URL. And from a framework perspective - if we can't find a host then it likely makes sense to bail early rather than miss a domain in a web app's primary url

Summary of Changes

So none of the tests actually have a http host. so most fail where we create a concrete instance. But in a way that shows how our behaviour is kinda unexpected. Should we fail if we can't parse a url. or try and continue. if we try and continue should we set these properties??

Testing Instructions

Code Review

Documentation Changes Required

Not really

[rdeutz]

This here is so old that the drone log are deleted, I would like to see passing tests before we think about merging :-)

[wilsonge]

Good luck. Pretty much all tests fail because we're testing web apps from the CLI.... We can mock the full thing but I'm not going to try and fix every single test in here.