[4.x] resolve PHPUnit Notices#369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hackwar merged 13 commits into from
Aug 24, 2026
Merged

[4.x] resolve PHPUnit Notices #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
12a6da5
add RequiresPhpExtension
heelc29 Jul 6, 2026
e19c16a
use Stub instead of Mock with no configured expectations or call any()
heelc29 Jul 6, 2026
0e8e84a
replace DoesNotPerformAssertions attribute
heelc29 Jul 6, 2026
5d1ba4e
remove check connection driver
heelc29 Jul 6, 2026
2f60db6
connection is not available in dataprovider
heelc29 Jul 6, 2026
720a2de
updates for new mariadb versions
heelc29 Jul 6, 2026
9a7c908
remove travis code
heelc29 Jul 6, 2026
b5125b6
php8.2: Creation of dynamic property is deprecated
heelc29 Jul 6, 2026
3aa7165
php 8.5: Method Reflection*::setAccessible() is deprecated
heelc29 Jul 6, 2026
4796302
Merge branch '4.x-dev' into 4.x/phpunit/notices
heelc29 Jul 6, 2026
189ac3d
no longer used
heelc29 Aug 24, 2026
5fd7768
convert metadata doc-comment to attribute
heelc29 Aug 24, 2026
e7dd409
convert metadata doc-comment to attribute 2
heelc29 Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
164 changes: 43 additions & 121 deletions Tests/AbstractDatabaseDriverTestCase.php
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 6 additions & 12 deletions Tests/DatabaseAwareTraitTest.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,27 +10,25 @@
use Joomla\Database\DatabaseAwareTrait;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Exception\DatabaseNotFoundException;
use PHPUnit\Framework\Attributes\CoversTrait;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
* Tests for DatabaseAwareTrait class.
*/
#[CoversTrait(DatabaseAwareTrait::class)]
class DatabaseAwareTraitTest extends TestCase
{
/**
* @var DatabaseAwareTrait
*/
protected $object;

/**
* @testdox Database can be set with setDatabase()
*
* @covers \Joomla\Database\DatabaseAwareTrait
* @uses \Joomla\Database\Database
*/
#[TestDox('Database can be set with setDatabase()')]
public function testGetSetDatabase(): void
{
$db = $this->createMock(DatabaseInterface::class);
$db = $this->createStub(DatabaseInterface::class);

$trait = new class () {
use DatabaseAwareTrait;
Expand All@@ -46,11 +44,7 @@ public function getDb()
$this->assertSame($db, $trait->getDb());
}

/**
* @testdox getDatabase() throws an DatabaseNotFoundException, if no database is set
*
* @covers \Joomla\Database\DatabaseAwareTrait
*/
#[TestDox('getDatabase() throws an DatabaseNotFoundException, if no database is set')]
public function testGetDatabaseException(): void
{
$this->expectException(DatabaseNotFoundException::class);
Expand Down
31 changes: 8 additions & 23 deletions Tests/DatabaseExporterTest.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,11 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseExporter;
use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseExporter;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -43,9 +40,7 @@ protected function setUp(): void
$this->exporter = new TestDatabaseExporter();
}

/**
* @testdox The exporter is correctly configured when instantiated
*/
#[TestDox('The exporter is correctly configured when instantiated')]
public function testInstantiation()
{
$expected = (object) [
Expand All@@ -57,9 +52,7 @@ public function testInstantiation()
$this->assertSame('xml', TestHelper::getValue($this->exporter, 'asFormat'));
}

/**
* @testdox The exporter can be set to XML format
*/
#[TestDox('The exporter can be set to XML format')]
public function testAsXml()
{
$this->assertSame($this->exporter, $this->exporter->asXml(), 'The exporter supports method chaining');
Expand DownExpand Up@@ -93,12 +86,11 @@ public static function dataFrom(): array
}

/**
* @testdox The tables to be exported can be configured
*
* @param string[]|string $from The name of a single table, or an array of the table names to export.
* @param boolean $shouldRaiseException Flag indicating the exporter should raise an exception for an unsupported data type
*/
#[DataProvider('dataFrom')]
#[TestDox('The tables to be exported can be configured')]
public function testFrom($from, bool $shouldRaiseException)
{
if ($shouldRaiseException) {
Expand All@@ -110,20 +102,15 @@ public function testFrom($from, bool $shouldRaiseException)
$this->assertSame((array) $from, TestHelper::getValue($this->exporter, 'from'));
}

/**
* @testdox A database drier can be set to the exporter
*/
#[TestDox('A database driver can be set to the exporter')]
public function testSetDbo()
{
/** @var DatabaseInterface|MockObject $db */
$db = $this->createMock(DatabaseInterface::class);
$db = $this->createStub(DatabaseInterface::class);

$this->assertSame($this->exporter, $this->exporter->setDbo($db), 'The exporter supports method chaining');
}

/**
* @testdox The exporter can be configured to export with structure
*/
#[TestDox('The exporter can be configured to export with structure')]
public function testWithStructure()
{
$this->assertSame($this->exporter, $this->exporter->withStructure(false), 'The exporter supports method chaining');
Expand All@@ -133,9 +120,7 @@ public function testWithStructure()
$this->assertFalse($options->withStructure);
}

/**
* @testdox The exporter can be configured to export with data
*/
#[TestDox('The exporter can be configured to export with data')]
public function testWithData()
{
$this->assertSame($this->exporter, $this->exporter->withData(true), 'The exporter supports method chaining');
Expand Down
24 changes: 10 additions & 14 deletions Tests/DatabaseFactoryTest.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@
use Joomla\Database\StatementInterface;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -68,12 +69,11 @@ public static function dataGetDriver(): array
}

/**
* @testdox The factory builds a database driver correctly
*
* @param string $adapter The type of adapter to create
* @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
*/
#[DataProvider('dataGetDriver')]
#[TestDox('The factory builds a database driver correctly')]
public function testGetDriver(string $adapter, bool $shouldRaiseException)
{
if ($shouldRaiseException) {
Expand DownExpand Up@@ -115,13 +115,12 @@ public static function dataGetExporter(): array
}

/**
* @testdox The factory builds a database exporter correctly
*
* @param string $adapter The type of adapter to create
* @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
* @param DatabaseDriver|null $databaseDriver The optional database driver to be injected into the exporter
*/
#[DataProvider('dataGetExporter')]
#[TestDox('The factory builds a database exporter correctly')]
public function testGetExporter(string $adapter, bool $shouldRaiseException, bool $createDb)
{
if ($shouldRaiseException) {
Expand All@@ -131,7 +130,7 @@ public function testGetExporter(string $adapter, bool $shouldRaiseException, boo
$databaseDriver = null;

if ($createDb) {
$databaseDriver = $this->createMock(MysqliDriver::class);
$databaseDriver = $this->createStub(MysqliDriver::class);
}

$exporter = $this->factory->getExporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -178,13 +177,12 @@ public static function dataGetImporter(): array
}

/**
* @testdox The factory builds a database importer correctly
*
* @param string $adapter The type of adapter to create
* @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
* @param boolean $createDb The optional database driver to be injected into the importer
*/
#[DataProvider('dataGetImporter')]
#[TestDox('The factory builds a database importer correctly')]
public function testGetImporter(string $adapter, bool $shouldRaiseException, bool $createDb)
{
if ($shouldRaiseException) {
Expand All@@ -194,7 +192,7 @@ public function testGetImporter(string $adapter, bool $shouldRaiseException, boo
$databaseDriver = null;

if ($createDb) {
$databaseDriver = $this->createMock(MysqliDriver::class);
$databaseDriver = $this->createStub(MysqliDriver::class);
}

$importer = $this->factory->getImporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -228,18 +226,17 @@ public static function dataGetIterator(): array
}

/**
* @testdox The factory builds a database iterator correctly
*
* @param string $adapter The type of adapter to create
* @param bool $createStatement Statement holding the result set to be iterated.
*/
#[DataProvider('dataGetIterator')]
#[TestDox('The factory builds a database iterator correctly')]
public function testGetIterator(string $adapter, bool $createStatement)
{
$statement = null;

if ($createStatement) {
$statement = $this->createMock(StatementInterface::class);
$statement = $this->createStub(StatementInterface::class);
}

$this->assertInstanceOf(
Expand DownExpand Up@@ -271,13 +268,12 @@ public static function dataGetQuery(): array
}

/**
* @testdox The factory builds a database query object correctly
*
* @param string $adapter The type of adapter to create
* @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
* @param boolean $createDb The optional database driver to be injected into the importer
*/
#[DataProvider('dataGetQuery')]
#[TestDox('The factory builds a database query object correctly')]
public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $createDb)
{
if ($shouldRaiseException) {
Expand All@@ -287,7 +283,7 @@ public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $
$databaseDriver = null;

if ($createDb) {
$databaseDriver = $this->createMock(MysqliDriver::class);
$databaseDriver = $this->createStub(MysqliDriver::class);
}

$this->assertInstanceOf(
Expand Down
23 changes: 6 additions & 17 deletions Tests/DatabaseImporterTest.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,12 +7,10 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Database\Tests\Stubs\TestDatabaseQuery;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -41,9 +39,7 @@ protected function setUp(): void
$this->importer = new TestDatabaseImporter();
}

/**
* @testdox The importer is correctly configured when instantiated
*/
#[TestDox('The importer is correctly configured when instantiated')]
public function testInstantiation()
{
$expected = (object) [
Expand All@@ -54,30 +50,23 @@ public function testInstantiation()
$this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
}

/**
* @testdox The importer can be set to XML format
*/
#[TestDox('The importer can be set to XML format')]
public function testAsXml()
{
$this->assertSame($this->importer, $this->importer->asXml(), 'The importer supports method chaining');

$this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
}

/**
* @testdox A database drier can be set to the importer
*/
#[TestDox('A database driver can be set to the importer')]
public function testSetDbo()
{
/** @var DatabaseInterface|MockObject $db */
$db = $this->createMock(DatabaseInterface::class);
$db = $this->createStub(DatabaseInterface::class);

$this->assertSame($this->importer, $this->importer->setDbo($db), 'The importer supports method chaining');
}

/**
* @testdox The importer can be configured to export with structure
*/
#[TestDox('The importer can be configured to export with structure')]
public function testWithStructure()
{
$this->assertSame($this->importer, $this->importer->withStructure(false), 'The importer supports method chaining');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[4.x] resolve PHPUnit Notices#369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Hackwar
merged 13 commits into

from

Aug 24, 2026
 Merged


[4.x] resolve PHPUnit Notices
#369
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
12a6da5

add RequiresPhpExtension


heelc29 Jul 6, 2026
e19c16a

use Stub instead of Mock with no configured expectations or call any()


heelc29 Jul 6, 2026
0e8e84a

replace DoesNotPerformAssertions attribute


heelc29 Jul 6, 2026
5d1ba4e

remove check connection driver


heelc29 Jul 6, 2026
2f60db6

connection is not available in dataprovider


heelc29 Jul 6, 2026
720a2de

updates for new mariadb versions


heelc29 Jul 6, 2026
9a7c908

remove travis code


heelc29 Jul 6, 2026
b5125b6

php8.2: Creation of dynamic property is deprecated


heelc29 Jul 6, 2026
3aa7165

php 8.5: Method Reflection*::setAccessible() is deprecated


heelc29 Jul 6, 2026
4796302

Merge branch '4.x-dev' into 4.x/phpunit/notices


heelc29 Jul 6, 2026
189ac3d

no longer used


heelc29 Aug 24, 2026
5fd7768

convert metadata doc-comment to attribute


heelc29 Aug 24, 2026
e7dd409

convert metadata doc-comment to attribute 2


heelc29 Aug 24, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


164 changes: 43 additions & 121 deletions
Tests/AbstractDatabaseDriverTestCase.php

View file


Open in desktop


Large diffs are not rendered by default.


18 changes: 6 additions & 12 deletions
Tests/DatabaseAwareTraitTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,27 +10,25 @@
use Joomla\Database\DatabaseAwareTrait;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Exception\DatabaseNotFoundException;
use PHPUnit\Framework\Attributes\CoversTrait;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
 * Tests for DatabaseAwareTrait class.
 */
#[CoversTrait(DatabaseAwareTrait::class)]
class DatabaseAwareTraitTest extends TestCase
{
 /**
 * @var DatabaseAwareTrait
 */
 protected $object;

 /**
 * @testdox Database can be set with setDatabase()
 *
 * @covers \Joomla\Database\DatabaseAwareTrait
 * @uses \Joomla\Database\Database
 */
 #[TestDox('Database can be set with setDatabase()')]
 public function testGetSetDatabase(): void
 {
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $trait = new class () {
 use DatabaseAwareTrait;
Expand All@@ -46,11 +44,7 @@ public function getDb()
 $this->assertSame($db, $trait->getDb());
 }

 /**
 * @testdox getDatabase() throws an DatabaseNotFoundException, if no database is set
 *
 * @covers \Joomla\Database\DatabaseAwareTrait
 */
 #[TestDox('getDatabase() throws an DatabaseNotFoundException, if no database is set')]
 public function testGetDatabaseException(): void
 {
 $this->expectException(DatabaseNotFoundException::class);
Expand Down

31 changes: 8 additions & 23 deletions
Tests/DatabaseExporterTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,11 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseExporter;
use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseExporter;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -43,9 +40,7 @@ protected function setUp(): void
 $this->exporter = new TestDatabaseExporter();
 }

 /**
 * @testdox The exporter is correctly configured when instantiated
 */
 #[TestDox('The exporter is correctly configured when instantiated')]
 public function testInstantiation()
 {
 $expected = (object) [
Expand All@@ -57,9 +52,7 @@ public function testInstantiation()
 $this->assertSame('xml', TestHelper::getValue($this->exporter, 'asFormat'));
 }

 /**
 * @testdox The exporter can be set to XML format
 */
 #[TestDox('The exporter can be set to XML format')]
 public function testAsXml()
 {
 $this->assertSame($this->exporter, $this->exporter->asXml(), 'The exporter supports method chaining');
Expand DownExpand Up@@ -93,12 +86,11 @@ public static function dataFrom(): array
 }

 /**
 * @testdox The tables to be exported can be configured
 *
 * @param string[]|string $from The name of a single table, or an array of the table names to export.
 * @param boolean $shouldRaiseException Flag indicating the exporter should raise an exception for an unsupported data type
 */
 #[DataProvider('dataFrom')]
 #[TestDox('The tables to be exported can be configured')]
 public function testFrom($from, bool $shouldRaiseException)
 {
 if ($shouldRaiseException) {
Expand All@@ -110,20 +102,15 @@ public function testFrom($from, bool $shouldRaiseException)
 $this->assertSame((array) $from, TestHelper::getValue($this->exporter, 'from'));
 }

 /**
 * @testdox A database drier can be set to the exporter
 */
 #[TestDox('A database driver can be set to the exporter')]
 public function testSetDbo()
 {
 /** @var DatabaseInterface|MockObject $db */
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $this->assertSame($this->exporter, $this->exporter->setDbo($db), 'The exporter supports method chaining');
 }

 /**
 * @testdox The exporter can be configured to export with structure
 */
 #[TestDox('The exporter can be configured to export with structure')]
 public function testWithStructure()
 {
 $this->assertSame($this->exporter, $this->exporter->withStructure(false), 'The exporter supports method chaining');
Expand All@@ -133,9 +120,7 @@ public function testWithStructure()
 $this->assertFalse($options->withStructure);
 }

 /**
 * @testdox The exporter can be configured to export with data
 */
 #[TestDox('The exporter can be configured to export with data')]
 public function testWithData()
 {
 $this->assertSame($this->exporter, $this->exporter->withData(true), 'The exporter supports method chaining');
Expand Down

24 changes: 10 additions & 14 deletions
Tests/DatabaseFactoryTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@
use Joomla\Database\StatementInterface;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -68,12 +69,11 @@ public static function dataGetDriver(): array
 }

 /**
 * @testdox The factory builds a database driver correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 */
 #[DataProvider('dataGetDriver')]
 #[TestDox('The factory builds a database driver correctly')]
 public function testGetDriver(string $adapter, bool $shouldRaiseException)
 {
 if ($shouldRaiseException) {
Expand DownExpand Up@@ -115,13 +115,12 @@ public static function dataGetExporter(): array
 }

 /**
 * @testdox The factory builds a database exporter correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param DatabaseDriver|null $databaseDriver The optional database driver to be injected into the exporter
 */
 #[DataProvider('dataGetExporter')]
 #[TestDox('The factory builds a database exporter correctly')]
 public function testGetExporter(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -131,7 +130,7 @@ public function testGetExporter(string $adapter, bool $shouldRaiseException, boo
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $exporter = $this->factory->getExporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -178,13 +177,12 @@ public static function dataGetImporter(): array
 }

 /**
 * @testdox The factory builds a database importer correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param boolean $createDb The optional database driver to be injected into the importer
 */
 #[DataProvider('dataGetImporter')]
 #[TestDox('The factory builds a database importer correctly')]
 public function testGetImporter(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -194,7 +192,7 @@ public function testGetImporter(string $adapter, bool $shouldRaiseException, boo
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $importer = $this->factory->getImporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -228,18 +226,17 @@ public static function dataGetIterator(): array
 }

 /**
 * @testdox The factory builds a database iterator correctly
 *
 * @param string $adapter The type of adapter to create
 * @param bool $createStatement Statement holding the result set to be iterated.
 */
 #[DataProvider('dataGetIterator')]
 #[TestDox('The factory builds a database iterator correctly')]
 public function testGetIterator(string $adapter, bool $createStatement)
 {
 $statement = null;

 if ($createStatement) {
 $statement = $this->createMock(StatementInterface::class);
 $statement = $this->createStub(StatementInterface::class);
 }

 $this->assertInstanceOf(
Expand DownExpand Up@@ -271,13 +268,12 @@ public static function dataGetQuery(): array
 }

 /**
 * @testdox The factory builds a database query object correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param boolean $createDb The optional database driver to be injected into the importer
 */
 #[DataProvider('dataGetQuery')]
 #[TestDox('The factory builds a database query object correctly')]
 public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -287,7 +283,7 @@ public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $this->assertInstanceOf(
Expand Down

23 changes: 6 additions & 17 deletions
Tests/DatabaseImporterTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,12 +7,10 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Database\Tests\Stubs\TestDatabaseQuery;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -41,9 +39,7 @@ protected function setUp(): void
 $this->importer = new TestDatabaseImporter();
 }

 /**
 * @testdox The importer is correctly configured when instantiated
 */
 #[TestDox('The importer is correctly configured when instantiated')]
 public function testInstantiation()
 {
 $expected = (object) [
Expand All@@ -54,30 +50,23 @@ public function testInstantiation()
 $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
 }

 /**
 * @testdox The importer can be set to XML format
 */
 #[TestDox('The importer can be set to XML format')]
 public function testAsXml()
 {
 $this->assertSame($this->importer, $this->importer->asXml(), 'The importer supports method chaining');

 $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
 }

 /**
 * @testdox A database drier can be set to the importer
 */
 #[TestDox('A database driver can be set to the importer')]
 public function testSetDbo()
 {
 /** @var DatabaseInterface|MockObject $db */
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $this->assertSame($this->importer, $this->importer->setDbo($db), 'The importer supports method chaining');
 }

 /**
 * @testdox The importer can be configured to export with structure
 */
 #[TestDox('The importer can be configured to export with structure')]
 public function testWithStructure()
 {
 $this->assertSame($this->importer, $this->importer->withStructure(false), 'The importer supports method chaining');
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[4.x] resolve PHPUnit Notices#369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Hackwar
merged 13 commits into

from

Aug 24, 2026
 Merged


[4.x] resolve PHPUnit Notices
#369
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
12a6da5

add RequiresPhpExtension


heelc29 Jul 6, 2026
e19c16a

use Stub instead of Mock with no configured expectations or call any()


heelc29 Jul 6, 2026
0e8e84a

replace DoesNotPerformAssertions attribute


heelc29 Jul 6, 2026
5d1ba4e

remove check connection driver


heelc29 Jul 6, 2026
2f60db6

connection is not available in dataprovider


heelc29 Jul 6, 2026
720a2de

updates for new mariadb versions


heelc29 Jul 6, 2026
9a7c908

remove travis code


heelc29 Jul 6, 2026
b5125b6

php8.2: Creation of dynamic property is deprecated


heelc29 Jul 6, 2026
3aa7165

php 8.5: Method Reflection*::setAccessible() is deprecated


heelc29 Jul 6, 2026
4796302

Merge branch '4.x-dev' into 4.x/phpunit/notices


heelc29 Jul 6, 2026
189ac3d

no longer used


heelc29 Aug 24, 2026
5fd7768

convert metadata doc-comment to attribute


heelc29 Aug 24, 2026
e7dd409

convert metadata doc-comment to attribute 2


heelc29 Aug 24, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


164 changes: 43 additions & 121 deletions
Tests/AbstractDatabaseDriverTestCase.php

View file


Open in desktop


Large diffs are not rendered by default.


18 changes: 6 additions & 12 deletions
Tests/DatabaseAwareTraitTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,27 +10,25 @@
use Joomla\Database\DatabaseAwareTrait;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Exception\DatabaseNotFoundException;
use PHPUnit\Framework\Attributes\CoversTrait;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
 * Tests for DatabaseAwareTrait class.
 */
#[CoversTrait(DatabaseAwareTrait::class)]
class DatabaseAwareTraitTest extends TestCase
{
 /**
 * @var DatabaseAwareTrait
 */
 protected $object;

 /**
 * @testdox Database can be set with setDatabase()
 *
 * @covers \Joomla\Database\DatabaseAwareTrait
 * @uses \Joomla\Database\Database
 */
 #[TestDox('Database can be set with setDatabase()')]
 public function testGetSetDatabase(): void
 {
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $trait = new class () {
 use DatabaseAwareTrait;
Expand All@@ -46,11 +44,7 @@ public function getDb()
 $this->assertSame($db, $trait->getDb());
 }

 /**
 * @testdox getDatabase() throws an DatabaseNotFoundException, if no database is set
 *
 * @covers \Joomla\Database\DatabaseAwareTrait
 */
 #[TestDox('getDatabase() throws an DatabaseNotFoundException, if no database is set')]
 public function testGetDatabaseException(): void
 {
 $this->expectException(DatabaseNotFoundException::class);
Expand Down

31 changes: 8 additions & 23 deletions
Tests/DatabaseExporterTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,11 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseExporter;
use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseExporter;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -43,9 +40,7 @@ protected function setUp(): void
 $this->exporter = new TestDatabaseExporter();
 }

 /**
 * @testdox The exporter is correctly configured when instantiated
 */
 #[TestDox('The exporter is correctly configured when instantiated')]
 public function testInstantiation()
 {
 $expected = (object) [
Expand All@@ -57,9 +52,7 @@ public function testInstantiation()
 $this->assertSame('xml', TestHelper::getValue($this->exporter, 'asFormat'));
 }

 /**
 * @testdox The exporter can be set to XML format
 */
 #[TestDox('The exporter can be set to XML format')]
 public function testAsXml()
 {
 $this->assertSame($this->exporter, $this->exporter->asXml(), 'The exporter supports method chaining');
Expand DownExpand Up@@ -93,12 +86,11 @@ public static function dataFrom(): array
 }

 /**
 * @testdox The tables to be exported can be configured
 *
 * @param string[]|string $from The name of a single table, or an array of the table names to export.
 * @param boolean $shouldRaiseException Flag indicating the exporter should raise an exception for an unsupported data type
 */
 #[DataProvider('dataFrom')]
 #[TestDox('The tables to be exported can be configured')]
 public function testFrom($from, bool $shouldRaiseException)
 {
 if ($shouldRaiseException) {
Expand All@@ -110,20 +102,15 @@ public function testFrom($from, bool $shouldRaiseException)
 $this->assertSame((array) $from, TestHelper::getValue($this->exporter, 'from'));
 }

 /**
 * @testdox A database drier can be set to the exporter
 */
 #[TestDox('A database driver can be set to the exporter')]
 public function testSetDbo()
 {
 /** @var DatabaseInterface|MockObject $db */
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $this->assertSame($this->exporter, $this->exporter->setDbo($db), 'The exporter supports method chaining');
 }

 /**
 * @testdox The exporter can be configured to export with structure
 */
 #[TestDox('The exporter can be configured to export with structure')]
 public function testWithStructure()
 {
 $this->assertSame($this->exporter, $this->exporter->withStructure(false), 'The exporter supports method chaining');
Expand All@@ -133,9 +120,7 @@ public function testWithStructure()
 $this->assertFalse($options->withStructure);
 }

 /**
 * @testdox The exporter can be configured to export with data
 */
 #[TestDox('The exporter can be configured to export with data')]
 public function testWithData()
 {
 $this->assertSame($this->exporter, $this->exporter->withData(true), 'The exporter supports method chaining');
Expand Down

24 changes: 10 additions & 14 deletions
Tests/DatabaseFactoryTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@
use Joomla\Database\StatementInterface;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -68,12 +69,11 @@ public static function dataGetDriver(): array
 }

 /**
 * @testdox The factory builds a database driver correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 */
 #[DataProvider('dataGetDriver')]
 #[TestDox('The factory builds a database driver correctly')]
 public function testGetDriver(string $adapter, bool $shouldRaiseException)
 {
 if ($shouldRaiseException) {
Expand DownExpand Up@@ -115,13 +115,12 @@ public static function dataGetExporter(): array
 }

 /**
 * @testdox The factory builds a database exporter correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param DatabaseDriver|null $databaseDriver The optional database driver to be injected into the exporter
 */
 #[DataProvider('dataGetExporter')]
 #[TestDox('The factory builds a database exporter correctly')]
 public function testGetExporter(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -131,7 +130,7 @@ public function testGetExporter(string $adapter, bool $shouldRaiseException, boo
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $exporter = $this->factory->getExporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -178,13 +177,12 @@ public static function dataGetImporter(): array
 }

 /**
 * @testdox The factory builds a database importer correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param boolean $createDb The optional database driver to be injected into the importer
 */
 #[DataProvider('dataGetImporter')]
 #[TestDox('The factory builds a database importer correctly')]
 public function testGetImporter(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -194,7 +192,7 @@ public function testGetImporter(string $adapter, bool $shouldRaiseException, boo
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $importer = $this->factory->getImporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -228,18 +226,17 @@ public static function dataGetIterator(): array
 }

 /**
 * @testdox The factory builds a database iterator correctly
 *
 * @param string $adapter The type of adapter to create
 * @param bool $createStatement Statement holding the result set to be iterated.
 */
 #[DataProvider('dataGetIterator')]
 #[TestDox('The factory builds a database iterator correctly')]
 public function testGetIterator(string $adapter, bool $createStatement)
 {
 $statement = null;

 if ($createStatement) {
 $statement = $this->createMock(StatementInterface::class);
 $statement = $this->createStub(StatementInterface::class);
 }

 $this->assertInstanceOf(
Expand DownExpand Up@@ -271,13 +268,12 @@ public static function dataGetQuery(): array
 }

 /**
 * @testdox The factory builds a database query object correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param boolean $createDb The optional database driver to be injected into the importer
 */
 #[DataProvider('dataGetQuery')]
 #[TestDox('The factory builds a database query object correctly')]
 public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -287,7 +283,7 @@ public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $this->assertInstanceOf(
Expand Down

23 changes: 6 additions & 17 deletions
Tests/DatabaseImporterTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,12 +7,10 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Database\Tests\Stubs\TestDatabaseQuery;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -41,9 +39,7 @@ protected function setUp(): void
 $this->importer = new TestDatabaseImporter();
 }

 /**
 * @testdox The importer is correctly configured when instantiated
 */
 #[TestDox('The importer is correctly configured when instantiated')]
 public function testInstantiation()
 {
 $expected = (object) [
Expand All@@ -54,30 +50,23 @@ public function testInstantiation()
 $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
 }

 /**
 * @testdox The importer can be set to XML format
 */
 #[TestDox('The importer can be set to XML format')]
 public function testAsXml()
 {
 $this->assertSame($this->importer, $this->importer->asXml(), 'The importer supports method chaining');

 $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
 }

 /**
 * @testdox A database drier can be set to the importer
 */
 #[TestDox('A database driver can be set to the importer')]
 public function testSetDbo()
 {
 /** @var DatabaseInterface|MockObject $db */
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $this->assertSame($this->importer, $this->importer->setDbo($db), 'The importer supports method chaining');
 }

 /**
 * @testdox The importer can be configured to export with structure
 */
 #[TestDox('The importer can be configured to export with structure')]
 public function testWithStructure()
 {
 $this->assertSame($this->importer, $this->importer->withStructure(false), 'The importer supports method chaining');
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[4.x] resolve PHPUnit Notices#369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Hackwar
merged 13 commits into

from

Aug 24, 2026
 Merged


[4.x] resolve PHPUnit Notices
#369
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
12a6da5

add RequiresPhpExtension


heelc29 Jul 6, 2026
e19c16a

use Stub instead of Mock with no configured expectations or call any()


heelc29 Jul 6, 2026
0e8e84a

replace DoesNotPerformAssertions attribute


heelc29 Jul 6, 2026
5d1ba4e

remove check connection driver


heelc29 Jul 6, 2026
2f60db6

connection is not available in dataprovider


heelc29 Jul 6, 2026
720a2de

updates for new mariadb versions


heelc29 Jul 6, 2026
9a7c908

remove travis code


heelc29 Jul 6, 2026
b5125b6

php8.2: Creation of dynamic property is deprecated


heelc29 Jul 6, 2026
3aa7165

php 8.5: Method Reflection*::setAccessible() is deprecated


heelc29 Jul 6, 2026
4796302

Merge branch '4.x-dev' into 4.x/phpunit/notices


heelc29 Jul 6, 2026
189ac3d

no longer used


heelc29 Aug 24, 2026
5fd7768

convert metadata doc-comment to attribute


heelc29 Aug 24, 2026
e7dd409

convert metadata doc-comment to attribute 2


heelc29 Aug 24, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


164 changes: 43 additions & 121 deletions
Tests/AbstractDatabaseDriverTestCase.php

View file


Open in desktop


Large diffs are not rendered by default.


18 changes: 6 additions & 12 deletions
Tests/DatabaseAwareTraitTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,27 +10,25 @@
use Joomla\Database\DatabaseAwareTrait;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Exception\DatabaseNotFoundException;
use PHPUnit\Framework\Attributes\CoversTrait;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
 * Tests for DatabaseAwareTrait class.
 */
#[CoversTrait(DatabaseAwareTrait::class)]
class DatabaseAwareTraitTest extends TestCase
{
 /**
 * @var DatabaseAwareTrait
 */
 protected $object;

 /**
 * @testdox Database can be set with setDatabase()
 *
 * @covers \Joomla\Database\DatabaseAwareTrait
 * @uses \Joomla\Database\Database
 */
 #[TestDox('Database can be set with setDatabase()')]
 public function testGetSetDatabase(): void
 {
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $trait = new class () {
 use DatabaseAwareTrait;
Expand All@@ -46,11 +44,7 @@ public function getDb()
 $this->assertSame($db, $trait->getDb());
 }

 /**
 * @testdox getDatabase() throws an DatabaseNotFoundException, if no database is set
 *
 * @covers \Joomla\Database\DatabaseAwareTrait
 */
 #[TestDox('getDatabase() throws an DatabaseNotFoundException, if no database is set')]
 public function testGetDatabaseException(): void
 {
 $this->expectException(DatabaseNotFoundException::class);
Expand Down

31 changes: 8 additions & 23 deletions
Tests/DatabaseExporterTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,11 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseExporter;
use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseExporter;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -43,9 +40,7 @@ protected function setUp(): void
 $this->exporter = new TestDatabaseExporter();
 }

 /**
 * @testdox The exporter is correctly configured when instantiated
 */
 #[TestDox('The exporter is correctly configured when instantiated')]
 public function testInstantiation()
 {
 $expected = (object) [
Expand All@@ -57,9 +52,7 @@ public function testInstantiation()
 $this->assertSame('xml', TestHelper::getValue($this->exporter, 'asFormat'));
 }

 /**
 * @testdox The exporter can be set to XML format
 */
 #[TestDox('The exporter can be set to XML format')]
 public function testAsXml()
 {
 $this->assertSame($this->exporter, $this->exporter->asXml(), 'The exporter supports method chaining');
Expand DownExpand Up@@ -93,12 +86,11 @@ public static function dataFrom(): array
 }

 /**
 * @testdox The tables to be exported can be configured
 *
 * @param string[]|string $from The name of a single table, or an array of the table names to export.
 * @param boolean $shouldRaiseException Flag indicating the exporter should raise an exception for an unsupported data type
 */
 #[DataProvider('dataFrom')]
 #[TestDox('The tables to be exported can be configured')]
 public function testFrom($from, bool $shouldRaiseException)
 {
 if ($shouldRaiseException) {
Expand All@@ -110,20 +102,15 @@ public function testFrom($from, bool $shouldRaiseException)
 $this->assertSame((array) $from, TestHelper::getValue($this->exporter, 'from'));
 }

 /**
 * @testdox A database drier can be set to the exporter
 */
 #[TestDox('A database driver can be set to the exporter')]
 public function testSetDbo()
 {
 /** @var DatabaseInterface|MockObject $db */
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $this->assertSame($this->exporter, $this->exporter->setDbo($db), 'The exporter supports method chaining');
 }

 /**
 * @testdox The exporter can be configured to export with structure
 */
 #[TestDox('The exporter can be configured to export with structure')]
 public function testWithStructure()
 {
 $this->assertSame($this->exporter, $this->exporter->withStructure(false), 'The exporter supports method chaining');
Expand All@@ -133,9 +120,7 @@ public function testWithStructure()
 $this->assertFalse($options->withStructure);
 }

 /**
 * @testdox The exporter can be configured to export with data
 */
 #[TestDox('The exporter can be configured to export with data')]
 public function testWithData()
 {
 $this->assertSame($this->exporter, $this->exporter->withData(true), 'The exporter supports method chaining');
Expand Down

24 changes: 10 additions & 14 deletions
Tests/DatabaseFactoryTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@
use Joomla\Database\StatementInterface;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -68,12 +69,11 @@ public static function dataGetDriver(): array
 }

 /**
 * @testdox The factory builds a database driver correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 */
 #[DataProvider('dataGetDriver')]
 #[TestDox('The factory builds a database driver correctly')]
 public function testGetDriver(string $adapter, bool $shouldRaiseException)
 {
 if ($shouldRaiseException) {
Expand DownExpand Up@@ -115,13 +115,12 @@ public static function dataGetExporter(): array
 }

 /**
 * @testdox The factory builds a database exporter correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param DatabaseDriver|null $databaseDriver The optional database driver to be injected into the exporter
 */
 #[DataProvider('dataGetExporter')]
 #[TestDox('The factory builds a database exporter correctly')]
 public function testGetExporter(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -131,7 +130,7 @@ public function testGetExporter(string $adapter, bool $shouldRaiseException, boo
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $exporter = $this->factory->getExporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -178,13 +177,12 @@ public static function dataGetImporter(): array
 }

 /**
 * @testdox The factory builds a database importer correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param boolean $createDb The optional database driver to be injected into the importer
 */
 #[DataProvider('dataGetImporter')]
 #[TestDox('The factory builds a database importer correctly')]
 public function testGetImporter(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -194,7 +192,7 @@ public function testGetImporter(string $adapter, bool $shouldRaiseException, boo
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $importer = $this->factory->getImporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -228,18 +226,17 @@ public static function dataGetIterator(): array
 }

 /**
 * @testdox The factory builds a database iterator correctly
 *
 * @param string $adapter The type of adapter to create
 * @param bool $createStatement Statement holding the result set to be iterated.
 */
 #[DataProvider('dataGetIterator')]
 #[TestDox('The factory builds a database iterator correctly')]
 public function testGetIterator(string $adapter, bool $createStatement)
 {
 $statement = null;

 if ($createStatement) {
 $statement = $this->createMock(StatementInterface::class);
 $statement = $this->createStub(StatementInterface::class);
 }

 $this->assertInstanceOf(
Expand DownExpand Up@@ -271,13 +268,12 @@ public static function dataGetQuery(): array
 }

 /**
 * @testdox The factory builds a database query object correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param boolean $createDb The optional database driver to be injected into the importer
 */
 #[DataProvider('dataGetQuery')]
 #[TestDox('The factory builds a database query object correctly')]
 public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -287,7 +283,7 @@ public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $this->assertInstanceOf(
Expand Down

23 changes: 6 additions & 17 deletions
Tests/DatabaseImporterTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,12 +7,10 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Database\Tests\Stubs\TestDatabaseQuery;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -41,9 +39,7 @@ protected function setUp(): void
 $this->importer = new TestDatabaseImporter();
 }

 /**
 * @testdox The importer is correctly configured when instantiated
 */
 #[TestDox('The importer is correctly configured when instantiated')]
 public function testInstantiation()
 {
 $expected = (object) [
Expand All@@ -54,30 +50,23 @@ public function testInstantiation()
 $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
 }

 /**
 * @testdox The importer can be set to XML format
 */
 #[TestDox('The importer can be set to XML format')]
 public function testAsXml()
 {
 $this->assertSame($this->importer, $this->importer->asXml(), 'The importer supports method chaining');

 $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
 }

 /**
 * @testdox A database drier can be set to the importer
 */
 #[TestDox('A database driver can be set to the importer')]
 public function testSetDbo()
 {
 /** @var DatabaseInterface|MockObject $db */
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $this->assertSame($this->importer, $this->importer->setDbo($db), 'The importer supports method chaining');
 }

 /**
 * @testdox The importer can be configured to export with structure
 */
 #[TestDox('The importer can be configured to export with structure')]
 public function testWithStructure()
 {
 $this->assertSame($this->importer, $this->importer->withStructure(false), 'The importer supports method chaining');
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[4.x] resolve PHPUnit Notices#369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Hackwar
merged 13 commits into

from

Aug 24, 2026
 Merged


[4.x] resolve PHPUnit Notices
#369
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
12a6da5

add RequiresPhpExtension


heelc29 Jul 6, 2026
e19c16a

use Stub instead of Mock with no configured expectations or call any()


heelc29 Jul 6, 2026
0e8e84a

replace DoesNotPerformAssertions attribute


heelc29 Jul 6, 2026
5d1ba4e

remove check connection driver


heelc29 Jul 6, 2026
2f60db6

connection is not available in dataprovider


heelc29 Jul 6, 2026
720a2de

updates for new mariadb versions


heelc29 Jul 6, 2026
9a7c908

remove travis code


heelc29 Jul 6, 2026
b5125b6

php8.2: Creation of dynamic property is deprecated


heelc29 Jul 6, 2026
3aa7165

php 8.5: Method Reflection*::setAccessible() is deprecated


heelc29 Jul 6, 2026
4796302

Merge branch '4.x-dev' into 4.x/phpunit/notices


heelc29 Jul 6, 2026
189ac3d

no longer used


heelc29 Aug 24, 2026
5fd7768

convert metadata doc-comment to attribute


heelc29 Aug 24, 2026
e7dd409

convert metadata doc-comment to attribute 2


heelc29 Aug 24, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


164 changes: 43 additions & 121 deletions
Tests/AbstractDatabaseDriverTestCase.php

View file


Open in desktop


Large diffs are not rendered by default.


18 changes: 6 additions & 12 deletions
Tests/DatabaseAwareTraitTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,27 +10,25 @@
use Joomla\Database\DatabaseAwareTrait;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Exception\DatabaseNotFoundException;
use PHPUnit\Framework\Attributes\CoversTrait;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
 * Tests for DatabaseAwareTrait class.
 */
#[CoversTrait(DatabaseAwareTrait::class)]
class DatabaseAwareTraitTest extends TestCase
{
 /**
 * @var DatabaseAwareTrait
 */
 protected $object;

 /**
 * @testdox Database can be set with setDatabase()
 *
 * @covers \Joomla\Database\DatabaseAwareTrait
 * @uses \Joomla\Database\Database
 */
 #[TestDox('Database can be set with setDatabase()')]
 public function testGetSetDatabase(): void
 {
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $trait = new class () {
 use DatabaseAwareTrait;
Expand All@@ -46,11 +44,7 @@ public function getDb()
 $this->assertSame($db, $trait->getDb());
 }

 /**
 * @testdox getDatabase() throws an DatabaseNotFoundException, if no database is set
 *
 * @covers \Joomla\Database\DatabaseAwareTrait
 */
 #[TestDox('getDatabase() throws an DatabaseNotFoundException, if no database is set')]
 public function testGetDatabaseException(): void
 {
 $this->expectException(DatabaseNotFoundException::class);
Expand Down

31 changes: 8 additions & 23 deletions
Tests/DatabaseExporterTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,11 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseExporter;
use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseExporter;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -43,9 +40,7 @@ protected function setUp(): void
 $this->exporter = new TestDatabaseExporter();
 }

 /**
 * @testdox The exporter is correctly configured when instantiated
 */
 #[TestDox('The exporter is correctly configured when instantiated')]
 public function testInstantiation()
 {
 $expected = (object) [
Expand All@@ -57,9 +52,7 @@ public function testInstantiation()
 $this->assertSame('xml', TestHelper::getValue($this->exporter, 'asFormat'));
 }

 /**
 * @testdox The exporter can be set to XML format
 */
 #[TestDox('The exporter can be set to XML format')]
 public function testAsXml()
 {
 $this->assertSame($this->exporter, $this->exporter->asXml(), 'The exporter supports method chaining');
Expand DownExpand Up@@ -93,12 +86,11 @@ public static function dataFrom(): array
 }

 /**
 * @testdox The tables to be exported can be configured
 *
 * @param string[]|string $from The name of a single table, or an array of the table names to export.
 * @param boolean $shouldRaiseException Flag indicating the exporter should raise an exception for an unsupported data type
 */
 #[DataProvider('dataFrom')]
 #[TestDox('The tables to be exported can be configured')]
 public function testFrom($from, bool $shouldRaiseException)
 {
 if ($shouldRaiseException) {
Expand All@@ -110,20 +102,15 @@ public function testFrom($from, bool $shouldRaiseException)
 $this->assertSame((array) $from, TestHelper::getValue($this->exporter, 'from'));
 }

 /**
 * @testdox A database drier can be set to the exporter
 */
 #[TestDox('A database driver can be set to the exporter')]
 public function testSetDbo()
 {
 /** @var DatabaseInterface|MockObject $db */
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $this->assertSame($this->exporter, $this->exporter->setDbo($db), 'The exporter supports method chaining');
 }

 /**
 * @testdox The exporter can be configured to export with structure
 */
 #[TestDox('The exporter can be configured to export with structure')]
 public function testWithStructure()
 {
 $this->assertSame($this->exporter, $this->exporter->withStructure(false), 'The exporter supports method chaining');
Expand All@@ -133,9 +120,7 @@ public function testWithStructure()
 $this->assertFalse($options->withStructure);
 }

 /**
 * @testdox The exporter can be configured to export with data
 */
 #[TestDox('The exporter can be configured to export with data')]
 public function testWithData()
 {
 $this->assertSame($this->exporter, $this->exporter->withData(true), 'The exporter supports method chaining');
Expand Down

24 changes: 10 additions & 14 deletions
Tests/DatabaseFactoryTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@
use Joomla\Database\StatementInterface;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -68,12 +69,11 @@ public static function dataGetDriver(): array
 }

 /**
 * @testdox The factory builds a database driver correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 */
 #[DataProvider('dataGetDriver')]
 #[TestDox('The factory builds a database driver correctly')]
 public function testGetDriver(string $adapter, bool $shouldRaiseException)
 {
 if ($shouldRaiseException) {
Expand DownExpand Up@@ -115,13 +115,12 @@ public static function dataGetExporter(): array
 }

 /**
 * @testdox The factory builds a database exporter correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param DatabaseDriver|null $databaseDriver The optional database driver to be injected into the exporter
 */
 #[DataProvider('dataGetExporter')]
 #[TestDox('The factory builds a database exporter correctly')]
 public function testGetExporter(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -131,7 +130,7 @@ public function testGetExporter(string $adapter, bool $shouldRaiseException, boo
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $exporter = $this->factory->getExporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -178,13 +177,12 @@ public static function dataGetImporter(): array
 }

 /**
 * @testdox The factory builds a database importer correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param boolean $createDb The optional database driver to be injected into the importer
 */
 #[DataProvider('dataGetImporter')]
 #[TestDox('The factory builds a database importer correctly')]
 public function testGetImporter(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -194,7 +192,7 @@ public function testGetImporter(string $adapter, bool $shouldRaiseException, boo
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $importer = $this->factory->getImporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -228,18 +226,17 @@ public static function dataGetIterator(): array
 }

 /**
 * @testdox The factory builds a database iterator correctly
 *
 * @param string $adapter The type of adapter to create
 * @param bool $createStatement Statement holding the result set to be iterated.
 */
 #[DataProvider('dataGetIterator')]
 #[TestDox('The factory builds a database iterator correctly')]
 public function testGetIterator(string $adapter, bool $createStatement)
 {
 $statement = null;

 if ($createStatement) {
 $statement = $this->createMock(StatementInterface::class);
 $statement = $this->createStub(StatementInterface::class);
 }

 $this->assertInstanceOf(
Expand DownExpand Up@@ -271,13 +268,12 @@ public static function dataGetQuery(): array
 }

 /**
 * @testdox The factory builds a database query object correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param boolean $createDb The optional database driver to be injected into the importer
 */
 #[DataProvider('dataGetQuery')]
 #[TestDox('The factory builds a database query object correctly')]
 public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -287,7 +283,7 @@ public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $this->assertInstanceOf(
Expand Down

23 changes: 6 additions & 17 deletions
Tests/DatabaseImporterTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,12 +7,10 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Database\Tests\Stubs\TestDatabaseQuery;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -41,9 +39,7 @@ protected function setUp(): void
 $this->importer = new TestDatabaseImporter();
 }

 /**
 * @testdox The importer is correctly configured when instantiated
 */
 #[TestDox('The importer is correctly configured when instantiated')]
 public function testInstantiation()
 {
 $expected = (object) [
Expand All@@ -54,30 +50,23 @@ public function testInstantiation()
 $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
 }

 /**
 * @testdox The importer can be set to XML format
 */
 #[TestDox('The importer can be set to XML format')]
 public function testAsXml()
 {
 $this->assertSame($this->importer, $this->importer->asXml(), 'The importer supports method chaining');

 $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
 }

 /**
 * @testdox A database drier can be set to the importer
 */
 #[TestDox('A database driver can be set to the importer')]
 public function testSetDbo()
 {
 /** @var DatabaseInterface|MockObject $db */
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $this->assertSame($this->importer, $this->importer->setDbo($db), 'The importer supports method chaining');
 }

 /**
 * @testdox The importer can be configured to export with structure
 */
 #[TestDox('The importer can be configured to export with structure')]
 public function testWithStructure()
 {
 $this->assertSame($this->importer, $this->importer->withStructure(false), 'The importer supports method chaining');
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[4.x] resolve PHPUnit Notices#369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Hackwar
merged 13 commits into

from

Aug 24, 2026
 Merged


[4.x] resolve PHPUnit Notices
#369
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
12a6da5

add RequiresPhpExtension


heelc29 Jul 6, 2026
e19c16a

use Stub instead of Mock with no configured expectations or call any()


heelc29 Jul 6, 2026
0e8e84a

replace DoesNotPerformAssertions attribute


heelc29 Jul 6, 2026
5d1ba4e

remove check connection driver


heelc29 Jul 6, 2026
2f60db6

connection is not available in dataprovider


heelc29 Jul 6, 2026
720a2de

updates for new mariadb versions


heelc29 Jul 6, 2026
9a7c908

remove travis code


heelc29 Jul 6, 2026
b5125b6

php8.2: Creation of dynamic property is deprecated


heelc29 Jul 6, 2026
3aa7165

php 8.5: Method Reflection*::setAccessible() is deprecated


heelc29 Jul 6, 2026
4796302

Merge branch '4.x-dev' into 4.x/phpunit/notices


heelc29 Jul 6, 2026
189ac3d

no longer used


heelc29 Aug 24, 2026
5fd7768

convert metadata doc-comment to attribute


heelc29 Aug 24, 2026
e7dd409

convert metadata doc-comment to attribute 2


heelc29 Aug 24, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


164 changes: 43 additions & 121 deletions
Tests/AbstractDatabaseDriverTestCase.php

View file


Open in desktop


Large diffs are not rendered by default.


18 changes: 6 additions & 12 deletions
Tests/DatabaseAwareTraitTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,27 +10,25 @@
use Joomla\Database\DatabaseAwareTrait;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Exception\DatabaseNotFoundException;
use PHPUnit\Framework\Attributes\CoversTrait;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
 * Tests for DatabaseAwareTrait class.
 */
#[CoversTrait(DatabaseAwareTrait::class)]
class DatabaseAwareTraitTest extends TestCase
{
 /**
 * @var DatabaseAwareTrait
 */
 protected $object;

 /**
 * @testdox Database can be set with setDatabase()
 *
 * @covers \Joomla\Database\DatabaseAwareTrait
 * @uses \Joomla\Database\Database
 */
 #[TestDox('Database can be set with setDatabase()')]
 public function testGetSetDatabase(): void
 {
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $trait = new class () {
 use DatabaseAwareTrait;
Expand All@@ -46,11 +44,7 @@ public function getDb()
 $this->assertSame($db, $trait->getDb());
 }

 /**
 * @testdox getDatabase() throws an DatabaseNotFoundException, if no database is set
 *
 * @covers \Joomla\Database\DatabaseAwareTrait
 */
 #[TestDox('getDatabase() throws an DatabaseNotFoundException, if no database is set')]
 public function testGetDatabaseException(): void
 {
 $this->expectException(DatabaseNotFoundException::class);
Expand Down

31 changes: 8 additions & 23 deletions
Tests/DatabaseExporterTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,11 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseExporter;
use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseExporter;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -43,9 +40,7 @@ protected function setUp(): void
 $this->exporter = new TestDatabaseExporter();
 }

 /**
 * @testdox The exporter is correctly configured when instantiated
 */
 #[TestDox('The exporter is correctly configured when instantiated')]
 public function testInstantiation()
 {
 $expected = (object) [
Expand All@@ -57,9 +52,7 @@ public function testInstantiation()
 $this->assertSame('xml', TestHelper::getValue($this->exporter, 'asFormat'));
 }

 /**
 * @testdox The exporter can be set to XML format
 */
 #[TestDox('The exporter can be set to XML format')]
 public function testAsXml()
 {
 $this->assertSame($this->exporter, $this->exporter->asXml(), 'The exporter supports method chaining');
Expand DownExpand Up@@ -93,12 +86,11 @@ public static function dataFrom(): array
 }

 /**
 * @testdox The tables to be exported can be configured
 *
 * @param string[]|string $from The name of a single table, or an array of the table names to export.
 * @param boolean $shouldRaiseException Flag indicating the exporter should raise an exception for an unsupported data type
 */
 #[DataProvider('dataFrom')]
 #[TestDox('The tables to be exported can be configured')]
 public function testFrom($from, bool $shouldRaiseException)
 {
 if ($shouldRaiseException) {
Expand All@@ -110,20 +102,15 @@ public function testFrom($from, bool $shouldRaiseException)
 $this->assertSame((array) $from, TestHelper::getValue($this->exporter, 'from'));
 }

 /**
 * @testdox A database drier can be set to the exporter
 */
 #[TestDox('A database driver can be set to the exporter')]
 public function testSetDbo()
 {
 /** @var DatabaseInterface|MockObject $db */
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $this->assertSame($this->exporter, $this->exporter->setDbo($db), 'The exporter supports method chaining');
 }

 /**
 * @testdox The exporter can be configured to export with structure
 */
 #[TestDox('The exporter can be configured to export with structure')]
 public function testWithStructure()
 {
 $this->assertSame($this->exporter, $this->exporter->withStructure(false), 'The exporter supports method chaining');
Expand All@@ -133,9 +120,7 @@ public function testWithStructure()
 $this->assertFalse($options->withStructure);
 }

 /**
 * @testdox The exporter can be configured to export with data
 */
 #[TestDox('The exporter can be configured to export with data')]
 public function testWithData()
 {
 $this->assertSame($this->exporter, $this->exporter->withData(true), 'The exporter supports method chaining');
Expand Down

24 changes: 10 additions & 14 deletions
Tests/DatabaseFactoryTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@
use Joomla\Database\StatementInterface;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -68,12 +69,11 @@ public static function dataGetDriver(): array
 }

 /**
 * @testdox The factory builds a database driver correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 */
 #[DataProvider('dataGetDriver')]
 #[TestDox('The factory builds a database driver correctly')]
 public function testGetDriver(string $adapter, bool $shouldRaiseException)
 {
 if ($shouldRaiseException) {
Expand DownExpand Up@@ -115,13 +115,12 @@ public static function dataGetExporter(): array
 }

 /**
 * @testdox The factory builds a database exporter correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param DatabaseDriver|null $databaseDriver The optional database driver to be injected into the exporter
 */
 #[DataProvider('dataGetExporter')]
 #[TestDox('The factory builds a database exporter correctly')]
 public function testGetExporter(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -131,7 +130,7 @@ public function testGetExporter(string $adapter, bool $shouldRaiseException, boo
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $exporter = $this->factory->getExporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -178,13 +177,12 @@ public static function dataGetImporter(): array
 }

 /**
 * @testdox The factory builds a database importer correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param boolean $createDb The optional database driver to be injected into the importer
 */
 #[DataProvider('dataGetImporter')]
 #[TestDox('The factory builds a database importer correctly')]
 public function testGetImporter(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -194,7 +192,7 @@ public function testGetImporter(string $adapter, bool $shouldRaiseException, boo
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $importer = $this->factory->getImporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -228,18 +226,17 @@ public static function dataGetIterator(): array
 }

 /**
 * @testdox The factory builds a database iterator correctly
 *
 * @param string $adapter The type of adapter to create
 * @param bool $createStatement Statement holding the result set to be iterated.
 */
 #[DataProvider('dataGetIterator')]
 #[TestDox('The factory builds a database iterator correctly')]
 public function testGetIterator(string $adapter, bool $createStatement)
 {
 $statement = null;

 if ($createStatement) {
 $statement = $this->createMock(StatementInterface::class);
 $statement = $this->createStub(StatementInterface::class);
 }

 $this->assertInstanceOf(
Expand DownExpand Up@@ -271,13 +268,12 @@ public static function dataGetQuery(): array
 }

 /**
 * @testdox The factory builds a database query object correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param boolean $createDb The optional database driver to be injected into the importer
 */
 #[DataProvider('dataGetQuery')]
 #[TestDox('The factory builds a database query object correctly')]
 public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -287,7 +283,7 @@ public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $this->assertInstanceOf(
Expand Down

23 changes: 6 additions & 17 deletions
Tests/DatabaseImporterTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,12 +7,10 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Database\Tests\Stubs\TestDatabaseQuery;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -41,9 +39,7 @@ protected function setUp(): void
 $this->importer = new TestDatabaseImporter();
 }

 /**
 * @testdox The importer is correctly configured when instantiated
 */
 #[TestDox('The importer is correctly configured when instantiated')]
 public function testInstantiation()
 {
 $expected = (object) [
Expand All@@ -54,30 +50,23 @@ public function testInstantiation()
 $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
 }

 /**
 * @testdox The importer can be set to XML format
 */
 #[TestDox('The importer can be set to XML format')]
 public function testAsXml()
 {
 $this->assertSame($this->importer, $this->importer->asXml(), 'The importer supports method chaining');

 $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
 }

 /**
 * @testdox A database drier can be set to the importer
 */
 #[TestDox('A database driver can be set to the importer')]
 public function testSetDbo()
 {
 /** @var DatabaseInterface|MockObject $db */
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $this->assertSame($this->importer, $this->importer->setDbo($db), 'The importer supports method chaining');
 }

 /**
 * @testdox The importer can be configured to export with structure
 */
 #[TestDox('The importer can be configured to export with structure')]
 public function testWithStructure()
 {
 $this->assertSame($this->importer, $this->importer->withStructure(false), 'The importer supports method chaining');
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[4.x] resolve PHPUnit Notices#369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Hackwar
merged 13 commits into

from

Aug 24, 2026
 Merged


[4.x] resolve PHPUnit Notices
#369
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
12a6da5

add RequiresPhpExtension


heelc29 Jul 6, 2026
e19c16a

use Stub instead of Mock with no configured expectations or call any()


heelc29 Jul 6, 2026
0e8e84a

replace DoesNotPerformAssertions attribute


heelc29 Jul 6, 2026
5d1ba4e

remove check connection driver


heelc29 Jul 6, 2026
2f60db6

connection is not available in dataprovider


heelc29 Jul 6, 2026
720a2de

updates for new mariadb versions


heelc29 Jul 6, 2026
9a7c908

remove travis code


heelc29 Jul 6, 2026
b5125b6

php8.2: Creation of dynamic property is deprecated


heelc29 Jul 6, 2026
3aa7165

php 8.5: Method Reflection*::setAccessible() is deprecated


heelc29 Jul 6, 2026
4796302

Merge branch '4.x-dev' into 4.x/phpunit/notices


heelc29 Jul 6, 2026
189ac3d

no longer used


heelc29 Aug 24, 2026
5fd7768

convert metadata doc-comment to attribute


heelc29 Aug 24, 2026
e7dd409

convert metadata doc-comment to attribute 2


heelc29 Aug 24, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


164 changes: 43 additions & 121 deletions
Tests/AbstractDatabaseDriverTestCase.php

View file


Open in desktop


Large diffs are not rendered by default.


18 changes: 6 additions & 12 deletions
Tests/DatabaseAwareTraitTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,27 +10,25 @@
use Joomla\Database\DatabaseAwareTrait;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Exception\DatabaseNotFoundException;
use PHPUnit\Framework\Attributes\CoversTrait;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
 * Tests for DatabaseAwareTrait class.
 */
#[CoversTrait(DatabaseAwareTrait::class)]
class DatabaseAwareTraitTest extends TestCase
{
 /**
 * @var DatabaseAwareTrait
 */
 protected $object;

 /**
 * @testdox Database can be set with setDatabase()
 *
 * @covers \Joomla\Database\DatabaseAwareTrait
 * @uses \Joomla\Database\Database
 */
 #[TestDox('Database can be set with setDatabase()')]
 public function testGetSetDatabase(): void
 {
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $trait = new class () {
 use DatabaseAwareTrait;
Expand All@@ -46,11 +44,7 @@ public function getDb()
 $this->assertSame($db, $trait->getDb());
 }

 /**
 * @testdox getDatabase() throws an DatabaseNotFoundException, if no database is set
 *
 * @covers \Joomla\Database\DatabaseAwareTrait
 */
 #[TestDox('getDatabase() throws an DatabaseNotFoundException, if no database is set')]
 public function testGetDatabaseException(): void
 {
 $this->expectException(DatabaseNotFoundException::class);
Expand Down

31 changes: 8 additions & 23 deletions
Tests/DatabaseExporterTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,11 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseExporter;
use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseExporter;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -43,9 +40,7 @@ protected function setUp(): void
 $this->exporter = new TestDatabaseExporter();
 }

 /**
 * @testdox The exporter is correctly configured when instantiated
 */
 #[TestDox('The exporter is correctly configured when instantiated')]
 public function testInstantiation()
 {
 $expected = (object) [
Expand All@@ -57,9 +52,7 @@ public function testInstantiation()
 $this->assertSame('xml', TestHelper::getValue($this->exporter, 'asFormat'));
 }

 /**
 * @testdox The exporter can be set to XML format
 */
 #[TestDox('The exporter can be set to XML format')]
 public function testAsXml()
 {
 $this->assertSame($this->exporter, $this->exporter->asXml(), 'The exporter supports method chaining');
Expand DownExpand Up@@ -93,12 +86,11 @@ public static function dataFrom(): array
 }

 /**
 * @testdox The tables to be exported can be configured
 *
 * @param string[]|string $from The name of a single table, or an array of the table names to export.
 * @param boolean $shouldRaiseException Flag indicating the exporter should raise an exception for an unsupported data type
 */
 #[DataProvider('dataFrom')]
 #[TestDox('The tables to be exported can be configured')]
 public function testFrom($from, bool $shouldRaiseException)
 {
 if ($shouldRaiseException) {
Expand All@@ -110,20 +102,15 @@ public function testFrom($from, bool $shouldRaiseException)
 $this->assertSame((array) $from, TestHelper::getValue($this->exporter, 'from'));
 }

 /**
 * @testdox A database drier can be set to the exporter
 */
 #[TestDox('A database driver can be set to the exporter')]
 public function testSetDbo()
 {
 /** @var DatabaseInterface|MockObject $db */
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $this->assertSame($this->exporter, $this->exporter->setDbo($db), 'The exporter supports method chaining');
 }

 /**
 * @testdox The exporter can be configured to export with structure
 */
 #[TestDox('The exporter can be configured to export with structure')]
 public function testWithStructure()
 {
 $this->assertSame($this->exporter, $this->exporter->withStructure(false), 'The exporter supports method chaining');
Expand All@@ -133,9 +120,7 @@ public function testWithStructure()
 $this->assertFalse($options->withStructure);
 }

 /**
 * @testdox The exporter can be configured to export with data
 */
 #[TestDox('The exporter can be configured to export with data')]
 public function testWithData()
 {
 $this->assertSame($this->exporter, $this->exporter->withData(true), 'The exporter supports method chaining');
Expand Down

24 changes: 10 additions & 14 deletions
Tests/DatabaseFactoryTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@
use Joomla\Database\StatementInterface;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -68,12 +69,11 @@ public static function dataGetDriver(): array
 }

 /**
 * @testdox The factory builds a database driver correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 */
 #[DataProvider('dataGetDriver')]
 #[TestDox('The factory builds a database driver correctly')]
 public function testGetDriver(string $adapter, bool $shouldRaiseException)
 {
 if ($shouldRaiseException) {
Expand DownExpand Up@@ -115,13 +115,12 @@ public static function dataGetExporter(): array
 }

 /**
 * @testdox The factory builds a database exporter correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param DatabaseDriver|null $databaseDriver The optional database driver to be injected into the exporter
 */
 #[DataProvider('dataGetExporter')]
 #[TestDox('The factory builds a database exporter correctly')]
 public function testGetExporter(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -131,7 +130,7 @@ public function testGetExporter(string $adapter, bool $shouldRaiseException, boo
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $exporter = $this->factory->getExporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -178,13 +177,12 @@ public static function dataGetImporter(): array
 }

 /**
 * @testdox The factory builds a database importer correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param boolean $createDb The optional database driver to be injected into the importer
 */
 #[DataProvider('dataGetImporter')]
 #[TestDox('The factory builds a database importer correctly')]
 public function testGetImporter(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -194,7 +192,7 @@ public function testGetImporter(string $adapter, bool $shouldRaiseException, boo
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $importer = $this->factory->getImporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -228,18 +226,17 @@ public static function dataGetIterator(): array
 }

 /**
 * @testdox The factory builds a database iterator correctly
 *
 * @param string $adapter The type of adapter to create
 * @param bool $createStatement Statement holding the result set to be iterated.
 */
 #[DataProvider('dataGetIterator')]
 #[TestDox('The factory builds a database iterator correctly')]
 public function testGetIterator(string $adapter, bool $createStatement)
 {
 $statement = null;

 if ($createStatement) {
 $statement = $this->createMock(StatementInterface::class);
 $statement = $this->createStub(StatementInterface::class);
 }

 $this->assertInstanceOf(
Expand DownExpand Up@@ -271,13 +268,12 @@ public static function dataGetQuery(): array
 }

 /**
 * @testdox The factory builds a database query object correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param boolean $createDb The optional database driver to be injected into the importer
 */
 #[DataProvider('dataGetQuery')]
 #[TestDox('The factory builds a database query object correctly')]
 public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -287,7 +283,7 @@ public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $this->assertInstanceOf(
Expand Down

23 changes: 6 additions & 17 deletions
Tests/DatabaseImporterTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,12 +7,10 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Database\Tests\Stubs\TestDatabaseQuery;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -41,9 +39,7 @@ protected function setUp(): void
 $this->importer = new TestDatabaseImporter();
 }

 /**
 * @testdox The importer is correctly configured when instantiated
 */
 #[TestDox('The importer is correctly configured when instantiated')]
 public function testInstantiation()
 {
 $expected = (object) [
Expand All@@ -54,30 +50,23 @@ public function testInstantiation()
 $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
 }

 /**
 * @testdox The importer can be set to XML format
 */
 #[TestDox('The importer can be set to XML format')]
 public function testAsXml()
 {
 $this->assertSame($this->importer, $this->importer->asXml(), 'The importer supports method chaining');

 $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
 }

 /**
 * @testdox A database drier can be set to the importer
 */
 #[TestDox('A database driver can be set to the importer')]
 public function testSetDbo()
 {
 /** @var DatabaseInterface|MockObject $db */
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $this->assertSame($this->importer, $this->importer->setDbo($db), 'The importer supports method chaining');
 }

 /**
 * @testdox The importer can be configured to export with structure
 */
 #[TestDox('The importer can be configured to export with structure')]
 public function testWithStructure()
 {
 $this->assertSame($this->importer, $this->importer->withStructure(false), 'The importer supports method chaining');
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[4.x] resolve PHPUnit Notices#369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Hackwar
merged 13 commits into

from

Aug 24, 2026
 Merged


[4.x] resolve PHPUnit Notices
#369
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
12a6da5

add RequiresPhpExtension


heelc29 Jul 6, 2026
e19c16a

use Stub instead of Mock with no configured expectations or call any()


heelc29 Jul 6, 2026
0e8e84a

replace DoesNotPerformAssertions attribute


heelc29 Jul 6, 2026
5d1ba4e

remove check connection driver


heelc29 Jul 6, 2026
2f60db6

connection is not available in dataprovider


heelc29 Jul 6, 2026
720a2de

updates for new mariadb versions


heelc29 Jul 6, 2026
9a7c908

remove travis code


heelc29 Jul 6, 2026
b5125b6

php8.2: Creation of dynamic property is deprecated


heelc29 Jul 6, 2026
3aa7165

php 8.5: Method Reflection*::setAccessible() is deprecated


heelc29 Jul 6, 2026
4796302

Merge branch '4.x-dev' into 4.x/phpunit/notices


heelc29 Jul 6, 2026
189ac3d

no longer used


heelc29 Aug 24, 2026
5fd7768

convert metadata doc-comment to attribute


heelc29 Aug 24, 2026
e7dd409

convert metadata doc-comment to attribute 2


heelc29 Aug 24, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


164 changes: 43 additions & 121 deletions
Tests/AbstractDatabaseDriverTestCase.php

View file


Open in desktop


Large diffs are not rendered by default.


18 changes: 6 additions & 12 deletions
Tests/DatabaseAwareTraitTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,27 +10,25 @@
use Joomla\Database\DatabaseAwareTrait;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Exception\DatabaseNotFoundException;
use PHPUnit\Framework\Attributes\CoversTrait;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
 * Tests for DatabaseAwareTrait class.
 */
#[CoversTrait(DatabaseAwareTrait::class)]
class DatabaseAwareTraitTest extends TestCase
{
 /**
 * @var DatabaseAwareTrait
 */
 protected $object;

 /**
 * @testdox Database can be set with setDatabase()
 *
 * @covers \Joomla\Database\DatabaseAwareTrait
 * @uses \Joomla\Database\Database
 */
 #[TestDox('Database can be set with setDatabase()')]
 public function testGetSetDatabase(): void
 {
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $trait = new class () {
 use DatabaseAwareTrait;
Expand All@@ -46,11 +44,7 @@ public function getDb()
 $this->assertSame($db, $trait->getDb());
 }

 /**
 * @testdox getDatabase() throws an DatabaseNotFoundException, if no database is set
 *
 * @covers \Joomla\Database\DatabaseAwareTrait
 */
 #[TestDox('getDatabase() throws an DatabaseNotFoundException, if no database is set')]
 public function testGetDatabaseException(): void
 {
 $this->expectException(DatabaseNotFoundException::class);
Expand Down

31 changes: 8 additions & 23 deletions
Tests/DatabaseExporterTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,11 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseExporter;
use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseExporter;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -43,9 +40,7 @@ protected function setUp(): void
 $this->exporter = new TestDatabaseExporter();
 }

 /**
 * @testdox The exporter is correctly configured when instantiated
 */
 #[TestDox('The exporter is correctly configured when instantiated')]
 public function testInstantiation()
 {
 $expected = (object) [
Expand All@@ -57,9 +52,7 @@ public function testInstantiation()
 $this->assertSame('xml', TestHelper::getValue($this->exporter, 'asFormat'));
 }

 /**
 * @testdox The exporter can be set to XML format
 */
 #[TestDox('The exporter can be set to XML format')]
 public function testAsXml()
 {
 $this->assertSame($this->exporter, $this->exporter->asXml(), 'The exporter supports method chaining');
Expand DownExpand Up@@ -93,12 +86,11 @@ public static function dataFrom(): array
 }

 /**
 * @testdox The tables to be exported can be configured
 *
 * @param string[]|string $from The name of a single table, or an array of the table names to export.
 * @param boolean $shouldRaiseException Flag indicating the exporter should raise an exception for an unsupported data type
 */
 #[DataProvider('dataFrom')]
 #[TestDox('The tables to be exported can be configured')]
 public function testFrom($from, bool $shouldRaiseException)
 {
 if ($shouldRaiseException) {
Expand All@@ -110,20 +102,15 @@ public function testFrom($from, bool $shouldRaiseException)
 $this->assertSame((array) $from, TestHelper::getValue($this->exporter, 'from'));
 }

 /**
 * @testdox A database drier can be set to the exporter
 */
 #[TestDox('A database driver can be set to the exporter')]
 public function testSetDbo()
 {
 /** @var DatabaseInterface|MockObject $db */
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $this->assertSame($this->exporter, $this->exporter->setDbo($db), 'The exporter supports method chaining');
 }

 /**
 * @testdox The exporter can be configured to export with structure
 */
 #[TestDox('The exporter can be configured to export with structure')]
 public function testWithStructure()
 {
 $this->assertSame($this->exporter, $this->exporter->withStructure(false), 'The exporter supports method chaining');
Expand All@@ -133,9 +120,7 @@ public function testWithStructure()
 $this->assertFalse($options->withStructure);
 }

 /**
 * @testdox The exporter can be configured to export with data
 */
 #[TestDox('The exporter can be configured to export with data')]
 public function testWithData()
 {
 $this->assertSame($this->exporter, $this->exporter->withData(true), 'The exporter supports method chaining');
Expand Down

24 changes: 10 additions & 14 deletions
Tests/DatabaseFactoryTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@
use Joomla\Database\StatementInterface;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -68,12 +69,11 @@ public static function dataGetDriver(): array
 }

 /**
 * @testdox The factory builds a database driver correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 */
 #[DataProvider('dataGetDriver')]
 #[TestDox('The factory builds a database driver correctly')]
 public function testGetDriver(string $adapter, bool $shouldRaiseException)
 {
 if ($shouldRaiseException) {
Expand DownExpand Up@@ -115,13 +115,12 @@ public static function dataGetExporter(): array
 }

 /**
 * @testdox The factory builds a database exporter correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param DatabaseDriver|null $databaseDriver The optional database driver to be injected into the exporter
 */
 #[DataProvider('dataGetExporter')]
 #[TestDox('The factory builds a database exporter correctly')]
 public function testGetExporter(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -131,7 +130,7 @@ public function testGetExporter(string $adapter, bool $shouldRaiseException, boo
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $exporter = $this->factory->getExporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -178,13 +177,12 @@ public static function dataGetImporter(): array
 }

 /**
 * @testdox The factory builds a database importer correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param boolean $createDb The optional database driver to be injected into the importer
 */
 #[DataProvider('dataGetImporter')]
 #[TestDox('The factory builds a database importer correctly')]
 public function testGetImporter(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -194,7 +192,7 @@ public function testGetImporter(string $adapter, bool $shouldRaiseException, boo
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $importer = $this->factory->getImporter($adapter, $databaseDriver);
Expand DownExpand Up@@ -228,18 +226,17 @@ public static function dataGetIterator(): array
 }

 /**
 * @testdox The factory builds a database iterator correctly
 *
 * @param string $adapter The type of adapter to create
 * @param bool $createStatement Statement holding the result set to be iterated.
 */
 #[DataProvider('dataGetIterator')]
 #[TestDox('The factory builds a database iterator correctly')]
 public function testGetIterator(string $adapter, bool $createStatement)
 {
 $statement = null;

 if ($createStatement) {
 $statement = $this->createMock(StatementInterface::class);
 $statement = $this->createStub(StatementInterface::class);
 }

 $this->assertInstanceOf(
Expand DownExpand Up@@ -271,13 +268,12 @@ public static function dataGetQuery(): array
 }

 /**
 * @testdox The factory builds a database query object correctly
 *
 * @param string $adapter The type of adapter to create
 * @param boolean $shouldRaiseException Flag indicating the factory should raise an exception for an unsupported adapter
 * @param boolean $createDb The optional database driver to be injected into the importer
 */
 #[DataProvider('dataGetQuery')]
 #[TestDox('The factory builds a database query object correctly')]
 public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $createDb)
 {
 if ($shouldRaiseException) {
Expand All@@ -287,7 +283,7 @@ public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $
 $databaseDriver = null;

 if ($createDb) {
 $databaseDriver = $this->createMock(MysqliDriver::class);
 $databaseDriver = $this->createStub(MysqliDriver::class);
 }

 $this->assertInstanceOf(
Expand Down

23 changes: 6 additions & 17 deletions
Tests/DatabaseImporterTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,12 +7,10 @@

namespace Joomla\Database\Tests;

use Joomla\Database\DatabaseImporter;
use Joomla\Database\DatabaseInterface;
use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
use Joomla\Database\Tests\Stubs\TestDatabaseQuery;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;

/**
Expand DownExpand Up@@ -41,9 +39,7 @@ protected function setUp(): void
 $this->importer = new TestDatabaseImporter();
 }

 /**
 * @testdox The importer is correctly configured when instantiated
 */
 #[TestDox('The importer is correctly configured when instantiated')]
 public function testInstantiation()
 {
 $expected = (object) [
Expand All@@ -54,30 +50,23 @@ public function testInstantiation()
 $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
 }

 /**
 * @testdox The importer can be set to XML format
 */
 #[TestDox('The importer can be set to XML format')]
 public function testAsXml()
 {
 $this->assertSame($this->importer, $this->importer->asXml(), 'The importer supports method chaining');

 $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
 }

 /**
 * @testdox A database drier can be set to the importer
 */
 #[TestDox('A database driver can be set to the importer')]
 public function testSetDbo()
 {
 /** @var DatabaseInterface|MockObject $db */
 $db = $this->createMock(DatabaseInterface::class);
 $db = $this->createStub(DatabaseInterface::class);

 $this->assertSame($this->importer, $this->importer->setDbo($db), 'The importer supports method chaining');
 }

 /**
 * @testdox The importer can be configured to export with structure
 */
 #[TestDox('The importer can be configured to export with structure')]
 public function testWithStructure()
 {
 $this->assertSame($this->importer, $this->importer->withStructure(false), 'The importer supports method chaining');
Expand Down
Loading
Loading