fix(types): add Unit x array overloads for multiply and dotMultiply - #3691
Open
abhijeet117 wants to merge 1 commit into
Open
fix(types): add Unit x array overloads for multiply and dotMultiply#3691abhijeet117 wants to merge 1 commit into
abhijeet117 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multiplyanddotMultiplysupport multiplying aUnitby an array of numbers at runtime (each entry scales the unit), but no declared overload expressed it:multiply(unit, array)fell through to theMathTypecatch-all anddotMultiply(unit, array)resolved to the generic collection overload returning the array's own element type. This addsUnit x MathNumericType[]overloads in both argument orders returningUnit[], matching the runtime result.Testing
A scratch file calling all four forms (
multiply/dotMultiplywith the unit on either side) failedtsc --strictbefore the change with "Type 'MathType' is not assignable to type 'Unit[]'" and "'number[]' is not assignable to type 'Unit[]'", and compiles cleanly after. Runtime behavior is unchanged; the outputs match the examples in #3660. eslint passes on types/index.d.ts.Checklist