Handle chknum in transaction field - #173
Open
ludo-c wants to merge 18 commits into
Open
Conversation
ludo-cforce-pushed
the
handle_chknum_field
branch
2 times, most recently
from
November 27, 2023 07:18
7cef8d8 to
20f4a9bCompare
…ASCII with charset 8859-1
Allow parsing of number containing spaces or startting with a '+' sign. Such as '1 025,58' or '+1205'.
In a transaction dtuser reflects the date at which the transaction is actually done. dtposted (the current date property of the transaction object) reflects the date at which the transaction is effective. This patch adds the dtuser to the transaction object as user_date. Closes: jseutter#150
ludo-cforce-pushed
the
handle_chknum_field
branch
from
November 27, 2023 08:25
20f4a9b to
36d2146Compareludo-cforce-pushed
the
handle_chknum_field
branch
from
November 27, 2023 08:26
36d2146 to
bed9baaCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
This PR adds the support of the
chknumfield in a transaction.It's the same than
checknum, I don't know why there are two names for the same thing.I added a test with that field, all other tests are still ok
Ran 68 tests in 0.282s.I don't think one ofx file can have both fields, that's why I reused the
transaction.checknumattribute.