Fix: Expect return true immediately if If-None-Match matches the ETag header (#35)

[iambinlin]

Main Changes

Expect return true immediately if If-None-Match matches the ETag header.

Context

Closes#35

[UlisesGascon]

Thanks for making this work @bigbigDreamer!

AFAIK, seems like this is a major change in terms of semver. I will love to have some additional reviews before we merge it (I am not an expert on fresh) 👍

[ctcpip]

AFAIK, seems like this is a major change in terms of semver.

there is no perfect answer, but you could argue that a breaking change caused by spec-compliance where you don't do a major version bump does not violate semver. unrelated but similar issue I ran into last week: github.com/bcgit/bc-java/issues/1641

[rxmarbles]

Also don't have perms to approve but a ➕1 from me 😄

[wesleytodd]

I am adding this to the list of required releases before we land express@5. I have not had a chance to read all the relevant context, but it does seem that we could land this as a major along with dropping support for some old node versions to release along side v5.

[jonchurch]

Updated the PR to early return from the for loop. The change to the flow of the code allows us to do that, while previously we fell through to give the other header a chance to invalidate.

When we have an if-none-match, we must decide fresh based on that