Skip to content

ci: add nodejs v18 - v24 to test matrix - #127

Merged
UlisesGascon merged 5 commits into
jshttp:masterfrom
Phillip9587:ci
Aug 29, 2025
Merged

ci: add nodejs v18 - v24 to test matrix#127
UlisesGascon merged 5 commits into
jshttp:masterfrom
Phillip9587:ci

Conversation

@Phillip9587

Copy link
Copy Markdown
Contributor

This pull request updates the Node.js versions tested in the CI workflow to include newer releases.

Comment threadtest/test.js Outdated
@bjohansebas

Copy link
Copy Markdown
Member

v23 is failing

@Phillip9587

Copy link
Copy Markdown
ContributorAuthor

v23 is failing

Please take a look at my comment

@Phillip9587

Copy link
Copy Markdown
ContributorAuthor

@bjohansebas@UlisesGascon Can you take another look? I updated the test to include a isError fallback for Node 23. The CI failures are just related to Coveralls current status: https://status.coveralls.io/incidents/fr6sp5kyn128

@bjohansebasbjohansebas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Phillip9587

Copy link
Copy Markdown
ContributorAuthor

Hey @UlisesGascon can we merge this? I adressed all the feedback.

@UlisesGasconUlisesGascon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGasconUlisesGascon self-assigned this Aug 29, 2025
@UlisesGascon
UlisesGascon merged commit 7a05446 into jshttp:masterAug 29, 2025
79 of 88 checks passed
@Phillip9587
Phillip9587 deleted the ci branch August 29, 2025 10:23
@UlisesGasconUlisesGascon mentioned this pull request Nov 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Phillip9587@bjohansebas@UlisesGascon