Uh oh!
There was an error while loading. Please reload this page.
Consistency - #21
Closed
tkrotoff wants to merge 2 commits into
Closed
Conversation
tkrotoff
commented
Nov 3, 2015
ContributorAuthor
Node.js 0.6 and 0.8 builds fail because of dependencies, nothing related to the PR itself. |
dougwilson
commented
Jan 22, 2016
Contributor
lol, forgot about this pull request. I'll merge :) |
dougwilson pushed a commit
that referenced
this pull request
Jan 22, 2016
tkrotoff
commented
Jan 22, 2016
ContributorAuthor
Wow, I did not know you could change the commit messages from a PR, nice :) |
dougwilson
commented
Jan 23, 2016
Contributor
haha, yea. Here is what I did, if you're interested:
I hope that was OK :) ! I try to make it easy to accept PRs by just fixing up nits on merge instead of requiring random back-and-forth for "dumb reasons" :) |
tkrotoff
commented
Jan 23, 2016
ContributorAuthor
Wow bis! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistency/bikeshedding