Skip to content

Consistency - #21

Closed
tkrotoff wants to merge 2 commits into
jshttp:masterfrom
tkrotoff:master
Closed

Consistency#21
tkrotoff wants to merge 2 commits into
jshttp:masterfrom
tkrotoff:master

Conversation

@tkrotoff

Copy link
Copy Markdown
Contributor

Consistency/bikeshedding

@dougwilsondougwilson self-assigned this Oct 30, 2015
@tkrotoff

Copy link
Copy Markdown
ContributorAuthor

Node.js 0.6 and 0.8 builds fail because of dependencies, nothing related to the PR itself.

@dougwilson

Copy link
Copy Markdown
Contributor

lol, forgot about this pull request. I'll merge :)

dougwilson pushed a commit that referenced this pull request Jan 22, 2016
@tkrotoff

Copy link
Copy Markdown
ContributorAuthor

Wow, I did not know you could change the commit messages from a PR, nice :)

@dougwilson

Copy link
Copy Markdown
Contributor

haha, yea. Here is what I did, if you're interested:

  1. GitHub has some buried secrets around it, including the fact that you can append .patch to a pull request URL and it'll be a git-formatted patch file. I then go into git command line on my machine and apply that patch using git am, with the following command: curl -L https://github.com/jshttp/http-errors/pull/21.patch | git am.
  2. Then I make adjustments to the patch for nits, and then git commit --amend to alter the message for nits (and to add a link to the PR #, which of course you couldn't easily know before making the PR).

I hope that was OK :) ! I try to make it easy to accept PRs by just fixing up nits on merge instead of requiring random back-and-forth for "dumb reasons" :)

@tkrotoff

Copy link
Copy Markdown
ContributorAuthor

Wow bis!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tkrotoff@dougwilson