Uh oh!
There was an error while loading. Please reload this page.
build: Node.js@14.5 - #18
Merged
Merged
Conversation
dougwilson
suggested changes
Jul 4, 2020
dougwilson
left a comment
Contributor
There was a problem hiding this comment.
please tell me History.md should be updated or not
As long as there were no changes needed to support that version of Node.js, not history is needed. This is because the previous versions would have worked.
The only thing of note here is that these should be at least separate commits, ideally separate PRs, as there are two different things being changed here (adding Node.js 14.x and bumping the 13.x minor.
3imed-jaberiforce-pushed
the
support-nodejs-14.x
branch
from
July 4, 2020 22:15
db0622e to
e68f6faCompare2 tasks
3imed-jaberiforce-pushed
the
support-nodejs-14.x
branch
from
July 4, 2020 22:32
e68f6fa to
47e9fc4Comparedougwilson
suggested changes
Jul 6, 2020
dougwilson
left a comment
Contributor
There was a problem hiding this comment.
If you are adding Node.js 14 in this PR, you shouldn't be removing Node.js 13 as well, we need to keep 13 there as well.
dougwilsonforce-pushed
the
support-nodejs-14.x
branch
from
July 8, 2020 02:24
e0e6a2d to
c489db0Comparedougwilson
approved these changes
Jul 8, 2020
dougwilsonforce-pushed
the
support-nodejs-14.x
branch
from
February 13, 2021 03:05
c489db0 to
416a004Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dougwilson, please tell me
History.mdshould be updated or not !