ci(deploy): load Cloudflare credentials from the jshvn vault - #7
Merged
Merged
Conversation
The two Cloudflare values move from repository secrets into 1Password, item dispatch, section cloudflare. The one repository secret left is the service account token that reads them, loaded after the test steps so third-party tooling never has the deploy credentials in its environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The two Cloudflare values move from repository secrets into 1Password: vault
jshvn, itemdispatch, sectioncloudflare.deploy.ymlloads them withload-secrets-actionafter the test steps, so third-party tooling never has the deploy credentials in its environment, and the one repository secret left is the service account token. README's "Repo secrets" section goes from two secrets to one.deploy.ymlignores.github/**, so merging this does not deploy; verification is oneworkflow_dispatch.Test plan
OP_SERVICE_ACCOUNT_TOKENset on this repository before mergeCLOUDFLARE_API_TOKENandCLOUDFLARE_ACCOUNT_IDfrom this repository