Skip to content

Fix for #80 - #81

Open
daniel-sullivan wants to merge 1 commit into
jsonapi-rb:masterfrom
daniel-sullivan:fix-for-conditionals
Open

Fix for #80#81
daniel-sullivan wants to merge 1 commit into
jsonapi-rb:masterfrom
daniel-sullivan:fix-for-conditionals

Conversation

@daniel-sullivan

Copy link
Copy Markdown

Fix for conditional attribute inclusion using the 0.2.1 conditional_fields.rb

end



Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra blank line detected.

_register_condition(field_condition_blocks, name, options)
end


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra blank line detected.

end
self.field_condition_blocks ||= {}
self.link_condition_blocks ||= {}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra empty line detected at block body end.

@codecov

codecovBot commented Aug 9, 2017

Copy link
Copy Markdown

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #81 +/- ##
=======================================
Coverage 99.47% 99.47% =======================================
Files 12 12 Lines 379 379 =======================================
Hits 377 377 Misses 2 2
Impacted FilesCoverage Δ
...sonapi/serializable/resource/conditional_fields.rb96% <100%> (ø)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ecab17...c5fdc93. Read the comment docs.

@beaubybeauby changed the title Fix for https://github.com/jsonapi-rb/jsonapi-serializable/issues/80Fix for #80Aug 10, 2017
@beauby

Copy link
Copy Markdown
Member

Hi @daniel-sullivan – thanks for this PR! I'm currently on the road but will take a closer look asap 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@daniel-sullivan@beauby@houndci-bot