Uh oh!
There was an error while loading. Please reload this page.
fix: Repair broken sitemap and RSS links in footer - #20
Merged
Conversation
The footer linked to sitemap.html, but Hyde writes the sitemap as sitemap.xml, so the link 404'd. It also linked feed.xml unconditionally, which is never generated: Features::hasRss() requires at least one Markdown post and _posts/ is empty. Point the sitemap link at sitemap.xml and wrap both links in Features::hasSitemap() / Features::hasRss() guards, so the RSS link returns automatically if a blog is ever added. Take the RSS filename from RssFeedGenerator::getFilename() instead of hardcoding it. Also fix the "site was build" typo and switch the Documentation link to Hyde::relativeLink() to match the other internal links. The rebuilt _site was generated with SITE_URL set to the production URL, matching the CI build, so it now contains sitemap.xml and the page output the deployed site actually serves. It also picks up the strict mode docs, which were not rebuilt in #19. Fixes#6 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#6
The footer linked to
sitemap.html, but Hyde writes the sitemap assitemap.xml, so the link 404'd. It also linkedfeed.xmlunconditionally, which is never generated —Features::hasRss()requires at least one Markdown post and_posts/is empty.sitemap.xmlFeatures::hasSitemap()/Features::hasRss(), so the RSS link returns automatically if a blog is ever addedRssFeedGenerator::getFilename()instead of hardcoding itHyde::relativeLink()to match the other internal linksThe rebuilt
_sitewas generated withSITE_URLset to the production URL, matching the CI workflow, so it now containssitemap.xmland the output the deployed site actually serves. It also picks up the strict mode docs, which were not rebuilt in #19.Note:
_site/docs/community-guide.htmland_site/docs/configuration.htmlare pre-existing orphans with no source in_docs/. Left untouched here.🤖 Generated with Claude Code