Skip to content

Add code review edits to components #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jadeddelta merged 2 commits into from
Jul 21, 2022
Merged

Add code review edits to components #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aeb658
sample edits from code review
jodeleeuw Jul 19, 2022
cb3248a
code review changes
jadeddelta Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions examples/example-components.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,17 @@
const Eyetracker = eyetrack.initEyetracker();
const comp = eyetrack.initComponents(Eyetracker);

// basically a "go to the next stage" button
const clearComponentsButton = document.createElement("button");
clearComponentsButton.textContent = "Next";
clearComponentsButton.addEventListener("click", () => {
comp.clearComponents();
});

async function start() {
const landing = await comp.createLanding();
document.body.append(landing);
// create a wrapper so that the button doesn't stretch b/c landing is flex
let wrapper = document.createElement("div");
let next = clearComponentsButton;
let next = document.createElement("button");
next.innerText = "Next";
// invokes the next step and clears itself
next.addEventListener("click", () => {
next.parentNode.parentNode.remove();
selectorPrompt();
next.parentNode.remove();
});
wrapper.append(next);
landing.append(wrapper);
Expand Down
Loading