Fix Mac Intel H3 c=64 cliff vs YARP - #1027
Merged
Merged
Conversation
justcoding121
force-pushed
the
fix/mac-h3-c64-cliff
branch
from
September 9, 2026 22:16
942e85d to
87574fb
Compare
Darwin-safe Flush stays; skip a second FIN when completeWrites:true already closed the QuicStream write side so Mac Intel H3 reverse arms stop rolling over at c=64 vs YARP.
justcoding121
force-pushed
the
fix/mac-h3-c64-cliff
branch
from
September 9, 2026 22:17
87574fb to
f1a527e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompleteWrites()after STREAM+FIN + Darwin-safeFlushAsyncon H3 client/origin paths.QuicConnectionPoolto up to 4 shared origin QUIC connections when in-flight streams hit SoftGrow=32 (H3→H3 fan-in under scarce cores).Test plan
QuicConnectionPoolTests(share, soft-grow, cap)compare-spot@fix/mac-h3-c64-cliffrun 34390832577 (macos-15-intel + Win/Linux)