Unnecessary load on Memories.wrap

[ahmetcanik]

Validate.notIllegalArgument(buffer.isDirect(), new IllegalArgumentException(String.format("buffer.isDirect(): %b (expected: direct buffer)", buffer.isDirect())));

Second argument is executed independent of the truth value of the first one. Thus even buffer.isDirect is true, IllegalArgumentException constructor and String.format is executed. This yields unnecessary computation on CPU. An example jvisualvm CPU sampling is shown below.

[ardikars]

Thanks @ahmetcanik, I'll review soon.

[ardikars]

It's already fixed at ardikars/pcap@3b98942, but haven't updated on this project.
I've planed to fix this issue at the end of this month.