Skip to content

feat: better logs - #38

Merged
fpelliccioni merged 1 commit into
masterfrom
feat/better-logs
May 5, 2025
Merged

feat: better logs#38
fpelliccioni merged 1 commit into
masterfrom
feat/better-logs

Conversation

@fpelliccioni

Copy link
Copy Markdown
Contributor

No description provided.

@fpelliccioni
fpelliccioni requested a review from Copilot May 5, 2025 11:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines logging functionality and output messages across several modules while introducing a new ASCII art display when standard output is enabled.

  • Comment out outdated log calls in protocol transaction handling.
  • Modify log format in block reporting.
  • Add conditional ASCII art printing in the executor module.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/protocols/protocol_transaction_in.cpp Commented out log messages to disable obsolete debug/info outputs.
src/protocols/protocol_block_in.cpp Adjusted the log formatting string by removing the "Block" prefix.
src/executor/executor.cpp & executor.hpp Added an ASCII art display and a new flag to optionally control its output.
Comments suppressed due to low confidence (1)

src/executor/executor.cpp:371

  • [nitpick] Ensure that printing ASCII art to standard output is appropriate for production environments; consider gating this feature by an environment flag if necessary.
void executor::print_ascii_art() {

Comment thread src/protocols/protocol_transaction_in.cpp
Comment thread src/protocols/protocol_transaction_in.cpp
Comment thread src/protocols/protocol_block_in.cpp
@fpelliccioni
fpelliccioni merged commit 3d34cb3 into master May 5, 2025
@fpelliccioni
fpelliccioni deleted the feat/better-logs branch May 5, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants