Skip to content

Add Search campaign expansion, asset tools, and CPC-cap support - #4

Closed
sblOWPCKCR wants to merge 1 commit into
kLOsk:mainfrom
sblOWPCKCR:ex
Closed

Add Search campaign expansion, asset tools, and CPC-cap support#4
sblOWPCKCR wants to merge 1 commit into
kLOsk:mainfrom
sblOWPCKCR:ex

Conversation

@sblOWPCKCR

Copy link
Copy Markdown
Contributor
  • add draft_ad_group and update_ad_group for existing campaigns
  • extend draft_campaign/update_campaign with Search partners and display expansion settings
  • support max_cpc for MANUAL_CPC ad-group bids and TARGET_SPEND (Maximize Clicks) CPC caps
  • add draft_callouts, draft_structured_snippets, and draft_image_assets
  • create shared campaign-asset mutation helper for campaign-level assets
  • fix image asset uploads by setting required asset names and preserving compatibility with older pending plans
  • add write-layer tests covering validation, field masks, campaign settings, asset creation, and image upload regressions

- add draft_ad_group and update_ad_group for existing campaigns
- extend draft_campaign/update_campaign with Search partners and display expansion settings
- support max_cpc for MANUAL_CPC ad-group bids and TARGET_SPEND (Maximize Clicks) CPC caps
- add draft_callouts, draft_structured_snippets, and draft_image_assets
- create shared campaign-asset mutation helper for campaign-level assets
- fix image asset uploads by setting required asset names and preserving compatibility with older pending plans
- add write-layer tests covering validation, field masks, campaign settings, asset creation, and image upload regressions
kLOsk added a commit that referenced this pull request Mar 23, 2026
…CPC-cap support

Rebased on main after merging PRs #2, #3, #6. Removed duplicate
draft_ad_group (kept PR #6's version with preflight checks). Adds:
- update_ad_group, draft_callouts, draft_structured_snippets, draft_image_assets
- Campaign expansion settings (search_partners, display_network, max_cpc)
- Structured error handling for developer token and OAuth issues
- Shared _apply_campaign_assets helper replacing duplicated sitelink logic

All 77 tests pass.
@kLOsk

kLOsk commented Mar 23, 2026

Copy link
Copy Markdown
Owner

Merged manually after rebasing on main (which now includes PRs #2, #3, #6).

Changes during rebase:

Thanks for the substantial contribution @sblOWPCKCR!

@kLOsk kLOsk closed this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants