Add Search campaign expansion, asset tools, and CPC-cap support - #4
Closed
sblOWPCKCR wants to merge 1 commit into
Closed
Add Search campaign expansion, asset tools, and CPC-cap support#4sblOWPCKCR wants to merge 1 commit into
sblOWPCKCR wants to merge 1 commit into
Conversation
sblOWPCKCR
commented
Mar 20, 2026
Contributor
- add draft_ad_group and update_ad_group for existing campaigns
- extend draft_campaign/update_campaign with Search partners and display expansion settings
- support max_cpc for MANUAL_CPC ad-group bids and TARGET_SPEND (Maximize Clicks) CPC caps
- add draft_callouts, draft_structured_snippets, and draft_image_assets
- create shared campaign-asset mutation helper for campaign-level assets
- fix image asset uploads by setting required asset names and preserving compatibility with older pending plans
- add write-layer tests covering validation, field masks, campaign settings, asset creation, and image upload regressions
- add draft_ad_group and update_ad_group for existing campaigns - extend draft_campaign/update_campaign with Search partners and display expansion settings - support max_cpc for MANUAL_CPC ad-group bids and TARGET_SPEND (Maximize Clicks) CPC caps - add draft_callouts, draft_structured_snippets, and draft_image_assets - create shared campaign-asset mutation helper for campaign-level assets - fix image asset uploads by setting required asset names and preserving compatibility with older pending plans - add write-layer tests covering validation, field masks, campaign settings, asset creation, and image upload regressions
kLOsk
added a commit
that referenced
this pull request
Mar 23, 2026
…CPC-cap support Rebased on main after merging PRs #2, #3, #6. Removed duplicate draft_ad_group (kept PR #6's version with preflight checks). Adds: - update_ad_group, draft_callouts, draft_structured_snippets, draft_image_assets - Campaign expansion settings (search_partners, display_network, max_cpc) - Structured error handling for developer token and OAuth issues - Shared _apply_campaign_assets helper replacing duplicated sitelink logic All 77 tests pass.
Owner
|
Merged manually after rebasing on main (which now includes PRs #2, #3, #6). Changes during rebase:
Thanks for the substantial contribution @sblOWPCKCR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.