chore: fold the weather entries into one before the version cut - #338
Merged
Conversation
Three changesets described one story from three angles — the strip crossing midnight, an open window refreshing itself, and a reading whose age the clock made unknowable. One entry reads better in the CHANGELOG than three adjacent weather bullets. Dropped the orphaned-reading line outright: clearing a reading whose city can no longer be read has no effect a user can see, since the chip renders nothing either way, and the packages it bumped are covered by the entry that remains.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changesets described one story from three angles — the strip crossing midnight (ENG-107), an open window refreshing itself (ENG-109), and a reading whose age the clock made unknowable (ENG-111). One entry reads better in the CHANGELOG than three adjacent weather bullets.
Dropped
orphaned-weather-reading(ENG-112) outright rather than folding it in: clearing a reading whose city can no longer be read has no effect a user can see — the chip renders nothing either way — and the three packages it bumped are all covered by the entry that remains.Net: 5 pending changesets → 3. The other two (
in-app-feature-requests,macos-external-links) are separate features and stay as they are.Everything still bumps
patch, so the version cut lands on v1.25.1.