Uh oh!
There was an error while loading. Please reload this page.
Feat/kdc 1829 ruby version migration - #1
Open
agultekin wants to merge 11 commits into
Open
Conversation
corrections with rubocop ignore
Tests & Rubocop are OK
Roddoric
requested changes
May 27, 2026
Roddoric
left a comment
There was a problem hiding this comment.
LGTM but double check the should in tests
| module Symbol | ||
| def to_edn | ||
| ":#{self.to_s}" | ||
| ":#{self}" |
There was a problem hiding this comment.
Suggested change
| ":#{self}" | |
| ":#{to_s}" |
Wouldn't this work ? I think I prefer having the self implicit than the to_s
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+65
to
+67
| return TAGS[tag] = func unless func.is_a?(Class) | ||
| TAGS[tag] = ->(*args) { func.new(*args) } |
There was a problem hiding this comment.
Suggested change
| returnTAGS[tag]=funcunlessfunc.is_a?(Class) | |
| TAGS[tag]=->(*args){func.new(*args)} | |
| TAGS[tag]=handler.is_a?(Class) ? ->(*args){handler.new(*args)} : handler |
Uh oh!
There was an error while loading. Please reload this page.
tests corrections
tests corrections
PR Requested changes
Roddoric
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 3.4.9