Lets the parser recognize new HTML5 body tags. - #3
Open
jmacdotorg wants to merge 1 commit into
Open
Conversation
Zarabozo
commented
Feb 15, 2021
This fix was submitted more than 2 years ago. What is going on? I had to add this to my scripts to have them recognize the 'nav' tag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple change adds a list of valid new-to-HTML5 tags to one of the module's internal hashes of valid tags. This fixes the issue described in RT #84526.
The root cause of this issue lies within HTML::Tagset, but its maintainer is on-record of not supporting this change within that module, and has been for several years. So, I propose adding it here instead.
(This patch takes the same tack I have had to take with some of my own code that uses HTML::TreeBuilder.)