Skip to content

fix : do not record test-case while in test mode - #46

Open
shreyanshshah27 wants to merge 2 commits into
keploy:mainfrom
shreyanshshah27:bugfix/gh-42
Open

fix : do not record test-case while in test mode#46
shreyanshshah27 wants to merge 2 commits into
keploy:mainfrom
shreyanshshah27:bugfix/gh-42

Conversation

@shreyanshshah27

Copy link
Copy Markdown

No description provided.

@re-Tick

Copy link
Copy Markdown
Contributor

Hi @shreyanshshah27, CI is failing due to incorrect commit format. Please follow this format "fix: <COMMIT_MESSAGE>"

Signed-off-by: Shreyansh Shah <shreyansh_shah@yahoo.com>
@shreyanshshah27

Copy link
Copy Markdown
Author

Hey @re-Tick I've made the commit name changes.

Comment threadintegrations/express/middleware.ts Outdated
return;
}

if (process.env.KEPLOY_MODE=="test") {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use MODE_TEST constant intead of "test" here and use "equality without type coersion”.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@re-Tickre-TickMar 3, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: Shreyansh Shah <shreyansh_shah@yahoo.com>
@re-Tick

Copy link
Copy Markdown
Contributor

Hey @shreyanshshah27, Please add link to this PR in GSOC/2023 Task List.

@shreyanshshah27

Copy link
Copy Markdown
Author

Hey @re-Tick

I've created a PR, to link this task in GSOC/2023 Task List.

@re-Tickre-Tick added good first issue Good for newcomers Accepted PR is reviewed and Accepted Don't Merge Not to be merged until gsoc results and removed Accepted PR is reviewed and Accepted labels Mar 6, 2023
@keploy

keployBot commented Apr 15, 2025

Copy link
Copy Markdown

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

1 similar comment
@keploy-staging

Copy link
Copy Markdown

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AcceptedPR is reviewed and AcceptedDon't MergeNot to be merged until gsoc resultsgood first issueGood for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@shreyanshshah27@re-Tick