Skip to content

feat(mock.ts, keploy.ts, client.ts): Adding Keploy Mode in logs to no… - #48

Open
Hermione2408 wants to merge 3 commits into
keploy:mainfrom
Hermione2408:feature/gh-45
Open

feat(mock.ts, keploy.ts, client.ts): Adding Keploy Mode in logs to no…#48
Hermione2408 wants to merge 3 commits into
keploy:mainfrom
Hermione2408:feature/gh-45

Conversation

@Hermione2408

@Hermione2408Hermione2408 commented Feb 25, 2023•
edited
Loading

Copy link
Copy Markdown

Adding Keploy mode in logs to notify user in which mode keploy is running whether it is record, test, off

feat keploy/keploy#390
Closes: keploy/keploy#390

@re-Tick

re-Tick commented Mar 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @Hermione2408, we just need to log mode only once which could be from src/keploy.go and mock/mock.go

This console statements can be in the constructor of Keploy class.

re-Tick
re-Tick reviewed Mar 2, 2023
View reviewed changes
Comment threadmock/mock.ts Outdated
Mode: string;
}
export function NewContext(conf: Config) {
console.log("Keploy running in: ",process.env.KEPLOY_MODE," mode");

@re-Tickre-TickMar 2, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please place this log statement after this because here we are considering mode either from env variable or conf.mode parameter. Also log value of "mode" in log statement instead of process.env

@Hermione2408
feat(mock.ts, keploy.ts, client.ts): adding Keploy Mode in logs to no…
deded77
…tify user
Adding Keploy mode in logs to notify user in which mode keploy is running whether it is record,
test, off
feat #45
Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
@Hermione2408
feat(keploy.ts, mock.ts): adding log in Keploy.ts and mock.ts
9b70a76
feat #45
Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
@Hermione2408
feat: changing log position in mock.ts
1ad2d59
feat #45
Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
@re-Tick

re-Tick commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

LGTM. Hey @Hermione2408 , Please add link to this PR in GSOC/2023 Task List .

@Hermione2408

Hermione2408 commented Mar 3, 2023

Copy link
Copy Markdown
Author

Done.

@re-Tickre-Tick added good first issue Good for newcomers Accepted PR is reviewed and Accepted labels Mar 6, 2023
@SonichigoSonichigo added the Don't Merge Not to be merged until gsoc results label Mar 6, 2023
@re-Tickre-Tick added Accepted PR is reviewed and Accepted and removed Accepted PR is reviewed and Accepted labels Mar 7, 2023
@keploy

keployBot commented Apr 15, 2025•
edited
Loading

Copy link
Copy Markdown

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

1 similar comment
@keploy-staging

keploy-stagingBot commented Apr 17, 2025

Copy link
Copy Markdown

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@re-Tickre-Tickre-Tick left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

AcceptedPR is reviewed and AcceptedDon't MergeNot to be merged until gsoc resultsgood first issueGood for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feature]: need to log the keploy mode

3 participants

@Hermione2408@re-Tick@Sonichigo