Adding Unit test cases for wrappedNodeFetch and adding github actions by Hermione2408 · Pull Request #59 · keploy/typescript-sdk

Hermione2408 · 2023-03-08T17:16:36Z

For code coverage added unit test for wrappedNodeFetch function and integrated git hub actions.

test #354
Closes: keploy/keploy#354

developer-diganta · 2023-03-08T17:24:24Z

Hi @re-Tick! Can you please review the PR?

re-Tick · 2023-03-08T19:05:27Z

@Hermione2408 please resolve DCO and commitzen

Hermione2408 · 2023-03-08T20:25:31Z

Can you have a look now @re-Tick

Hermione2408 · 2023-03-13T15:53:21Z

Hey @re-Tick , Can you please review the changes now

re-Tick · 2023-03-14T06:37:28Z

a test is failing. I will try these changes locally and request changes if any.

Hermione2408 · 2023-03-14T08:36:25Z

Sure I'll try to resolve too where they are failing

re-Tick · 2023-03-14T08:36:57Z

+
+describe('wrappedNodeFetch', () => {
+ it('should call fetch function with correct arguments in record mode', async () => {
+ const mockFetch = jest.fn().mockResolvedValueOnce(new Response());


Since, outputs are recorded when end event is triggered for response of fetch. We dont need to mock fetch here. We can use the actual fetch of node-fetch

re-Tick · 2023-03-14T08:37:26Z

+ deps: [], 
+ };
+ createExecutionContext(ctx)
+ const wrappedFetch = (wrappedNodeFetch(mockFetch) as any).bind({ fetch: mockFetch });


And pass actual fetch here. To capture the outputs.

re-Tick · 2023-03-14T08:38:12Z

+ };
+ createExecutionContext(ctx)
+ const wrappedFetch = (wrappedNodeFetch(mockFetch) as any).bind({ fetch: mockFetch });
+ const url = 'http://example.com';


We can use keploy's health API "https://api.keploy.io/healthz" here as url

re-Tick · 2023-03-14T08:39:10Z

+ const deps=updatedctx.deps.length;
+ const responseBody = await response.text();
+ const recordedOutput = updatedctx.mocks[0].Spec.Res.Body;
+ expect(mockFetch).toHaveBeenCalledWith(url, options);


We also dont need to do this since we use actual fetch of node-fetch

Hermione2408 · 2023-03-14T10:13:18Z

@re-Tick I have made the changes and it is passing all the test cases now.

…b action and wrote unit test For code coverage added unit test for wrappedNodeFetch function and integrated git hub actions. test #354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

Revert version and removing console from unit test file test #354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

Added expect test for mocks and deps after fetching in record and test mode test #354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

… output with response Added a check to compare the recorded output with response to ensure wrappedNodeFetch functionality test #354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

importing HTTP from src/keploy.ts test #354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

…reateExecutionContext Resolving the failed test cases by using fetch from node-fetch and createExecutionContext test#354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

updating test cases test #354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

removing createExecutionContext from octokit test #354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

re-Tick · 2023-03-15T07:59:36Z

LGTM. Please add this PR link in GSOC task list.

keploy · 2025-04-15T15:47:36Z

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

keploy-staging · 2025-04-17T08:09:03Z

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Hermione2408 force-pushed the test#354 branch 3 times, most recently from 5cebecf to 7270469Compare March 8, 2023 20:16

re-Tick reviewed Mar 9, 2023
View reviewed changes

Comment threadtest/wrappedNodeFetch.test.ts

re-Tick added Don't Merge Not to be merged until gsoc results Accepted PR is reviewed and Accepted and removed Accepted PR is reviewed and Accepted labels Mar 9, 2023

Hermione2408 force-pushed the test#354 branch from 0aeedc0 to 42347e4Compare March 9, 2023 19:08

re-Tick reviewed Mar 10, 2023
View reviewed changes

Comment threadtest/wrappedNodeFetch.test.ts Outdated

Hermione2408 force-pushed the test#354 branch from e1154e4 to 5210ed5Compare March 10, 2023 07:21

re-Tick reviewed Mar 14, 2023
View reviewed changes

Hermione2408and others added 8 commits March 14, 2023 17:30

feat(github actions and wrappednodefetched.test.js): integrated githu…
3fb754c
…b action and wrote unit test For code coverage added unit test for wrappedNodeFetch function and integrated git hub actions. test #354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

fix: updates the commit linter versio
bd525e2
Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

feat(ci.yml): revert version and removing console
479e05d
Revert version and removing console from unit test file test #354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

feat(wrappednodefetch.test.ts): added expect test for mocks and deps
532413e
Added expect test for mocks and deps after fetching in record and test mode test #354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

feat(wrappednodefetch.test.ts): added a check to compare the recorded…
75ff0cb
… output with response Added a check to compare the recorded output with response to ensure wrappedNodeFetch functionality test #354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

feat(wrappednodefetch.test.ts): importing HTTP from src/keploy.ts
351517f
importing HTTP from src/keploy.ts test #354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

test(wrappednodefetch, octokit/require.ts): adding fetch method and c…
ff354ac
…reateExecutionContext Resolving the failed test cases by using fetch from node-fetch and createExecutionContext test#354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

test(wrappednodefetch): updating checks
b1066bc
updating test cases test #354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

Hermione2408 force-pushed the test#354 branch from ad0b335 to b1066bcCompare March 14, 2023 12:20

Hermione2408and others added 2 commits March 14, 2023 17:51

Merge branch 'main' into test#354
77c3613

feat(require.ts): removing createExecutionContext
4bec4d0
removing createExecutionContext from octokit test #354 Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

developer-diganta added the Accepted PR is reviewed and Accepted label Mar 15, 2023

Uh oh!

Conversation

Hermione2408 commented Mar 8, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

developer-diganta commented Mar 8, 2023

Uh oh!

re-Tick commented Mar 8, 2023

Uh oh!

Hermione2408 commented Mar 8, 2023

Uh oh!

Uh oh!

Uh oh!

Hermione2408 commented Mar 13, 2023

Uh oh!

re-Tick commented Mar 14, 2023

Uh oh!

Hermione2408 commented Mar 14, 2023

Uh oh!

re-TickMar 14, 2023

Choose a reason for hiding this comment

Uh oh!

re-TickMar 14, 2023

Choose a reason for hiding this comment

Uh oh!

re-TickMar 14, 2023

Choose a reason for hiding this comment

Uh oh!

re-TickMar 14, 2023

Choose a reason for hiding this comment

Uh oh!

Hermione2408 commented Mar 14, 2023

Uh oh!

re-Tick commented Mar 15, 2023

Uh oh!

keployBot commented Apr 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keploy-stagingBot commented Apr 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Hermione2408 commented Mar 8, 2023•
edited
Loading

keployBot commented Apr 15, 2025•
edited
Loading