Skip to content

Install the breakglass caller - #235

Merged
ulziibay-kernel merged 1 commit into
mainfrom
hypeship/install-breakglass
Aug 24, 2026
Merged

Install the breakglass caller#235
ulziibay-kernel merged 1 commit into
mainfrom
hypeship/install-breakglass

Conversation

@ulziibay-kernel

@ulziibay-kernelulziibay-kernel commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Nineteen lines, no logic — the whole per-repo install for breakglass.

Comment /breakglass <reason> on a PR here and it merges without its required approval, recording the reason on the PR. The mechanism lives in kernel/security-workflows and is shared, so changes to it need no PR here.

This repo is public, which is why the mechanism is hosted in a public repo — a public repository cannot call a reusable workflow stored in a private one, and the failure is silent (run created, zero jobs, nothing on the PR).

Why a file per repo: issue_comment fires in the repo where the comment is left, and GitHub only runs a workflow if the file is on that repo's default branch. Reusable workflows share logic, not triggers.

Docs: kernel/infra docs/breakglass.md

Depends on kernel/security-workflows#18 landing first. Requires the org-level BREAKGLASS_APP_ID / BREAKGLASS_APP_PRIVATE_KEY secrets shared with this repo, and the kernel-breakglass app installed on it.


Note

Medium Risk
Introduces an approval-bypass merge path tied to org breakglass app credentials; impact is limited by the thin caller and narrowly scoped secrets, but misuse or misconfiguration could merge PRs without normal review gates.

Overview
Adds a minimal Breakglass GitHub Actions workflow so reviewers can comment /breakglass <reason> on a PR to merge without required approvals, with the reason recorded on the PR.

The new .github/workflows/breakglass.yml only wires the trigger: it runs on issue_comment when the comment is on a PR and starts with /breakglass, then calls the shared reusable workflow kernel/security-workflows/.github/workflows/breakglass-merge.yml@main. Workflow-level permissions are empty, and only BREAKGLASS_APP_ID and BREAKGLASS_APP_PRIVATE_KEY are passed (not secrets: inherit) so the external workflow does not receive this repo’s other secrets.

Reviewed by Cursor Bugbot for commit 3f88d13. Bugbot is set up for automated code reviews on this repo. Configure here.

Nineteen lines, no logic. The mechanism is kernel/security-workflows
.github/workflows/breakglass-merge.yml; this only routes a /breakglass comment to
it, so changes to the mechanism need no PR here.
Hosted in a public repo because this one is public, and a public repository
cannot call a reusable workflow stored in a private one.
See kernel/infra docs/breakglass.md.

@sjmiller609sjmiller609 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the shared breakglass caller rollout — looks good.

@ulziibay-kernel
ulziibay-kernel merged commit 513e82e into mainAug 24, 2026
7 checks passed
@ulziibay-kernel
ulziibay-kernel deleted the hypeship/install-breakglass branch August 24, 2026 19:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ulziibay-kernel@sjmiller609