Uh oh!
There was an error while loading. Please reload this page.
Install the breakglass caller - #166
Merged
Merged
Conversation
Nineteen lines, no logic. The mechanism is kernel/security-workflows .github/workflows/breakglass-merge.yml; this only routes a /breakglass comment to it, so changes to the mechanism need no PR here. Hosted in a public repo because this one is public, and a public repository cannot call a reusable workflow stored in a private one. See kernel/infra docs/breakglass.md.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sjmiller609
approved these changes
Aug 24, 2026
sjmiller609
left a comment
Contributor
There was a problem hiding this comment.
reviewed the shared breakglass caller rollout — looks good.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nineteen lines, no logic — the whole per-repo install for breakglass.
Comment
/breakglass <reason>on a PR here and it merges without its required approval, recording the reason on the PR. The mechanism lives in kernel/security-workflows and is shared, so changes to it need no PR here.This repo is public, which is why the mechanism is hosted in a public repo — a public repository cannot call a reusable workflow stored in a private one, and the failure is silent (run created, zero jobs, nothing on the PR).
Why a file per repo:
issue_commentfires in the repo where the comment is left, and GitHub only runs a workflow if the file is on that repo's default branch. Reusable workflows share logic, not triggers.Docs: kernel/infra docs/breakglass.md
Depends on kernel/security-workflows#18 landing first. Requires the org-level
BREAKGLASS_APP_ID/BREAKGLASS_APP_PRIVATE_KEYsecrets shared with this repo, and thekernel-breakglassapp installed on it.Note
Low Risk
Adds CI-only automation with no application code changes; secret scope is intentionally limited to breakglass credentials.
Overview
Adds a minimal GitHub Actions workflow so reviewers can comment
/breakglass <reason>on a PR to merge without required approvals; the reason is recorded on the PR.The workflow listens for
issue_commenton PRs, runs only when the comment starts with/breakglass, and delegates all logic to the shared reusable workflowkernel/security-workflows/.github/workflows/breakglass-merge.yml@main. It passes onlyBREAKGLASS_APP_IDandBREAKGLASS_APP_PRIVATE_KEYexplicitly (notsecrets: inherit) because the callee lives in another repo.This is the standard per-repo install pattern:
issue_commentfires in the repo where the comment is left, and GitHub requires the workflow file on that repo’s default branch.Reviewed by Cursor Bugbot for commit 119a9e7. Bugbot is set up for automated code reviews on this repo. Configure here.