This repository was archived by the owner on Jul 28, 2020. It is now read-only.
WIP Fix: partially matched buffer length should be ignored. - #100
Merged
Merged
Conversation
- "HTTP/1.0 200 Connection Established\r\n" <- this "\r\n" returns: context.SearchState.Matched == 2 "Proxy-agent: Apache/2.2.29 (Win32)\r\n" "\r\n\r\n"
This was referenced Sep 11, 2019
Owner
|
But what about if the "/r/n" is coming in the following buffer? Like first buffer: second buffer |
Contributor
Author
|
@kerryjiang Thanks for reply! |
kerryjiang
approved these changes
Sep 24, 2019
Owner
|
I like the test case, thank you! |
Contributor
Author
Ahh, sorry it is still WIP (under construction) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"HTTP/1.0 200 Connection Established\r\n"← this"\r\n"returns context.SearchState.Matched == 2"Proxy-agent: Apache/2.2.29 (Win32)\r\n""\r\n\r\n"Fix #92