Lots of new WMI goodies - #116
Conversation
- WMI_Next hook added, which functions similar to WMI_Get for async related APIs on the backend (e.g. Get-CimInstance instead of Get-WmiObject - Added initial spoofery for WMI - Couple more hooks (to be officially added by Kevin at some point) - Hopefully fixed weirdness with existing WMI hooks and NOTAIL shenanigans, just converted them to HOOK macros and we now log prior to calling the hook (which is effectively the same as NOTAIL)
Summary of ChangesHello @KillerInstinct, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the system's capabilities for interacting with and manipulating Windows Management Instrumentation (WMI). It introduces a new hook for asynchronous WMI enumeration, implements a comprehensive WMI data spoofing mechanism to alter system information reported via WMI, and refines the existing WMI hooking infrastructure. These enhancements aim to provide more robust control and stealth over WMI interactions, improving the system's ability to present a modified view of the environment. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces significant improvements to WMI hooking, adding a new hook for WMI_Next and initial data spoofing capabilities. The refactoring of existing WMI hooks to call the original functions is a great improvement for correctness and stability. My review focuses on some critical null-pointer safety issues that could cause crashes, and a few suggestions to improve code maintainability.
Port non-exported WMI functions to COM. In order to hook these WMI interfaces, we also need to hook WbemLocator.ConnectServer. If we connect to an interesting namespace, we'll apply the WMI hooks.
PR kevoreilly#116 made SpoofWmiData resolve the object's WMI __CLASS directly, so the g_last_seen_disk_query / g_last_seen_physicalmemory flags PR kevoreilly#161 brought back from the old kevoreilly#97 patch are redundant. Worse, gating the LogicalDisk Size and PhysicalMemory Capacity spoofs on those flags skips spoofing whenever the class isn't reached via a SELECT on the same thread: CreateInstanceEnum (Get-CimInstance / Get-WmiObject -Class), GetObject on an instance, and async results delivered on the WMI sink thread. Remove the flags and restore both ExecQuery hooks to log-before-call. The AdapterRAM (realistic 4GB overflow value) and MaxRefreshRate spoofs from kevoreilly#161 are correct and kept.
Note: This PR is in a draft until @kevoreilly has time to add yara for CreateInstanceEnum/CreateInstanceEnumAsync