Uh oh!
There was an error while loading. Please reload this page.
feat(keycardai-langchain): forward client_id on the as-itself grant - #240
Merged
Conversation
Co-Authored-By: Larry Osakwe <larry@keycard.ai>
ContributorAuthor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Larry-Osakwe
approved these changes
Aug 27, 2026
Larry-Osakwe
left a comment
Contributor
There was a problem hiding this comment.
Both directions of the forwarding are pinned (client_id present in the grant kwargs when the credential prepares one, key absent when it does not), the lift stays inside the assertion branch, and the floor bump guarantees the parameter exists downstream. Nothing to change.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_client_auth_fieldsforwards a preparedclient_idwith jwt-bearer assertion fields into the as-itself client-credentials call.keycardai-oauthdependency floor to0.24.0, the release that acceptsclient_idon that grant.client_id.Open questions: None.
Link to Devin session: https://app.devin.ai/sessions/fb88d151f4014439a2b12a9a90312d5b
Requested by: @Larry-Osakwe