Skip to content

Remove unused task metrics feature - #126

Merged
alexec merged 3 commits into
mainfrom
copilot/remove-unused-task-metrics-feature
Jun 26, 2026
Merged

Remove unused task metrics feature#126
alexec merged 3 commits into
mainfrom
copilot/remove-unused-task-metrics-feature

Conversation

CopilotAI commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

The metrics collection feature (memory usage via ps/procfs) was fully wired up but never consumed by anything meaningful. Removes the entire code path end-to-end.

Removed

  • internal/types/metrics.goMetrics struct
  • internal/metrics/ package — ps and procfs memory parsing helpers
  • GetMetrics(ctx) (*types.Metrics, error) from proc.Interface and all implementations (host, container, k8s, noop), including k8s private helpers (getMetrics, getContainersInPod, getContainerMetrics)
  • 20-second polling goroutine in internal/run.go that called p.GetMetrics and stuffed results onto node.Metrics
  • Metrics field from TaskNode

UI (internal/index.html)

  • Removed #metrics CSS rule, <span id="metrics"> DOM element, formatMetrics() JS function, and all node.metrics data bindings in both the initial graph render and SSE update paths

Docs

  • Removed "real-time metrics" from the Web UI feature description in README.md

CopilotAI changed the title [WIP] Remove unused task metrics feature from the repositoryRemove unused task metrics featureJun 26, 2026
CopilotAI requested a review from alexecJune 26, 2026 00:31
@alexec
alexec requested a review from CopilotJune 26, 2026 00:39
@alexec
alexec marked this pull request as ready for review June 26, 2026 00:39
@alexec

Copy link
Copy Markdown
Collaborator

@copilot fix conflicts.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the previously implemented (but unused) task memory metrics pipeline end-to-end, including backend collection/parsing, propagation through TaskNode, and Web UI rendering, and updates documentation to match.

Changes:

  • Removed types.Metrics, the internal/metrics parsing helpers, and GetMetrics from the proc.Interface plus all implementations.
  • Removed the periodic metrics polling goroutine and eliminated the TaskNode.Metrics field.
  • Removed all metrics-related UI bindings/CSS/formatting and updated README to no longer claim “real-time metrics”.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
README.mdUpdates Web UI feature description to remove “real-time metrics” claim.
internal/types/metrics.goDeletes the Metrics struct type.
internal/task_node.goRemoves TaskNode.Metrics JSON field.
internal/run.goRemoves the 20s polling goroutine that collected/published metrics.
internal/proc/proc.goRemoves GetMetrics from the proc.Interface.
internal/proc/noop.goRemoves the noop metrics implementation and related import.
internal/proc/kubernetes.goRemoves Kubernetes metrics aggregation/helpers and related imports/comments.
internal/proc/host.goRemoves host ps-based metrics collection and related import.
internal/proc/container.goRemoves container procfs metrics collection and related import.
internal/metrics/ps.goDeletes ps parsing helpers.
internal/metrics/procfs.goDeletes procfs parsing helpers.
internal/index.htmlRemoves metrics DOM element, CSS, formatter, and data bindings in initial render + SSE updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CopilotAI commented Jun 26, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot fix conflicts.

Conflicts are fixed in commit 83f61eb. I merged origin/main into this branch and resolved the merge issues while keeping the metrics-removal changes intact.

@alexec
alexec enabled auto-merge (squash) June 26, 2026 19:36
@alexec
alexec merged commit d7857a3 into mainJun 26, 2026
2 checks passed
@alexec
alexec deleted the copilot/remove-unused-task-metrics-feature branch June 26, 2026 19:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexec