Uh oh!
There was an error while loading. Please reload this page.
[KZN-17590] - security validation checks & support views as setup assistants - #18
Merged
Merged
Conversation
keegandonley
requested review from
mauricebecnel400
and
a lite review from CopilotAugust 20, 2026 16:47
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI/viewer to support newer Engine/Packager capabilities (including view-based setup assistants) and tightens report generation and local file scanning, while also updating user-facing command instructions to the npx --yes @kizenapps/cli … invocation style.
Changes:
- Add view-based setup assistant support in the viewer (configuration + sandbox hosting) via shared
PluginViewContent,usePluginConfig, anduseCompleteSetup. - Centralize toast UI into a reusable
ToastProvider/PluginToastand remove legacy toast context implementation. - Improve
reportoutput robustness (markdown fencing) andreadLocalFilesbinary detection; bump@kizenapps/engine/@kizenapps/packagerand project version.
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| viewer/src/ToastContext.tsx | New toast controller/provider with auto-dismiss behavior. |
| viewer/src/ToastContext.ts | Removes legacy toast context API. |
| viewer/src/pages/SummaryPage.tsx | Updates build command hint to npx --yes @kizenapps/cli build. |
| viewer/src/pages/SandboxPage.tsx | Refactors sandbox host to use ToastProvider, usePluginConfig, and useCompleteSetup. |
| viewer/src/pages/ConfigurationPage.tsx | Adds view-based setup assistant rendering and integrates modal/toast/config hooks. |
| viewer/src/pages/CodeStepsPage.tsx | Switches whenState derivation to usePluginConfig. |
| viewer/src/pages/AppDetailPage.tsx | Updates setup-assistant artifact summary to handle view-based assistants. |
| viewer/src/lib/setupAssistant.ts | Adds helpers for detecting/reading view-based setup assistants. |
| viewer/src/lib/constants.ts | Adds shared PLUGIN_IFRAME_ALLOW constant. |
| viewer/src/lib/configStorage.ts | Adds replaceClean* helpers and removes resolveEffectiveConfig. |
| viewer/src/hooks/usePluginConfig.ts | New shared hook for config args, user configs, and whenState. |
| viewer/src/hooks/useCompleteSetup.ts | New host implementation for engine completeSetup that persists config locally. |
| viewer/src/components/RoutablePageBrowser.tsx | Replaces custom view rendering with shared PluginViewContent. |
| viewer/src/components/PluginViewContent.tsx | New shared component/hook to render script/html/iframe plugin views. |
| viewer/src/components/PluginToast.tsx | New toast UI component. |
| viewer/src/components/Modal.tsx | Refactors custom view modal content to reuse PluginViewContent. |
| src/ui/CreateUI.tsx | Updates dev command hint to npx --yes @kizenapps/cli dev. |
| src/lib/readFiles.ts | Expands skipped dirs and adds optional binary detection by content. |
| src/index.ts | Updates CLI display name to the npx @kizenapps/cli form. |
| src/commands/report.ts | Improves markdown fencing, filters license files, enables binary sniffing. |
| src/commands/encrypt.ts | Updates example invocation to npx --yes @kizenapps/cli encrypt …. |
| pnpm-lock.yaml | Locks updated dependency versions (engine/packager) and transitive adds. |
| package.json | Bumps package version and updates engine/packager dependency versions. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+13
to
+17
| export interface ToastPayload { | ||
| message: string; | ||
| variant?: 'success' | 'failure' | 'alert'; | ||
| autohide?: boolean; | ||
| } |
Comment on lines
+23
to
+27
| <div | ||
| className={`fixed top-4 left-1/2 -translate-x-1/2 z-20 rounded px-4 py-2 text-sm font-medium ${ | ||
| VARIANT_CLASSES[toast.variant ?? 'success'] ?? DEFAULT_VARIANT_CLASSES | ||
| }`} | ||
| > |
Comment on lines
+3
to
+6
| export interface PluginToastPayload { | ||
| message: string; | ||
| variant?: string; | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the new security validation checks into the builder, and also adds support for views as setup assistant to the plugin viewer