Uh oh!
There was an error while loading. Please reload this page.
Extract shared run-rendering helpers into cli/_run_render.py - #27
Merged
Conversation
runs.py owned the history/log rendering that automations.py's start --wait and --show-logs also need, so automations.py imported from a sibling command module. Both now import the shared renderers from one place instead. Pure move — no behaviour change. print_step_log loses its leading underscore because it is now called across module boundaries.
annaliu-kizen
approved these changes
Sep 4, 2026
jbedient-kizen
changed the base branch from
chore/consistent-kizen-admin-cli-references
to
mainSeptember 4, 2026 16:31
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
runs.pyowned the execution-history and step-log rendering, andautomations.pyneeded the same rendering forstart --waitand--show-logs. So one command module imported private helpers from a sibling command module — the kind of edge that quietly turns into a duplicated renderer the next time someone touches it.Solution
Move the five shared renderers into
cli/_run_render.pyand have both command modules import from there.Pure move, no behaviour change.
print_step_logloses its leading underscore because it is now called across a module boundary; that rename is the entire semantic delta.Testing
bin/check.sh— all five steps pass:1426 passed, 4 skipped, unchanged from the branch below this one, which is what a pure move should produce.The diffstat balances: 140 lines into the new module against 135 removed from the two command modules, the difference being the module docstring and imports.
Design notes / tradeoffs
No changelog entry — this is an internal refactor with no user-visible effect, per the repo's convention.
Second of six stacked branches; based on the rename so the changelog stays conflict-free down the stack.