Skip to content

fix(client): respect trigger data in bulk feed status updates - #1042

Draft
cjbell wants to merge 1 commit into
mainfrom
cjbell-trigger-data-bulk-status-f45a
Draft

fix(client): respect trigger data in bulk feed status updates#1042
cjbell wants to merge 1 commit into
mainfrom
cjbell-trigger-data-bulk-status-f45a

Conversation

@cjbell

Copy link
Copy Markdown
Contributor

Description

Ensure bulk feed status operations (markAllAsSeen, markAllAsRead, and archive variants) pass the feed's trigger_data filter to the channel bulk status API. Trigger data is serialized consistently with feed fetch requests, preventing status updates from affecting notifications outside the visible filtered feed.

Adds regression coverage for read and seen bulk operations and a patch changeset for @knocklabs/client.

Checklist

  • Tests have been added for the bug fix.

Linear Issue: KNO-14292

Open in WebOpen in Cursor

Co-authored-by: Chris Bell <chris@cjbell.co>
@linear-code

Copy link
Copy Markdown

KNO-14292

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c370c80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@knocklabs/clientPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
javascript-ms-teams-connect-exampleReadyReadyPreview, CommentJul 17, 2026 10:18pm
javascript-nextjs-exampleReadyReadyPreview, CommentJul 17, 2026 10:18pm
javascript-slack-connect-exampleReadyReadyPreview, CommentJul 17, 2026 10:18pm
javascript-slack-kit-exampleReadyReadyPreview, CommentJul 17, 2026 10:18pm

Request Review

@codecov

codecovBot commented Jul 17, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 104 bytes (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle nameSizeChange
@knocklabs/client-client-esm87.04kB44 bytes (0.05%) ⬆️
@knocklabs/client-client-cjs63.43kB60 bytes (0.09%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @knocklabs/client-client-esm

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
clients/feed/feed.mjs44 bytes15.69kB0.28%

Files inclients/feed/feed.mjs:

  • ./src/clients/feed/feed.ts → Total Size: 18.13kB
view changes for bundle: @knocklabs/client-client-cjs

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
clients/feed/feed.js60 bytes10.8kB0.56%

Files inclients/feed/feed.js:

  • ./src/clients/feed/feed.ts → Total Size: 18.28kB

@codecov

codecovBot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.03%. Comparing base (0051b88) to head (c370c80).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #1042 +/- ##
=======================================
Coverage 66.02% 66.03% =======================================
Files 213 213 Lines 10500 10501 +1 Branches 1509 1509 =======================================
+ Hits 6933 6934 +1 
Misses 3542 3542 Partials 25 25 
Files with missing linesCoverage Δ
packages/client/src/clients/feed/feed.ts83.48% <100.00%> (+0.03%)⬆️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@cjbell@cursoragent