Uh oh!
There was an error while loading. Please reload this page.
chore(KNO-14398): migrate example apps to the oxc toolchain - #1048
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Uh oh!
There was an error while loading. Please reload this page.
Move the example apps off ESLint/Prettier onto oxlint/oxfmt, matching the packages. Completes the toolchain migration and orphans the shared config packages. - Un-ignore examples in .oxlintrc.json; disable react-hooks/exhaustive-deps for examples only (never enforced as an error before — the two `eslint --max-warnings 0` examples were already green with these present). - Switch each example's lint/format scripts to oxlint/oxfmt; delete the 7 example ESLint configs and the root .eslintrc.js; remove eslint/prettier/next lint devDependencies. - Set eslint.ignoreDuringBuilds in the 5 Next examples so `next build` (Vercel) no longer lints — oxlint handles it via `yarn lint`. - Fix findings oxlint surfaced: unused vars/imports and a missing `<html lang>`. - Remove the now-dead root prettier config key + @knocklabs/eslint-config / @knocklabs/prettier-config devDeps. Those two published packages now have zero consumers and can be deprecated as a follow-up.
39eecee to
8711c4dCompareBundle ReportBundle size has no change ✅ |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8711c4d. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Addresses BugBot comment by @cursor: `globals` was only used by the deleted ESLint flat config (eslint.config.js) and is now an unused leftover.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## kyle-kno-14398-chore-adopt-the-oxc-toolchain-oxlint-oxfmt-and-typescript-7 #1048 +/- ##
===========================================================================================================
Coverage 66.90% 66.90% ===========================================================================================================
Files 213 213 Lines 10489 10489 Branches 1532 1532 ===========================================================================================================
Hits 7018 7018 Misses 3446 3446 Partials 25 25 |
Description
Stacked on #1047 — review that first; this PR's diff is only the example-app migration.
Moves the example apps off ESLint/Prettier onto the same oxc toolchain (oxlint + oxfmt) the packages now use, completing the repo-wide migration and orphaning the shared config packages.
What changed
examples/**in.oxlintrc.json; each example'slint/format/format:checknow runs oxlint/oxfmt (replacingnext lint,eslint,expo lint, andprettier). Deleted the 7 example ESLint configs and the root.eslintrc.js; removed the eslint/prettier/next-lint devDependencies.next buildno longer lints — the 5 Next examples seteslint.ignoreDuringBuilds: true, since linting now runs viayarn lint(oxlint), notnext build. This keeps the Vercel preview deploys green.<html lang>in slack-kit; fixed.react-hooks/exhaustive-depsis turned off forexamples/**— it was never enforced as an error before (the twoeslint --max-warnings 0examples were already green with these present), so this is parity, and rewriting demo hook deps risks changing behavior I can't exercise.prettierconfig key and the@knocklabs/eslint-config/@knocklabs/prettier-configdevDependencies.Follow-up
@knocklabs/eslint-configand@knocklabs/prettier-confignow have zero consumers in the repo. They can be deprecated / removed as a final step — left in place here since dropping published packages is a separate decision.Verification — all green locally on the stacked tree:
yarn lint(13/13),yarn format:check(12/12),yarn type:check(6/6),yarn build:packages(5/5),yarn test(1007 tests).Todos
@knocklabs/eslint-configand@knocklabs/prettier-config(now unused).Checklist