Fix nvc++ test build error - #149
Merged
Merged
Conversation
Building tests/tests_contiguous_layouts.cpp fails with nvc++ 22.5-0. This commit fixes that. Fixes #148.
crtrott
requested changes
Jun 28, 2022
| // because this results in duplicate test names. | ||
| // However, creating an alias for each suite works around this. | ||
|
|
||
| TYPED_TEST_SUITE(TestLayoutConversion, layout_conversion_test_types_left_to_left); |
Member
There was a problem hiding this comment.
Why not use an alias for this too, so that the testnames show up systematically?
Member
There was a problem hiding this comment.
Mark said nvc++ fails if he uses an alias here too.
Contributor
Author
There was a problem hiding this comment.
Right -- not sure why. I'll experiment a bit once PR #147 lands. Thanks!
nliber
approved these changes
Jun 29, 2022
crtrott
approved these changes
Jun 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building tests/tests_contiguous_layouts.cpp fails with nvc++ 22.5-0. This commit fixes that.
Fixes #148.