Enable testing with SYCL - #234
Conversation
| free_array(errors); | ||
| } | ||
|
|
||
| // host data can't be used in device code |
There was a problem hiding this comment.
What host data does the test use? I'm guessing that the mdarray is defaulting to vector as its container; should we consider changing that to array so that the test can remain enabled, or does the test really depend on using vector?
There was a problem hiding this comment.
Yes, I basically meant std::vector. I pushed a commit using std::array in the test case instead which works with SYCL but I would guess not with Cuda or HIP.
mhoemmen
left a comment
There was a problem hiding this comment.
Thanks for this change!
At some point, after this PR merges : - ) , it would be excellent if we could refactor the testing infrastructure so that it could rely less on duplicated code protected by macros, and rely more on compile-time dispatch.
|
Will conflict with #233 |
|
SYCL testing doesn't seem to work inside the runner. But that wasn't really the intend of the runner anyway. So I think we should just revert the change to the test config thing. |
This hopefully will prevent github from loading the cached mdspan for PR kokkos#234. The cached mdspan has the wrong tag.
Corresponds to #223 but for SYCL.