Fix for mdspan > 0.4.0 - #241
Merged
Merged
Conversation
The recently merged mdspan PR kokkos/mdspan#147 is a breaking change. This commit makes stdblas build with that change. My changes to the kokkos-based tests are best effort only; I haven't tested that build yet.
mhoemmen
force-pushed
the
Fix-after-mdspan-0.4.0
branch
from
July 1, 2022 18:21
6f5e5d7 to
aa8b4be
Compare
Thanks to Yu You for the reproducer. This may fix kokkos#242, though I don't have an MSVC 2022 build set up to reproduce. This change fixes the GCC 9.4.0 build (after adding the reproducer).
Thanks to Yu You for pointing this out!
We were using size_t as the index type. For extents with a signed index type, this could cause a build warning, due to signed-to-unsigned integer conversion.
crtrott
approved these changes
Jul 6, 2022
| void add_rank_2( | ||
| std::experimental::mdspan<ElementType_x, std::experimental::extents<SizeType_x, numRows_x, numCols_x>, Layout_x, Accessor_x> x, | ||
| std::experimental::mdspan<ElementType_y, std::experimental::extents<SizeType_y, numCols_y>, Layout_y, Accessor_y> y, | ||
| std::experimental::mdspan<ElementType_y, std::experimental::extents<SizeType_y, numRows_y, numCols_y>, Layout_y, Accessor_y> y, |
| using sum_type = decltype (B(i,j) - A(0,0) * X(0,0)); | ||
| sum_type t (B(i,j)); | ||
| for (size_type k = j + 1; k < A_num_rows; ++j) { | ||
| for (size_type k = j + 1; k < A_num_rows; ++k) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recently merged mdspan PR kokkos/mdspan#147 is a breaking change. This commit makes stdblas build with that change.
My changes to the kokkos-based tests are best effort only; I haven't tested that build yet.
@youyu3