Do not draw transparent polygons by lvonlanthen · Pull Request #3 · komoot/staticmap

lvonlanthen · 2016-06-27T15:09:43Z

Do not draw polygons on the map if fill_color and outline_color are None.

m=StaticMap(500, 400)
m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12))
bbox_coords= [
[5.96, 47.81],
[5.96, 45.83],
[10.49, 45.83],
[10.49, 47.81],
[5.96, 47.81]]
m.add_polygon(Polygon(bbox_coords, None, None))
image=m.render()
image.save('map.png')

Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

Do not draw polygons on the map if fill_color and outline_color are None. ```python m = StaticMap(500, 400) m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12)) bbox_coords = [ [5.96, 47.81], [5.96, 45.83], [10.49, 45.83], [10.49, 47.81], [5.96, 47.81]] m.add_polygon(Polygon(bbox_coords, None, None)) image = m.render() image.save('map.png') ``` Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

christophlingg · 2016-07-06T13:45:36Z

What's the point of drawing a invisble polygon? But it's still a misbehaviour of the lib, great fix!

lvonlanthen · 2016-07-07T06:31:50Z

I have a use case where I always want to zoom to the entire country of a marker. So basically, I want to have a fixed extent of the map. As there is no function such as StaticMap.set_extent(bbox), I am adding an invisible polygon (the bounding box of the country) so the extent calculated in StaticMap.determine_extent() shows the entire country.
It is probably not the most elegant way, but it works, especially now that the bbox is not showing anymore. Thanks for accepting my change!

christophlingg · 2016-07-08T14:08:00Z

That's a use case I haven't thought of yet, but it's relevant. I will create a corresponding ticket.

lvonlanthen · 2016-06-27T15:09:43Z

Do not draw polygons on the map if fill_color and outline_color are None.

m=StaticMap(500, 400)
m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12))
bbox_coords= [
[5.96, 47.81],
[5.96, 45.83],
[10.49, 45.83],
[10.49, 47.81],
[5.96, 47.81]]
m.add_polygon(Polygon(bbox_coords, None, None))
image=m.render()
image.save('map.png')

Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

Do not draw polygons on the map if fill_color and outline_color are None. ```python m = StaticMap(500, 400) m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12)) bbox_coords = [ [5.96, 47.81], [5.96, 45.83], [10.49, 45.83], [10.49, 47.81], [5.96, 47.81]] m.add_polygon(Polygon(bbox_coords, None, None)) image = m.render() image.save('map.png') ``` Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

christophlingg · 2016-07-06T13:45:36Z

What's the point of drawing a invisble polygon? But it's still a misbehaviour of the lib, great fix!

lvonlanthen · 2016-07-07T06:31:50Z

I have a use case where I always want to zoom to the entire country of a marker. So basically, I want to have a fixed extent of the map. As there is no function such as StaticMap.set_extent(bbox), I am adding an invisible polygon (the bounding box of the country) so the extent calculated in StaticMap.determine_extent() shows the entire country.
It is probably not the most elegant way, but it works, especially now that the bbox is not showing anymore. Thanks for accepting my change!

christophlingg · 2016-07-08T14:08:00Z

That's a use case I haven't thought of yet, but it's relevant. I will create a corresponding ticket.

lvonlanthen · 2016-06-27T15:09:43Z

Do not draw polygons on the map if fill_color and outline_color are None.

m=StaticMap(500, 400)
m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12))
bbox_coords= [
[5.96, 47.81],
[5.96, 45.83],
[10.49, 45.83],
[10.49, 47.81],
[5.96, 47.81]]
m.add_polygon(Polygon(bbox_coords, None, None))
image=m.render()
image.save('map.png')

Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

Do not draw polygons on the map if fill_color and outline_color are None. ```python m = StaticMap(500, 400) m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12)) bbox_coords = [ [5.96, 47.81], [5.96, 45.83], [10.49, 45.83], [10.49, 47.81], [5.96, 47.81]] m.add_polygon(Polygon(bbox_coords, None, None)) image = m.render() image.save('map.png') ``` Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

christophlingg · 2016-07-06T13:45:36Z

What's the point of drawing a invisble polygon? But it's still a misbehaviour of the lib, great fix!

lvonlanthen · 2016-07-07T06:31:50Z

I have a use case where I always want to zoom to the entire country of a marker. So basically, I want to have a fixed extent of the map. As there is no function such as StaticMap.set_extent(bbox), I am adding an invisible polygon (the bounding box of the country) so the extent calculated in StaticMap.determine_extent() shows the entire country.
It is probably not the most elegant way, but it works, especially now that the bbox is not showing anymore. Thanks for accepting my change!

christophlingg · 2016-07-08T14:08:00Z

That's a use case I haven't thought of yet, but it's relevant. I will create a corresponding ticket.

lvonlanthen · 2016-06-27T15:09:43Z

Do not draw polygons on the map if fill_color and outline_color are None.

m=StaticMap(500, 400)
m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12))
bbox_coords= [
[5.96, 47.81],
[5.96, 45.83],
[10.49, 45.83],
[10.49, 47.81],
[5.96, 47.81]]
m.add_polygon(Polygon(bbox_coords, None, None))
image=m.render()
image.save('map.png')

Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

Do not draw polygons on the map if fill_color and outline_color are None. ```python m = StaticMap(500, 400) m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12)) bbox_coords = [ [5.96, 47.81], [5.96, 45.83], [10.49, 45.83], [10.49, 47.81], [5.96, 47.81]] m.add_polygon(Polygon(bbox_coords, None, None)) image = m.render() image.save('map.png') ``` Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

christophlingg · 2016-07-06T13:45:36Z

What's the point of drawing a invisble polygon? But it's still a misbehaviour of the lib, great fix!

lvonlanthen · 2016-07-07T06:31:50Z

I have a use case where I always want to zoom to the entire country of a marker. So basically, I want to have a fixed extent of the map. As there is no function such as StaticMap.set_extent(bbox), I am adding an invisible polygon (the bounding box of the country) so the extent calculated in StaticMap.determine_extent() shows the entire country.
It is probably not the most elegant way, but it works, especially now that the bbox is not showing anymore. Thanks for accepting my change!

christophlingg · 2016-07-08T14:08:00Z

That's a use case I haven't thought of yet, but it's relevant. I will create a corresponding ticket.

lvonlanthen · 2016-06-27T15:09:43Z

Do not draw polygons on the map if fill_color and outline_color are None.

m=StaticMap(500, 400)
m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12))
bbox_coords= [
[5.96, 47.81],
[5.96, 45.83],
[10.49, 45.83],
[10.49, 47.81],
[5.96, 47.81]]
m.add_polygon(Polygon(bbox_coords, None, None))
image=m.render()
image.save('map.png')

Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

Do not draw polygons on the map if fill_color and outline_color are None. ```python m = StaticMap(500, 400) m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12)) bbox_coords = [ [5.96, 47.81], [5.96, 45.83], [10.49, 45.83], [10.49, 47.81], [5.96, 47.81]] m.add_polygon(Polygon(bbox_coords, None, None)) image = m.render() image.save('map.png') ``` Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

christophlingg · 2016-07-06T13:45:36Z

What's the point of drawing a invisble polygon? But it's still a misbehaviour of the lib, great fix!

lvonlanthen · 2016-07-07T06:31:50Z

I have a use case where I always want to zoom to the entire country of a marker. So basically, I want to have a fixed extent of the map. As there is no function such as StaticMap.set_extent(bbox), I am adding an invisible polygon (the bounding box of the country) so the extent calculated in StaticMap.determine_extent() shows the entire country.
It is probably not the most elegant way, but it works, especially now that the bbox is not showing anymore. Thanks for accepting my change!

christophlingg · 2016-07-08T14:08:00Z

That's a use case I haven't thought of yet, but it's relevant. I will create a corresponding ticket.

lvonlanthen · 2016-06-27T15:09:43Z

Do not draw polygons on the map if fill_color and outline_color are None.

m=StaticMap(500, 400)
m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12))
bbox_coords= [
[5.96, 47.81],
[5.96, 45.83],
[10.49, 45.83],
[10.49, 47.81],
[5.96, 47.81]]
m.add_polygon(Polygon(bbox_coords, None, None))
image=m.render()
image.save('map.png')

Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

Do not draw polygons on the map if fill_color and outline_color are None. ```python m = StaticMap(500, 400) m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12)) bbox_coords = [ [5.96, 47.81], [5.96, 45.83], [10.49, 45.83], [10.49, 47.81], [5.96, 47.81]] m.add_polygon(Polygon(bbox_coords, None, None)) image = m.render() image.save('map.png') ``` Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

christophlingg · 2016-07-06T13:45:36Z

What's the point of drawing a invisble polygon? But it's still a misbehaviour of the lib, great fix!

lvonlanthen · 2016-07-07T06:31:50Z

I have a use case where I always want to zoom to the entire country of a marker. So basically, I want to have a fixed extent of the map. As there is no function such as StaticMap.set_extent(bbox), I am adding an invisible polygon (the bounding box of the country) so the extent calculated in StaticMap.determine_extent() shows the entire country.
It is probably not the most elegant way, but it works, especially now that the bbox is not showing anymore. Thanks for accepting my change!

christophlingg · 2016-07-08T14:08:00Z

That's a use case I haven't thought of yet, but it's relevant. I will create a corresponding ticket.

lvonlanthen · 2016-06-27T15:09:43Z

Do not draw polygons on the map if fill_color and outline_color are None.

m=StaticMap(500, 400)
m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12))
bbox_coords= [
[5.96, 47.81],
[5.96, 45.83],
[10.49, 45.83],
[10.49, 47.81],
[5.96, 47.81]]
m.add_polygon(Polygon(bbox_coords, None, None))
image=m.render()
image.save('map.png')

Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

Do not draw polygons on the map if fill_color and outline_color are None. ```python m = StaticMap(500, 400) m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12)) bbox_coords = [ [5.96, 47.81], [5.96, 45.83], [10.49, 45.83], [10.49, 47.81], [5.96, 47.81]] m.add_polygon(Polygon(bbox_coords, None, None)) image = m.render() image.save('map.png') ``` Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

christophlingg · 2016-07-06T13:45:36Z

What's the point of drawing a invisble polygon? But it's still a misbehaviour of the lib, great fix!

lvonlanthen · 2016-07-07T06:31:50Z

I have a use case where I always want to zoom to the entire country of a marker. So basically, I want to have a fixed extent of the map. As there is no function such as StaticMap.set_extent(bbox), I am adding an invisible polygon (the bounding box of the country) so the extent calculated in StaticMap.determine_extent() shows the entire country.
It is probably not the most elegant way, but it works, especially now that the bbox is not showing anymore. Thanks for accepting my change!

christophlingg · 2016-07-08T14:08:00Z

That's a use case I haven't thought of yet, but it's relevant. I will create a corresponding ticket.

lvonlanthen · 2016-06-27T15:09:43Z

Do not draw polygons on the map if fill_color and outline_color are None.

m=StaticMap(500, 400)
m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12))
bbox_coords= [
[5.96, 47.81],
[5.96, 45.83],
[10.49, 45.83],
[10.49, 47.81],
[5.96, 47.81]]
m.add_polygon(Polygon(bbox_coords, None, None))
image=m.render()
image.save('map.png')

Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

Do not draw polygons on the map if fill_color and outline_color are None. ```python m = StaticMap(500, 400) m.add_marker(CircleMarker((7.15, 46.80), '#0036FF', 12)) bbox_coords = [ [5.96, 47.81], [5.96, 45.83], [10.49, 45.83], [10.49, 47.81], [5.96, 47.81]] m.add_polygon(Polygon(bbox_coords, None, None)) image = m.render() image.save('map.png') ``` Creates a thin polygon even though fill_color = None and outline_color = None. See https://imgur.com/yr3nQSX

christophlingg · 2016-07-06T13:45:36Z

What's the point of drawing a invisble polygon? But it's still a misbehaviour of the lib, great fix!

lvonlanthen · 2016-07-07T06:31:50Z

I have a use case where I always want to zoom to the entire country of a marker. So basically, I want to have a fixed extent of the map. As there is no function such as StaticMap.set_extent(bbox), I am adding an invisible polygon (the bounding box of the country) so the extent calculated in StaticMap.determine_extent() shows the entire country.
It is probably not the most elegant way, but it works, especially now that the bbox is not showing anymore. Thanks for accepting my change!

christophlingg · 2016-07-08T14:08:00Z

That's a use case I haven't thought of yet, but it's relevant. I will create a corresponding ticket.

christophlingg merged commit bba7e5c into komoot:masterJul 6, 2016

christophlingg mentioned this pull request Jul 8, 2016
Explicit Map Extent #4
Open