Skip to content

Misc. Fixes for lastpass-python - #36

Open
guilt wants to merge 3 commits into
konomae:masterfrom
guilt:master
Open

Misc. Fixes for lastpass-python#36
guilt wants to merge 3 commits into
konomae:masterfrom
guilt:master

Conversation

@guilt

@guiltguilt commented Aug 20, 2019

Copy link
Copy Markdown

Hi,

This pull request has some changes in it, including some SecureNote parsing code that was borrowed and improved. Update: Moved the lpass CLI to a separate repo (https://github.com/guilt/lastpass-python-cli)

It's to help someone who was looking for how to get some of the notes data in Python. Please adapt this to your convenience.

Thanks to all the authors who had written some of the original code I took this off.

@codecov

codecovBot commented Aug 20, 2019

Copy link
Copy Markdown

Codecov Report

Attention: 105 lines in your changes are missing coverage. Please review.

Comparison is base (41af73a) 72.72% compared to head (9a31f9d) 59.79%.

❗ Current head 9a31f9d differs from pull request most recent head 5b683b3. Consider uploading reports for the commit 5b683b3 to get more accurate results

FilesPatch %Lines
lastpass/parser.py42.35%49 Missing ⚠️
lastpass/vault.py27.50%29 Missing ⚠️
lastpass/account.py37.50%15 Missing ⚠️
lastpass/fetcher.py82.35%12 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #36 +/- ##
===========================================
- Coverage 72.72% 59.79% -12.93% 
===========================================
Files 10 9 -1 Lines 385 592 +207 ===========================================
+ Hits 280 354 +74 - Misses 105 238 +133 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guilt
guiltforce-pushed the master branch 2 times, most recently from 70706a5 to 6d75a9eCompareAugust 22, 2019 04:11
@combro2k

Copy link
Copy Markdown

Would love to see these changes, I am trying to replace lastpass cli's implementation.
And use this library for a gtk application :-) so would love the possibility to have the same kind of settings to store the database locally and reauth when a specific time is elapsed :-)
These changes allow me to create such thing :-)

…ss-python.
Import SecureNote parsing code, with changes from nadavshalev/lastpass-python.
Pylint pass and uncrustify code.
Fix pycodestyle issues.
@guiltguilt changed the title Misc. Fixes for lastpass-python + lpass UtilityMisc. Fixes for lastpass-pythonJul 29, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@guilt@combro2k