You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mbevc1
added
customer-request
For issues reported/inspired by customers - solution reported via community slack and to customer
go
Pull requests that update go code
labels
Jul 31, 2026
This is a clean, low-risk change. It adds pull_request / merge_request aliases (snake_case, matching the attestation-record type naming) to both the attest pullrequest and assert pullrequest parent commands, and renames assertPullrequest.go → assertPR.go to match the attestPR.go file-name pattern. 👍
What I verified
✅ go build ./... and go vet ./cmd/kosli/ pass.
✅ Both alias lists are now identical (pr, pull_request, mr, mergerequest, merge_request) — before this PR they differed in order/content, so this is a nice consistency win.
✅ The new pull_request alias lines up with the existing type naming used elsewhere (root.go:279 help text lists pull_request as an attestation type; pullrequest.go:31 posts to the .../pull_request endpoint).
✅ No autogenerated docs under cmd/kosli/testdata/output/docs/ reference these aliases, so nothing needs regenerating there. Worth a quick make docs (or your doc-gen target) locally just to confirm the published help/docs pick up the new aliases, per the PR checklist.
Minor observations (non-blocking)
No test asserts the alias set, so a typo or accidental removal wouldn't be caught. Optional, but a tiny table test (e.g. assert newAttestPRCmd/newAssertPRCmd contains each expected alias) would lock this in cheaply. Given how trivial the change is, this is genuinely optional.
Cobra treats aliases as an unordered lookup, so ordering is purely cosmetic — no functional concern. Grouping them logically (pr, pull_request then mr, mergerequest, merge_request) reads well.
Nit: consider mirroring this snake_case alias addition on any related PR subcommands if customers expect it consistently — but the parent-command aliases resolve regardless of subcommand, so this is fine as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
customer-requestFor issues reported/inspired by customers - solution reported via community slack and to customergoPull requests that update go code
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
charts/k8s-reporter/) updated, if needed. Note: these changes live in a separate PR