feat: improve version checking

[mbevc1]

• properly handle sync version checking when using --version
• don't check latest version when using JSON output (avoid polluting outputs in GHA pipelines)
• add testing for JSON output scenario
• lower the async timeout to 1 sec (prevent long waits on slower connections)
• local builds use dev as version
• disable version check in debug mode

[claude]

Claude finished @mbevc1's task in 2m 27s —— View job

---

PR Review: feat: improve version checking

• Run static analysis (build, vet, mod tidy)
• Read changed files
• Review code quality and correctness
• Post inline comments and summary

Static Analysis

All checks pass: go build ./..., go vet ./..., go mod tidy — no issues.

Summary

This is a solid, well-structured PR. The changes address real pain points (JSON output pollution in CI, version check on --version, debug mode suppression) and the iteration through review feedback has been productive. Key observations:

What's good:

• sync.RWMutex-protected override with single-read pattern in CheckForUpdate — cleanly addresses the double-read race. The race stress test locks this in.
• strconv.ParseBool for KOSLI_DEBUG in innerMain — correctly matches Viper's bool coercion, handling false/0/TRUE properly.
• Skipping version check for non-table output — practical improvement for CI pipelines, and forward-compatible with future output formats.
• Test coverage for --version notice path via innerMain with called bool verification — closes the executeCommandC bypass gap.
• KOSLI_NO_UPDATE_CHECK=1 in the race test — prevents real HTTP calls when the override is momentarily nil.

Minor nits (non-blocking):

• The --version block in innerMain (lines 52-65) is deeply nested (3 levels). Could be flattened with an early return after determining debugEnabled. Style preference only — see inline comment.

No bugs, no security issues, no missing edge cases. The previous review rounds have been thorough and the feedback has been addressed well. LGTM.

[mbevc1]

Goroutine-safety nit on SetCheckForUpdateOverride — inline with a sync.RWMutex suggestion and a race test. Current call site is fine by happens-before; the mutex is cheap insurance against future callers / flaky timings.

---

Generated by Claude Code

[mbevc1]

Coverage gap: executeCommandC bypasses innerMain, so the new --version sync-notice branch in main.go has no test coverage. Inline with a sketch calling innerMain directly via the existing SetCheckForUpdateOverride helper.

---

Generated by Claude Code