Fix AMD module loading - #45
Merged
Merged
Conversation
kpdecker
commented
Jan 26, 2015
Owner
Released in 1.2.2 |
pedrocarrico
commented
Jan 27, 2015
ContributorAuthor
Thanks for the fast release! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am using AMD with an ember-cli app and it seems that JsDiff doesn't get loaded as a module unless you do a
define.amdwhen you test for thedefinefunction.I really don't know if this is correct pattern to do this but I've seen this behaviour in some other libraries and know it's loading correctly.
Cheers,