Debug

[krassowski]

No description provided.

[Copilot]

Pull Request Overview

This PR enhances the notebook export functionality and test coverage for capturing various output types, while also updating dependency management and refining output history and display handling.

• Updated notebook export logic to capture errors, display outputs, and streams.
• Introduced a new test (test_notebook_export_json_with_output) to verify proper output capture.
• Added new dependencies and refined history, display, and tee functionality.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/test_magic.py	Added new test for notebook export with output capture and removed extra blank lines.
pyproject.toml	Added nbclient and ipykernel dependencies to support new notebook export tests.
IPython/core/magics/basic.py	Updated export logic to iterate over outputs and append error outputs if present.
IPython/core/interactiveshell.py	Refactored exception formatting and introduced capturing tee for stdout/stderr.
IPython/core/history.py	Added HistoryOutput dataclass and updated reset to clear outputs and exceptions.
IPython/core/displaypub.py	Modified publish logic to record HistoryOutput and maintain publishing state.
IPython/core/displayhook.py	Added active flag to manage display hook state.
IPython/core/display_trap.py	Added a property to check if the display trap is active.

[Copilot]

[nitpick] This print statement appears to be a leftover debugging statement. Consider removing it to keep test output clean.

Suggested change

print(f"\n{_ip.history_manager.outputs}\n")

[Copilot]

[nitpick] Relying on a fixed sleep duration can lead to flaky tests. Consider replacing it with a dynamic wait or polling mechanism to ensure reliable synchronization.

Suggested change

	sleep(2)
	timeout=10
	interval=0.1
	elapsed=0
	whileelapsed<timeout:
	ifos.path.exists(outfile) andos.access(outfile, os.R_OK):
	break
	sleep(interval)
	elapsed+=interval

[krassowski]

Commenting out CapturingTee part makes the test (macos-13, 3.13) pass.

[Copilot]

Pull Request Overview

This PR, titled "Debug", updates tests and core IPython modules to improve notebook export functionality and error handling.

• Added a new test (test_notebook_export_json_with_output) to verify that notebook export captures outputs, errors, and display outputs correctly.
• Updated dependency declarations in pyproject.toml to include nbclient and ipykernel.
• Enhanced IPython internals including history outputs, display publishing/trapping, and traceback capture mechanisms.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/test_magic.py	Added a new test for notebook export and modified test structure
pyproject.toml	Updated test dependencies
IPython/core/magics/basic.py	Updated notebook magic to include output and exception handling
IPython/core/interactiveshell.py	Introduced a _tee context manager and adjusted exception formatting
IPython/core/history.py	Introduced a HistoryOutput dataclass; cleared history outputs on reset
IPython/core/displaypub.py	Added publishing state tracking and output logging adjustments
IPython/core/displayhook.py	Added an active state for displayhook and adjusted output logging
IPython/core/display_trap.py	Added an is_active property for display trap

Comments suppressed due to low confidence (1)

IPython/core/interactiveshell.py:3049

• Ensure that 'data' is always a string to prevent potential type concatenation issues; consider casting 'data' to str if necessary.

output_stream.bundle["stream"] += data

[Copilot]

[nitpick] Consider removing the debug print statement to avoid cluttering the test output in production.

Suggested change

print(f"\n{_ip.history_manager.outputs}\n")