Skip to content

Merge auto-aim based on limelight - #6

Merged
vladuzzul merged 5 commits into
mainfrom
Cosmin
Aug 3, 2026
Merged

Merge auto-aim based on limelight#6
vladuzzul merged 5 commits into
mainfrom
Cosmin

Conversation

@vladuzzul

Copy link
Copy Markdown
Member

Before issuing a pull request, please see the contributing page.

CopilotAI review requested due to automatic review settings August 3, 2026 10:46
@coderabbitai

coderabbitaiBot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@vladuzzul, you've reached your PR review limit, so we couldn't start this review.

Next review available in:57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbc5a854-6667-4896-a4db-5a1afa46d787

📥 Commits

Reviewing files that changed from the base of the PR and between e4558d1 and afa081b.

📒 Files selected for processing (3)
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vladuzzul
vladuzzul merged commit 49a733d into mainAug 3, 2026
1 check passed

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates a Limelight vision pipeline into the KronBot runtime and uses Limelight tx to augment turret auto-aim, with fallback to odometry when no target is available.

Changes:

  • Add Limelight tuning constants (LIMELIGHT_TURRET_KP, LIMELIGHT_TX_DEADBAND).
  • Introduce a Robot.Limelight subsystem (init/update/telemetry/stop) and call it from the main loop.
  • Update turret auto-aim to use Limelight correction when a fresh target is present, with additional driver-facing telemetry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.javaAdds Limelight control constants for turret correction/deadband.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.javaAdds Limelight subsystem and merges Limelight-based correction into turret auto-aim logic.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.javaInitializes/stops Limelight and exposes Limelight telemetry during teleop.
Suppressed comments (1)

TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java:66

  • Unused imports (LLStatus, ElapsedTime) add clutter and can trigger lint/build warnings. Remove them if not needed.
import com.qualcomm.hardware.limelightvision.LLStatus;
import com.qualcomm.hardware.limelightvision.Limelight3A;
import com.qualcomm.robotcore.util.ElapsedTime;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +13 to +14
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.hardwareMap;
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.telemetry;
aimSource = "Limelight";
limelightTx = limelightResult.getTx();
if (Math.abs(limelightTx) > LIMELIGHT_TX_DEADBAND) {
limelightCorrection = Math.toRadians(limelightTx) * LIMELflaIGHT_TURRET_KP;
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vladuzzul@sch1afend
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Merge auto-aim based on limelight by vladuzzul · Pull Request #6 · kronbot/decode · GitHub
Skip to content

Merge auto-aim based on limelight - #6

Merged
vladuzzul merged 5 commits into
mainfrom
Cosmin
Aug 3, 2026
Merged

Merge auto-aim based on limelight#6
vladuzzul merged 5 commits into
mainfrom
Cosmin

Conversation

@vladuzzul

Copy link
Copy Markdown
Member

Before issuing a pull request, please see the contributing page.

CopilotAI review requested due to automatic review settings August 3, 2026 10:46
@coderabbitai

coderabbitaiBot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@vladuzzul, you've reached your PR review limit, so we couldn't start this review.

Next review available in:57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbc5a854-6667-4896-a4db-5a1afa46d787

📥 Commits

Reviewing files that changed from the base of the PR and between e4558d1 and afa081b.

📒 Files selected for processing (3)
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vladuzzul
vladuzzul merged commit 49a733d into mainAug 3, 2026
1 check passed

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates a Limelight vision pipeline into the KronBot runtime and uses Limelight tx to augment turret auto-aim, with fallback to odometry when no target is available.

Changes:

  • Add Limelight tuning constants (LIMELIGHT_TURRET_KP, LIMELIGHT_TX_DEADBAND).
  • Introduce a Robot.Limelight subsystem (init/update/telemetry/stop) and call it from the main loop.
  • Update turret auto-aim to use Limelight correction when a fresh target is present, with additional driver-facing telemetry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.javaAdds Limelight control constants for turret correction/deadband.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.javaAdds Limelight subsystem and merges Limelight-based correction into turret auto-aim logic.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.javaInitializes/stops Limelight and exposes Limelight telemetry during teleop.
Suppressed comments (1)

TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java:66

  • Unused imports (LLStatus, ElapsedTime) add clutter and can trigger lint/build warnings. Remove them if not needed.
import com.qualcomm.hardware.limelightvision.LLStatus;
import com.qualcomm.hardware.limelightvision.Limelight3A;
import com.qualcomm.robotcore.util.ElapsedTime;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +13 to +14
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.hardwareMap;
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.telemetry;
aimSource = "Limelight";
limelightTx = limelightResult.getTx();
if (Math.abs(limelightTx) > LIMELIGHT_TX_DEADBAND) {
limelightCorrection = Math.toRadians(limelightTx) * LIMELflaIGHT_TURRET_KP;
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vladuzzul@sch1afend
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Merge auto-aim based on limelight by vladuzzul · Pull Request #6 · kronbot/decode · GitHub
Skip to content

Merge auto-aim based on limelight - #6

Merged
vladuzzul merged 5 commits into
mainfrom
Cosmin
Aug 3, 2026
Merged

Merge auto-aim based on limelight#6
vladuzzul merged 5 commits into
mainfrom
Cosmin

Conversation

@vladuzzul

Copy link
Copy Markdown
Member

Before issuing a pull request, please see the contributing page.

CopilotAI review requested due to automatic review settings August 3, 2026 10:46
@coderabbitai

coderabbitaiBot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@vladuzzul, you've reached your PR review limit, so we couldn't start this review.

Next review available in:57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbc5a854-6667-4896-a4db-5a1afa46d787

📥 Commits

Reviewing files that changed from the base of the PR and between e4558d1 and afa081b.

📒 Files selected for processing (3)
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vladuzzul
vladuzzul merged commit 49a733d into mainAug 3, 2026
1 check passed

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates a Limelight vision pipeline into the KronBot runtime and uses Limelight tx to augment turret auto-aim, with fallback to odometry when no target is available.

Changes:

  • Add Limelight tuning constants (LIMELIGHT_TURRET_KP, LIMELIGHT_TX_DEADBAND).
  • Introduce a Robot.Limelight subsystem (init/update/telemetry/stop) and call it from the main loop.
  • Update turret auto-aim to use Limelight correction when a fresh target is present, with additional driver-facing telemetry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.javaAdds Limelight control constants for turret correction/deadband.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.javaAdds Limelight subsystem and merges Limelight-based correction into turret auto-aim logic.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.javaInitializes/stops Limelight and exposes Limelight telemetry during teleop.
Suppressed comments (1)

TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java:66

  • Unused imports (LLStatus, ElapsedTime) add clutter and can trigger lint/build warnings. Remove them if not needed.
import com.qualcomm.hardware.limelightvision.LLStatus;
import com.qualcomm.hardware.limelightvision.Limelight3A;
import com.qualcomm.robotcore.util.ElapsedTime;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +13 to +14
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.hardwareMap;
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.telemetry;
aimSource = "Limelight";
limelightTx = limelightResult.getTx();
if (Math.abs(limelightTx) > LIMELIGHT_TX_DEADBAND) {
limelightCorrection = Math.toRadians(limelightTx) * LIMELflaIGHT_TURRET_KP;
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vladuzzul@sch1afend
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Merge auto-aim based on limelight by vladuzzul · Pull Request #6 · kronbot/decode · GitHub
Skip to content

Merge auto-aim based on limelight - #6

Merged
vladuzzul merged 5 commits into
mainfrom
Cosmin
Aug 3, 2026
Merged

Merge auto-aim based on limelight#6
vladuzzul merged 5 commits into
mainfrom
Cosmin

Conversation

@vladuzzul

Copy link
Copy Markdown
Member

Before issuing a pull request, please see the contributing page.

CopilotAI review requested due to automatic review settings August 3, 2026 10:46
@coderabbitai

coderabbitaiBot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@vladuzzul, you've reached your PR review limit, so we couldn't start this review.

Next review available in:57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbc5a854-6667-4896-a4db-5a1afa46d787

📥 Commits

Reviewing files that changed from the base of the PR and between e4558d1 and afa081b.

📒 Files selected for processing (3)
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vladuzzul
vladuzzul merged commit 49a733d into mainAug 3, 2026
1 check passed

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates a Limelight vision pipeline into the KronBot runtime and uses Limelight tx to augment turret auto-aim, with fallback to odometry when no target is available.

Changes:

  • Add Limelight tuning constants (LIMELIGHT_TURRET_KP, LIMELIGHT_TX_DEADBAND).
  • Introduce a Robot.Limelight subsystem (init/update/telemetry/stop) and call it from the main loop.
  • Update turret auto-aim to use Limelight correction when a fresh target is present, with additional driver-facing telemetry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.javaAdds Limelight control constants for turret correction/deadband.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.javaAdds Limelight subsystem and merges Limelight-based correction into turret auto-aim logic.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.javaInitializes/stops Limelight and exposes Limelight telemetry during teleop.
Suppressed comments (1)

TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java:66

  • Unused imports (LLStatus, ElapsedTime) add clutter and can trigger lint/build warnings. Remove them if not needed.
import com.qualcomm.hardware.limelightvision.LLStatus;
import com.qualcomm.hardware.limelightvision.Limelight3A;
import com.qualcomm.robotcore.util.ElapsedTime;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +13 to +14
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.hardwareMap;
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.telemetry;
aimSource = "Limelight";
limelightTx = limelightResult.getTx();
if (Math.abs(limelightTx) > LIMELIGHT_TX_DEADBAND) {
limelightCorrection = Math.toRadians(limelightTx) * LIMELflaIGHT_TURRET_KP;
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vladuzzul@sch1afend
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Merge auto-aim based on limelight by vladuzzul · Pull Request #6 · kronbot/decode · GitHub
Skip to content

Merge auto-aim based on limelight - #6

Merged
vladuzzul merged 5 commits into
mainfrom
Cosmin
Aug 3, 2026
Merged

Merge auto-aim based on limelight#6
vladuzzul merged 5 commits into
mainfrom
Cosmin

Conversation

@vladuzzul

Copy link
Copy Markdown
Member

Before issuing a pull request, please see the contributing page.

CopilotAI review requested due to automatic review settings August 3, 2026 10:46
@coderabbitai

coderabbitaiBot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@vladuzzul, you've reached your PR review limit, so we couldn't start this review.

Next review available in:57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbc5a854-6667-4896-a4db-5a1afa46d787

📥 Commits

Reviewing files that changed from the base of the PR and between e4558d1 and afa081b.

📒 Files selected for processing (3)
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vladuzzul
vladuzzul merged commit 49a733d into mainAug 3, 2026
1 check passed

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates a Limelight vision pipeline into the KronBot runtime and uses Limelight tx to augment turret auto-aim, with fallback to odometry when no target is available.

Changes:

  • Add Limelight tuning constants (LIMELIGHT_TURRET_KP, LIMELIGHT_TX_DEADBAND).
  • Introduce a Robot.Limelight subsystem (init/update/telemetry/stop) and call it from the main loop.
  • Update turret auto-aim to use Limelight correction when a fresh target is present, with additional driver-facing telemetry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.javaAdds Limelight control constants for turret correction/deadband.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.javaAdds Limelight subsystem and merges Limelight-based correction into turret auto-aim logic.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.javaInitializes/stops Limelight and exposes Limelight telemetry during teleop.
Suppressed comments (1)

TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java:66

  • Unused imports (LLStatus, ElapsedTime) add clutter and can trigger lint/build warnings. Remove them if not needed.
import com.qualcomm.hardware.limelightvision.LLStatus;
import com.qualcomm.hardware.limelightvision.Limelight3A;
import com.qualcomm.robotcore.util.ElapsedTime;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +13 to +14
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.hardwareMap;
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.telemetry;
aimSource = "Limelight";
limelightTx = limelightResult.getTx();
if (Math.abs(limelightTx) > LIMELIGHT_TX_DEADBAND) {
limelightCorrection = Math.toRadians(limelightTx) * LIMELflaIGHT_TURRET_KP;
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vladuzzul@sch1afend
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Merge auto-aim based on limelight by vladuzzul · Pull Request #6 · kronbot/decode · GitHub
Skip to content

Merge auto-aim based on limelight - #6

Merged
vladuzzul merged 5 commits into
mainfrom
Cosmin
Aug 3, 2026
Merged

Merge auto-aim based on limelight#6
vladuzzul merged 5 commits into
mainfrom
Cosmin

Conversation

@vladuzzul

Copy link
Copy Markdown
Member

Before issuing a pull request, please see the contributing page.

CopilotAI review requested due to automatic review settings August 3, 2026 10:46
@coderabbitai

coderabbitaiBot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@vladuzzul, you've reached your PR review limit, so we couldn't start this review.

Next review available in:57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbc5a854-6667-4896-a4db-5a1afa46d787

📥 Commits

Reviewing files that changed from the base of the PR and between e4558d1 and afa081b.

📒 Files selected for processing (3)
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vladuzzul
vladuzzul merged commit 49a733d into mainAug 3, 2026
1 check passed

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates a Limelight vision pipeline into the KronBot runtime and uses Limelight tx to augment turret auto-aim, with fallback to odometry when no target is available.

Changes:

  • Add Limelight tuning constants (LIMELIGHT_TURRET_KP, LIMELIGHT_TX_DEADBAND).
  • Introduce a Robot.Limelight subsystem (init/update/telemetry/stop) and call it from the main loop.
  • Update turret auto-aim to use Limelight correction when a fresh target is present, with additional driver-facing telemetry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.javaAdds Limelight control constants for turret correction/deadband.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.javaAdds Limelight subsystem and merges Limelight-based correction into turret auto-aim logic.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.javaInitializes/stops Limelight and exposes Limelight telemetry during teleop.
Suppressed comments (1)

TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java:66

  • Unused imports (LLStatus, ElapsedTime) add clutter and can trigger lint/build warnings. Remove them if not needed.
import com.qualcomm.hardware.limelightvision.LLStatus;
import com.qualcomm.hardware.limelightvision.Limelight3A;
import com.qualcomm.robotcore.util.ElapsedTime;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +13 to +14
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.hardwareMap;
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.telemetry;
aimSource = "Limelight";
limelightTx = limelightResult.getTx();
if (Math.abs(limelightTx) > LIMELIGHT_TX_DEADBAND) {
limelightCorrection = Math.toRadians(limelightTx) * LIMELflaIGHT_TURRET_KP;
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vladuzzul@sch1afend
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Merge auto-aim based on limelight by vladuzzul · Pull Request #6 · kronbot/decode · GitHub
Skip to content

Merge auto-aim based on limelight - #6

Merged
vladuzzul merged 5 commits into
mainfrom
Cosmin
Aug 3, 2026
Merged

Merge auto-aim based on limelight#6
vladuzzul merged 5 commits into
mainfrom
Cosmin

Conversation

@vladuzzul

Copy link
Copy Markdown
Member

Before issuing a pull request, please see the contributing page.

CopilotAI review requested due to automatic review settings August 3, 2026 10:46
@coderabbitai

coderabbitaiBot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@vladuzzul, you've reached your PR review limit, so we couldn't start this review.

Next review available in:57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbc5a854-6667-4896-a4db-5a1afa46d787

📥 Commits

Reviewing files that changed from the base of the PR and between e4558d1 and afa081b.

📒 Files selected for processing (3)
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vladuzzul
vladuzzul merged commit 49a733d into mainAug 3, 2026
1 check passed

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates a Limelight vision pipeline into the KronBot runtime and uses Limelight tx to augment turret auto-aim, with fallback to odometry when no target is available.

Changes:

  • Add Limelight tuning constants (LIMELIGHT_TURRET_KP, LIMELIGHT_TX_DEADBAND).
  • Introduce a Robot.Limelight subsystem (init/update/telemetry/stop) and call it from the main loop.
  • Update turret auto-aim to use Limelight correction when a fresh target is present, with additional driver-facing telemetry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.javaAdds Limelight control constants for turret correction/deadband.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.javaAdds Limelight subsystem and merges Limelight-based correction into turret auto-aim logic.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.javaInitializes/stops Limelight and exposes Limelight telemetry during teleop.
Suppressed comments (1)

TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java:66

  • Unused imports (LLStatus, ElapsedTime) add clutter and can trigger lint/build warnings. Remove them if not needed.
import com.qualcomm.hardware.limelightvision.LLStatus;
import com.qualcomm.hardware.limelightvision.Limelight3A;
import com.qualcomm.robotcore.util.ElapsedTime;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +13 to +14
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.hardwareMap;
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.telemetry;
aimSource = "Limelight";
limelightTx = limelightResult.getTx();
if (Math.abs(limelightTx) > LIMELIGHT_TX_DEADBAND) {
limelightCorrection = Math.toRadians(limelightTx) * LIMELflaIGHT_TURRET_KP;
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vladuzzul@sch1afend
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Merge auto-aim based on limelight by vladuzzul · Pull Request #6 · kronbot/decode · GitHub
Skip to content

Merge auto-aim based on limelight - #6

Merged
vladuzzul merged 5 commits into
mainfrom
Cosmin
Aug 3, 2026
Merged

Merge auto-aim based on limelight#6
vladuzzul merged 5 commits into
mainfrom
Cosmin

Conversation

@vladuzzul

Copy link
Copy Markdown
Member

Before issuing a pull request, please see the contributing page.

CopilotAI review requested due to automatic review settings August 3, 2026 10:46
@coderabbitai

coderabbitaiBot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@vladuzzul, you've reached your PR review limit, so we couldn't start this review.

Next review available in:57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbc5a854-6667-4896-a4db-5a1afa46d787

📥 Commits

Reviewing files that changed from the base of the PR and between e4558d1 and afa081b.

📒 Files selected for processing (3)
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vladuzzul
vladuzzul merged commit 49a733d into mainAug 3, 2026
1 check passed

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates a Limelight vision pipeline into the KronBot runtime and uses Limelight tx to augment turret auto-aim, with fallback to odometry when no target is available.

Changes:

  • Add Limelight tuning constants (LIMELIGHT_TURRET_KP, LIMELIGHT_TX_DEADBAND).
  • Introduce a Robot.Limelight subsystem (init/update/telemetry/stop) and call it from the main loop.
  • Update turret auto-aim to use Limelight correction when a fresh target is present, with additional driver-facing telemetry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.javaAdds Limelight control constants for turret correction/deadband.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.javaAdds Limelight subsystem and merges Limelight-based correction into turret auto-aim logic.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.javaInitializes/stops Limelight and exposes Limelight telemetry during teleop.
Suppressed comments (1)

TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java:66

  • Unused imports (LLStatus, ElapsedTime) add clutter and can trigger lint/build warnings. Remove them if not needed.
import com.qualcomm.hardware.limelightvision.LLStatus;
import com.qualcomm.hardware.limelightvision.Limelight3A;
import com.qualcomm.robotcore.util.ElapsedTime;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +13 to +14
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.hardwareMap;
import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.telemetry;
aimSource = "Limelight";
limelightTx = limelightResult.getTx();
if (Math.abs(limelightTx) > LIMELIGHT_TX_DEADBAND) {
limelightCorrection = Math.toRadians(limelightTx) * LIMELflaIGHT_TURRET_KP;
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vladuzzul@sch1afend