Uh oh!
There was an error while loading. Please reload this page.
Conversation
Warning Review limit reached
Next review available in:57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Pull request overview
This PR integrates a Limelight vision pipeline into the KronBot runtime and uses Limelight tx to augment turret auto-aim, with fallback to odometry when no target is available.
Changes:
- Add Limelight tuning constants (
LIMELIGHT_TURRET_KP,LIMELIGHT_TX_DEADBAND). - Introduce a
Robot.Limelightsubsystem (init/update/telemetry/stop) and call it from the main loop. - Update turret auto-aim to use Limelight correction when a fresh target is present, with additional driver-facing telemetry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.java | Adds Limelight control constants for turret correction/deadband. |
| TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java | Adds Limelight subsystem and merges Limelight-based correction into turret auto-aim logic. |
| TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.java | Initializes/stops Limelight and exposes Limelight telemetry during teleop. |
Suppressed comments (1)
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java:66
- Unused imports (
LLStatus,ElapsedTime) add clutter and can trigger lint/build warnings. Remove them if not needed.
import com.qualcomm.hardware.limelightvision.LLStatus;
import com.qualcomm.hardware.limelightvision.Limelight3A;
import com.qualcomm.robotcore.util.ElapsedTime;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.hardwareMap; | ||
| import static org.firstinspires.ftc.robotcore.external.BlocksOpModeCompanion.telemetry; |
| aimSource = "Limelight"; | ||
| limelightTx = limelightResult.getTx(); | ||
| if (Math.abs(limelightTx) > LIMELIGHT_TX_DEADBAND) { | ||
| limelightCorrection = Math.toRadians(limelightTx) * LIMELflaIGHT_TURRET_KP; |
Before issuing a pull request, please see the contributing page.