Make PragmaScope a no-op for empty warning lists to prevent global warning suppression leakage - #98
Merged
Conversation
Co-authored-by: matt-edmondson <19528727+matt-edmondson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix PragmaScope handling of empty warning lists
Make Sep 13, 2026
PragmaScope a no-op for empty warning lists to prevent global warning suppression leakage
matt-edmondson
marked this pull request as ready for review
September 13, 2026 13:04
|
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PragmaScopepreviously emitted bare#pragma warning disable/restorewhen given an empty warning list, which in C# applies to all warnings. In nested scopes, this could both over-suppress diagnostics inside the inner scope and prematurely restore warnings in an enclosing scope.Behavioral change: empty warnings are now no-op
PragmaScopenow skips emitting directives whenwarningsis null/empty/whitespace.API contract documentation
PragmaScopeXML docs on thewarningsparameter to explicitly define empty/whitespace input as no-op behavior.Regression coverage
new PragmaScope(cb, ""))new PragmaScope(cb, [])) nested inside an outer pragma scopeCS1591suppression remains active until its own scope closes.