Honor ChainsToThis for zero-argument constructor delegation - #99
Merged
Merged
Conversation
Co-authored-by: matt-edmondson <19528727+matt-edmondson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ConstructorTemplate to handle zero-argument 'this()' delegation
Honor Sep 13, 2026
ChainsToThis for zero-argument constructor delegation
matt-edmondson
marked this pull request as ready for review
September 13, 2026 13:05
|
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



ConstructorTemplatepreviously emitted an initializer only whenBaseParameterswas non-empty, makingChainsToThis = trueineffective for zero-argument delegation. As a result, intended: this()chains were silently dropped and constructors fell back to implicit: base().Initializer emission logic
ConstructorTemplate.WriteInitialiserToto emit an initializer whenChainsToThisistrue, even ifBaseParametersis empty.baseinitializers when no parameters are supplied.API contract/docs alignment
BaseParametersandChainsToThisto explicitly describe empty-argument behavior and: this()emission.Coverage for missing case
ChainsToThis = truewith emptyBaseParameters, asserting: this()is produced.Now renders:
: this()#96