Uh oh!
There was an error while loading. Please reload this page.
chore: Add welcome new contributors CI - #82
Conversation
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Pull Request Test Coverage Report for Build 17445598990Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
andreyvelich
left a comment
There was a problem hiding this comment.
That's great idea, thank you for this @kramaranya!
We should also add this for Kubeflow Trainer.
cc @kubeflow/kubeflow-trainer-team @kubeflow/kubeflow-sdk-team @kubeflow/wg-training-leads
| Thanks for opening your first PR! We're happy to have you as part of our community 🚀 | ||
| **Here's what happens next:** | ||
There was a problem hiding this comment.
Maybe it worths to also link the Kubeflow contributor guide, since it explains that commits must be singed: https://www.kubeflow.org/docs/about/contributing/
There was a problem hiding this comment.
Good point, let me add this
| **Here's what happens next:** | ||
| - If you haven't already, please check out our [Contributing Guide](https://github.com/kubeflow/sdk/blob/main/CONTRIBUTING.md) |
There was a problem hiding this comment.
Shall we also encourage them to join Kubeflow Slack channels (e.g. #kubeflow-trainer and #kubeflow-ml-experience) and community calls ?
There was a problem hiding this comment.
Sure, I'll update it!
However I think we should just refer to #kubeflow-ml-experience, wdyt?
There was a problem hiding this comment.
From my point of view, it would be beneficial for contributors to join both of these channels, since Kubeflow SDK will affect many Kubeflow projects.
There was a problem hiding this comment.
Yeah, but in this case will we need to also add Slack channels for model registry, pipelines, katib etc?
There was a problem hiding this comment.
Let's add them once we support it in Kubeflow SDK ?
There was a problem hiding this comment.
I meant do we actually want to explicitly point to each project's slack channel? If we list multiple channels, it might confuse new contributors about where to start or which channel to use for what.
I'll add trainer to the list, but in the future (same in README) maybe we could point to #kubeflow-ml-experience as the primary channel and add a note that contributors should also join other project specific channels (like trainer, pipelines) if they're working on features that touch those components?
There was a problem hiding this comment.
Sure, we can do that.
If they're working on features that touch those components?
In any case, contributors will work on features that touch some Kubeflow sub-projects, so they should be aware of the development.
| permissions: | ||
| pull-requests: write | ||
| steps: | ||
| - uses: actions/first-interaction@v3 |
There was a problem hiding this comment.
Do you know how it detects the first interaction ? Does it check how many PRs user opens ?
There was a problem hiding this comment.
I don't know for sure, I think it just checks whether the PR author has ever opened a PR here before https://github.com/actions/first-interaction/tree/main?tab=readme-ov-file#first-interaction
and just hope it'll work... :)
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: kramaranya <kramaranya15@gmail.com>
andreyvelich
left a comment
There was a problem hiding this comment.
Thank you @kramaranya!
If you can create similar action in KF Trainer, that would be great!
/lgtm
/assign @kubeflow/kubeflow-sdk-team
kramaranya
commented
Sep 5, 2025
Sure, I will! Let's just first ensure it works :) |
Electronic-Waste
left a comment
There was a problem hiding this comment.
@kramaranya Thanks for this great contribution. LGTM!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Uh oh!
There was an error while loading. Please reload this page.
* chore: Add welcome new contributors CI Signed-off-by: kramaranya <kramaranya15@gmail.com> * Add community links to welcome CI Signed-off-by: kramaranya <kramaranya15@gmail.com> * Add slack channels to CI Signed-off-by: kramaranya <kramaranya15@gmail.com> --------- Signed-off-by: kramaranya <kramaranya15@gmail.com>
* chore: Add welcome new contributors CI Signed-off-by: kramaranya <kramaranya15@gmail.com> * Add community links to welcome CI Signed-off-by: kramaranya <kramaranya15@gmail.com> * Add slack channels to CI Signed-off-by: kramaranya <kramaranya15@gmail.com> --------- Signed-off-by: kramaranya <kramaranya15@gmail.com>
* chore: Add welcome new contributors CI Signed-off-by: kramaranya <kramaranya15@gmail.com> * Add community links to welcome CI Signed-off-by: kramaranya <kramaranya15@gmail.com> * Add slack channels to CI Signed-off-by: kramaranya <kramaranya15@gmail.com> --------- Signed-off-by: kramaranya <kramaranya15@gmail.com>
* add common snyk workflow Signed-off-by: Brian Gallagher <briangal@gmail.com> * Addressing copilot issues and adding comments for readability Signed-off-by: Brian Gallagher <briangal@gmail.com> --------- Signed-off-by: Brian Gallagher <briangal@gmail.com>
I added a CI to write a comment to the PRs from new contributors. I'm using https://github.com/actions/first-interaction
An example of this GH action is RaspberryPiFoundation/blockly#9250 (review)
I borrowed this idea from Model Registry, thanks @tarilabs!
cc @kubeflow/kubeflow-sdk-team