Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

raise exception when an empty config file is passed to load_kube_config - #223

Merged
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom
MridulS:empty_file_error
Feb 9, 2021
Merged

raise exception when an empty config file is passed to load_kube_config#223
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom
MridulS:empty_file_error

Conversation

@MridulS

@MridulSMridulS commented Jan 22, 2021

Copy link
Copy Markdown
Contributor

load_kube_config currently fails with a nondescript TypeError: 'NoneType' error if an empty kube_config file is used.

Error log

~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_kube_config(config_file, context, client_configuration, persist_config)
790 config_file = KUBE_CONFIG_DEFAULT_LOCATION
791
--> 792 loader = _get_kube_config_loader(
793 filename=config_file, active_context=context,
794 persist_config=persist_config)
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _get_kube_config_loader(filename, config_dict, persist_config, **kwargs)
744 **kwargs):
745 if config_dict is None:
--> 746 kcfg = KubeConfigMerger(filename)
747 if persist_config and 'config_persister' not in kwargs:
748 kwargs['config_persister'] = kcfg.save_changes
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in __init__(self, paths)
671 self._load_config_from_file_like_object(paths)
672 else:
--> 673 self._load_config_from_file_path(paths)
674
675 @property
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _load_config_from_file_path(self, string)
693 if os.path.exists(path):
694 self.paths.append(path)
--> 695 self.load_config(path)
696 self.config_saved = copy.deepcopy(self.config_files)
697
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_config(self, path)
703 config_merged = copy.deepcopy(config)
704 for item in ('clusters', 'contexts', 'users'):
--> 705 config_merged[item] = []
706 self.config_merged = ConfigNode(path, config_merged, path)
707 for item in ('clusters', 'contexts', 'users'):
TypeError: 'NoneType' object does not support item assignment

I have added a check to raise a ConfigException error if an empty file is encountered.

@k8s-ci-robot

k8s-ci-robot commented Jan 22, 2021

Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robotk8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 22, 2021
@k8s-ci-robot

k8s-ci-robot commented Jan 22, 2021

Copy link
Copy Markdown
Contributor

Welcome @MridulS!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robotk8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2021
@k8s-ci-robotk8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 23, 2021
@MridulS

MridulS commented Jan 25, 2021

Copy link
Copy Markdown
ContributorAuthor

The travis error on functional tests seems to be because of a minikube error.

W0125 15:54:45.089355 4821 out.go:181] X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
493X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
494I0125 15:54:45.089376 4821 out.go:119] 495
496

@yliaog

yliaog commented Feb 1, 2021

Copy link
Copy Markdown
Contributor

/assign @fabianvf

fabianvf
fabianvf reviewed Feb 1, 2021
View reviewed changes
Comment threadconfig/kube_config_test.py Outdated
@MridulS
MridulS requested a review from fabianvfFebruary 2, 2021 08:55
@MridulS

MridulS commented Feb 2, 2021

Copy link
Copy Markdown
ContributorAuthor

/retest

@k8s-ci-robot

k8s-ci-robot commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

@MridulS: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yliaog

yliaog commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robotk8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 2, 2021
@MridulS

MridulS commented Feb 2, 2021

Copy link
Copy Markdown
ContributorAuthor

/retest

@MridulS

MridulS commented Feb 2, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Travis seems to be failing due to an unrelated test. Any ideas what's happening here? Travis is happy now :D

@MridulS

MridulS commented Feb 9, 2021

Copy link
Copy Markdown
ContributorAuthor

Just wanted to check in to see if this looks okay :)

@fabianvf

fabianvf commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robotk8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2021
@MridulS

MridulS commented Feb 9, 2021

Copy link
Copy Markdown
ContributorAuthor

/assign @yliaog

@yliaog

yliaog commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot

k8s-ci-robot commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianvf, MridulS, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robotk8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2021
@k8s-ci-robot
k8s-ci-robot merged commit 04feb9f into kubernetes-client:masterFeb 9, 2021
@MridulSMridulS mentioned this pull request Feb 9, 2021
Closed
@chrisayoubchrisayoub mentioned this pull request Feb 25, 2021
Merged
@coderabbitaicoderabbitaiBot mentioned this pull request May 12, 2026
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roycaihwroycaihwAwaiting requested review from roycaihw
@yliaogyliaogAwaiting requested review from yliaog
1 more reviewer
@fabianvffabianvffabianvf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fabianvffabianvf

@yliaogyliaog

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.size/SDenotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MridulS@k8s-ci-robot@yliaog@fabianvf
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
raise exception when an empty config file is passed to load_kube_config by MridulS · Pull Request #223 · kubernetes-client/python-base · GitHub
Skip to content

This repository was archived by the owner on Mar 13, 2022. It is now read-only.

raise exception when an empty config file is passed to load_kube_config - #223
Merged
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom 
MridulS:empty_file_error
Feb 9, 2021
Merged
raise exception when an empty config file is passed to load_kube_config#223
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom 
MridulS:empty_file_error
Conversation
@MridulS
@MridulSMridulS
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
load_kube_config currently fails with a nondescript TypeError: 'NoneType' error if an empty kube_config file is used.
Error log
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_kube_config(config_file, context, client_configuration, persist_config)
790 config_file = KUBE_CONFIG_DEFAULT_LOCATION
791
--> 792 loader = _get_kube_config_loader(
793 filename=config_file, active_context=context,
794 persist_config=persist_config)
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _get_kube_config_loader(filename, config_dict, persist_config, **kwargs)
744 **kwargs):
745 if config_dict is None:
--> 746 kcfg = KubeConfigMerger(filename)
747 if persist_config and 'config_persister' not in kwargs:
748 kwargs['config_persister'] = kcfg.save_changes
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in __init__(self, paths)
671 self._load_config_from_file_like_object(paths)
672 else:
--> 673 self._load_config_from_file_path(paths)
674
675 @property
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _load_config_from_file_path(self, string)
693 if os.path.exists(path):
694 self.paths.append(path)
--> 695 self.load_config(path)
696 self.config_saved = copy.deepcopy(self.config_files)
697
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_config(self, path)
703 config_merged = copy.deepcopy(config)
704 for item in ('clusters', 'contexts', 'users'):
--> 705 config_merged[item] = []
706 self.config_merged = ConfigNode(path, config_merged, path)
707 for item in ('clusters', 'contexts', 'users'):
TypeError: 'NoneType' object does not support item assignment

I have added a check to raise a ConfigException error if an empty file is encountered.
@k8s-ci-robot
k8s-ci-robot
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@k8s-ci-robotk8s-ci-robot
added
the 
cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
label
Jan 22, 2021
@k8s-ci-robot
k8s-ci-robot
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
Welcome @MridulS! 

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval. 

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation. 

You can also check if kubernetes-client/python-base has its own contribution guidelines. 

You may want to refer to our testing guide if you run into trouble with your tests not passing. 

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs! 

Thank you, and welcome to Kubernetes. 😃
@k8s-ci-robotk8s-ci-robot
added
the 
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Jan 22, 2021
@k8s-ci-robotk8s-ci-robot
added

cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
and removed

cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
labels
Jan 23, 2021
@MridulS
MridulS
commented
Jan 25, 2021

Copy link


Copy Markdown

ContributorAuthor
The travis error on functional tests seems to be because of a minikube error.
W0125 15:54:45.089355 4821 out.go:181] X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
493X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
494I0125 15:54:45.089376 4821 out.go:119] 495
496

@yliaog
yliaog
commented
Feb 1, 2021

Copy link


Copy Markdown

Contributor
/assign @fabianvf
fabianvf
fabianvf
reviewed
Feb 1, 2021
View reviewed changes
Comment threadconfig/kube_config_test.py
Outdated

@MridulS
MridulS
requested a review
from fabianvfFebruary 2, 2021 08:55
@MridulS
MridulS
commented
Feb 2, 2021

Copy link


Copy Markdown

ContributorAuthor
/retest
@k8s-ci-robot
k8s-ci-robot
commented
Feb 2, 2021

Copy link


Copy Markdown

Contributor
@MridulS: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
Details
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@yliaog
yliaog
commented
Feb 2, 2021

Copy link


Copy Markdown

Contributor
/ok-to-test
@k8s-ci-robotk8s-ci-robot
added
the 
ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
label
Feb 2, 2021
@MridulS
MridulS
commented
Feb 2, 2021

Copy link


Copy Markdown

ContributorAuthor
/retest
@MridulS
MridulS
commented
Feb 2, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Travis seems to be failing due to an unrelated test. Any ideas what's happening here? Travis is happy now :D
@MridulS
MridulS
commented
Feb 9, 2021

Copy link


Copy Markdown

ContributorAuthor
Just wanted to check in to see if this looks okay :)
@fabianvf
fabianvf
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
/lgtm
@k8s-ci-robotk8s-ci-robot
added
the 
lgtm
Indicates that a PR is ready to be merged.
label
Feb 9, 2021
@MridulS
MridulS
commented
Feb 9, 2021

Copy link


Copy Markdown

ContributorAuthor
/assign @yliaog
@yliaog
yliaog
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
/approve
@k8s-ci-robot
k8s-ci-robot
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fabianvf, MridulS, yliaog
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment

Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robotk8s-ci-robot
added
the 
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Feb 9, 2021
@k8s-ci-robot
k8s-ci-robot
merged commit 04feb9f
into
kubernetes-client:masterFeb 9, 2021
@MridulSMridulS
mentioned this pull request
Feb 9, 2021

Closed

@chrisayoubchrisayoub
mentioned this pull request
Feb 25, 2021
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
May 12, 2026
 Merged

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@roycaihwroycaihwAwaiting requested review from roycaihw
@yliaogyliaogAwaiting requested review from yliaog

1 more reviewer

@fabianvffabianvffabianvf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fabianvffabianvf
@yliaogyliaog

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.size/SDenotes a PR that changes 10-29 lines, ignoring generated files.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@MridulS@k8s-ci-robot@yliaog@fabianvf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
raise exception when an empty config file is passed to load_kube_config by MridulS · Pull Request #223 · kubernetes-client/python-base · GitHub
Skip to content

This repository was archived by the owner on Mar 13, 2022. It is now read-only.

raise exception when an empty config file is passed to load_kube_config - #223
Merged
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom 
MridulS:empty_file_error
Feb 9, 2021
Merged
raise exception when an empty config file is passed to load_kube_config#223
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom 
MridulS:empty_file_error
Conversation
@MridulS
@MridulSMridulS
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
load_kube_config currently fails with a nondescript TypeError: 'NoneType' error if an empty kube_config file is used.
Error log
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_kube_config(config_file, context, client_configuration, persist_config)
790 config_file = KUBE_CONFIG_DEFAULT_LOCATION
791
--> 792 loader = _get_kube_config_loader(
793 filename=config_file, active_context=context,
794 persist_config=persist_config)
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _get_kube_config_loader(filename, config_dict, persist_config, **kwargs)
744 **kwargs):
745 if config_dict is None:
--> 746 kcfg = KubeConfigMerger(filename)
747 if persist_config and 'config_persister' not in kwargs:
748 kwargs['config_persister'] = kcfg.save_changes
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in __init__(self, paths)
671 self._load_config_from_file_like_object(paths)
672 else:
--> 673 self._load_config_from_file_path(paths)
674
675 @property
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _load_config_from_file_path(self, string)
693 if os.path.exists(path):
694 self.paths.append(path)
--> 695 self.load_config(path)
696 self.config_saved = copy.deepcopy(self.config_files)
697
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_config(self, path)
703 config_merged = copy.deepcopy(config)
704 for item in ('clusters', 'contexts', 'users'):
--> 705 config_merged[item] = []
706 self.config_merged = ConfigNode(path, config_merged, path)
707 for item in ('clusters', 'contexts', 'users'):
TypeError: 'NoneType' object does not support item assignment

I have added a check to raise a ConfigException error if an empty file is encountered.
@k8s-ci-robot
k8s-ci-robot
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@k8s-ci-robotk8s-ci-robot
added
the 
cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
label
Jan 22, 2021
@k8s-ci-robot
k8s-ci-robot
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
Welcome @MridulS! 

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval. 

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation. 

You can also check if kubernetes-client/python-base has its own contribution guidelines. 

You may want to refer to our testing guide if you run into trouble with your tests not passing. 

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs! 

Thank you, and welcome to Kubernetes. 😃
@k8s-ci-robotk8s-ci-robot
added
the 
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Jan 22, 2021
@k8s-ci-robotk8s-ci-robot
added

cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
and removed

cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
labels
Jan 23, 2021
@MridulS
MridulS
commented
Jan 25, 2021

Copy link


Copy Markdown

ContributorAuthor
The travis error on functional tests seems to be because of a minikube error.
W0125 15:54:45.089355 4821 out.go:181] X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
493X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
494I0125 15:54:45.089376 4821 out.go:119] 495
496

@yliaog
yliaog
commented
Feb 1, 2021

Copy link


Copy Markdown

Contributor
/assign @fabianvf
fabianvf
fabianvf
reviewed
Feb 1, 2021
View reviewed changes
Comment threadconfig/kube_config_test.py
Outdated

@MridulS
MridulS
requested a review
from fabianvfFebruary 2, 2021 08:55
@MridulS
MridulS
commented
Feb 2, 2021

Copy link


Copy Markdown

ContributorAuthor
/retest
@k8s-ci-robot
k8s-ci-robot
commented
Feb 2, 2021

Copy link


Copy Markdown

Contributor
@MridulS: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
Details
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@yliaog
yliaog
commented
Feb 2, 2021

Copy link


Copy Markdown

Contributor
/ok-to-test
@k8s-ci-robotk8s-ci-robot
added
the 
ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
label
Feb 2, 2021
@MridulS
MridulS
commented
Feb 2, 2021

Copy link


Copy Markdown

ContributorAuthor
/retest
@MridulS
MridulS
commented
Feb 2, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Travis seems to be failing due to an unrelated test. Any ideas what's happening here? Travis is happy now :D
@MridulS
MridulS
commented
Feb 9, 2021

Copy link


Copy Markdown

ContributorAuthor
Just wanted to check in to see if this looks okay :)
@fabianvf
fabianvf
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
/lgtm
@k8s-ci-robotk8s-ci-robot
added
the 
lgtm
Indicates that a PR is ready to be merged.
label
Feb 9, 2021
@MridulS
MridulS
commented
Feb 9, 2021

Copy link


Copy Markdown

ContributorAuthor
/assign @yliaog
@yliaog
yliaog
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
/approve
@k8s-ci-robot
k8s-ci-robot
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fabianvf, MridulS, yliaog
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment

Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robotk8s-ci-robot
added
the 
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Feb 9, 2021
@k8s-ci-robot
k8s-ci-robot
merged commit 04feb9f
into
kubernetes-client:masterFeb 9, 2021
@MridulSMridulS
mentioned this pull request
Feb 9, 2021

Closed

@chrisayoubchrisayoub
mentioned this pull request
Feb 25, 2021
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
May 12, 2026
 Merged

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@roycaihwroycaihwAwaiting requested review from roycaihw
@yliaogyliaogAwaiting requested review from yliaog

1 more reviewer

@fabianvffabianvffabianvf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fabianvffabianvf
@yliaogyliaog

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.size/SDenotes a PR that changes 10-29 lines, ignoring generated files.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@MridulS@k8s-ci-robot@yliaog@fabianvf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
raise exception when an empty config file is passed to load_kube_config by MridulS · Pull Request #223 · kubernetes-client/python-base · GitHub
Skip to content

This repository was archived by the owner on Mar 13, 2022. It is now read-only.

raise exception when an empty config file is passed to load_kube_config - #223
Merged
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom 
MridulS:empty_file_error
Feb 9, 2021
Merged
raise exception when an empty config file is passed to load_kube_config#223
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom 
MridulS:empty_file_error
Conversation
@MridulS
@MridulSMridulS
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
load_kube_config currently fails with a nondescript TypeError: 'NoneType' error if an empty kube_config file is used.
Error log
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_kube_config(config_file, context, client_configuration, persist_config)
790 config_file = KUBE_CONFIG_DEFAULT_LOCATION
791
--> 792 loader = _get_kube_config_loader(
793 filename=config_file, active_context=context,
794 persist_config=persist_config)
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _get_kube_config_loader(filename, config_dict, persist_config, **kwargs)
744 **kwargs):
745 if config_dict is None:
--> 746 kcfg = KubeConfigMerger(filename)
747 if persist_config and 'config_persister' not in kwargs:
748 kwargs['config_persister'] = kcfg.save_changes
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in __init__(self, paths)
671 self._load_config_from_file_like_object(paths)
672 else:
--> 673 self._load_config_from_file_path(paths)
674
675 @property
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _load_config_from_file_path(self, string)
693 if os.path.exists(path):
694 self.paths.append(path)
--> 695 self.load_config(path)
696 self.config_saved = copy.deepcopy(self.config_files)
697
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_config(self, path)
703 config_merged = copy.deepcopy(config)
704 for item in ('clusters', 'contexts', 'users'):
--> 705 config_merged[item] = []
706 self.config_merged = ConfigNode(path, config_merged, path)
707 for item in ('clusters', 'contexts', 'users'):
TypeError: 'NoneType' object does not support item assignment

I have added a check to raise a ConfigException error if an empty file is encountered.
@k8s-ci-robot
k8s-ci-robot
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@k8s-ci-robotk8s-ci-robot
added
the 
cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
label
Jan 22, 2021
@k8s-ci-robot
k8s-ci-robot
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
Welcome @MridulS! 

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval. 

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation. 

You can also check if kubernetes-client/python-base has its own contribution guidelines. 

You may want to refer to our testing guide if you run into trouble with your tests not passing. 

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs! 

Thank you, and welcome to Kubernetes. 😃
@k8s-ci-robotk8s-ci-robot
added
the 
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Jan 22, 2021
@k8s-ci-robotk8s-ci-robot
added

cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
and removed

cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
labels
Jan 23, 2021
@MridulS
MridulS
commented
Jan 25, 2021

Copy link


Copy Markdown

ContributorAuthor
The travis error on functional tests seems to be because of a minikube error.
W0125 15:54:45.089355 4821 out.go:181] X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
493X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
494I0125 15:54:45.089376 4821 out.go:119] 495
496

@yliaog
yliaog
commented
Feb 1, 2021

Copy link


Copy Markdown

Contributor
/assign @fabianvf
fabianvf
fabianvf
reviewed
Feb 1, 2021
View reviewed changes
Comment threadconfig/kube_config_test.py
Outdated

@MridulS
MridulS
requested a review
from fabianvfFebruary 2, 2021 08:55
@MridulS
MridulS
commented
Feb 2, 2021

Copy link


Copy Markdown

ContributorAuthor
/retest
@k8s-ci-robot
k8s-ci-robot
commented
Feb 2, 2021

Copy link


Copy Markdown

Contributor
@MridulS: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
Details
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@yliaog
yliaog
commented
Feb 2, 2021

Copy link


Copy Markdown

Contributor
/ok-to-test
@k8s-ci-robotk8s-ci-robot
added
the 
ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
label
Feb 2, 2021
@MridulS
MridulS
commented
Feb 2, 2021

Copy link


Copy Markdown

ContributorAuthor
/retest
@MridulS
MridulS
commented
Feb 2, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Travis seems to be failing due to an unrelated test. Any ideas what's happening here? Travis is happy now :D
@MridulS
MridulS
commented
Feb 9, 2021

Copy link


Copy Markdown

ContributorAuthor
Just wanted to check in to see if this looks okay :)
@fabianvf
fabianvf
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
/lgtm
@k8s-ci-robotk8s-ci-robot
added
the 
lgtm
Indicates that a PR is ready to be merged.
label
Feb 9, 2021
@MridulS
MridulS
commented
Feb 9, 2021

Copy link


Copy Markdown

ContributorAuthor
/assign @yliaog
@yliaog
yliaog
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
/approve
@k8s-ci-robot
k8s-ci-robot
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fabianvf, MridulS, yliaog
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment

Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robotk8s-ci-robot
added
the 
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Feb 9, 2021
@k8s-ci-robot
k8s-ci-robot
merged commit 04feb9f
into
kubernetes-client:masterFeb 9, 2021
@MridulSMridulS
mentioned this pull request
Feb 9, 2021

Closed

@chrisayoubchrisayoub
mentioned this pull request
Feb 25, 2021
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
May 12, 2026
 Merged

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@roycaihwroycaihwAwaiting requested review from roycaihw
@yliaogyliaogAwaiting requested review from yliaog

1 more reviewer

@fabianvffabianvffabianvf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fabianvffabianvf
@yliaogyliaog

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.size/SDenotes a PR that changes 10-29 lines, ignoring generated files.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@MridulS@k8s-ci-robot@yliaog@fabianvf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
raise exception when an empty config file is passed to load_kube_config by MridulS · Pull Request #223 · kubernetes-client/python-base · GitHub
Skip to content

This repository was archived by the owner on Mar 13, 2022. It is now read-only.

raise exception when an empty config file is passed to load_kube_config - #223
Merged
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom 
MridulS:empty_file_error
Feb 9, 2021
Merged
raise exception when an empty config file is passed to load_kube_config#223
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom 
MridulS:empty_file_error
Conversation
@MridulS
@MridulSMridulS
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
load_kube_config currently fails with a nondescript TypeError: 'NoneType' error if an empty kube_config file is used.
Error log
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_kube_config(config_file, context, client_configuration, persist_config)
790 config_file = KUBE_CONFIG_DEFAULT_LOCATION
791
--> 792 loader = _get_kube_config_loader(
793 filename=config_file, active_context=context,
794 persist_config=persist_config)
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _get_kube_config_loader(filename, config_dict, persist_config, **kwargs)
744 **kwargs):
745 if config_dict is None:
--> 746 kcfg = KubeConfigMerger(filename)
747 if persist_config and 'config_persister' not in kwargs:
748 kwargs['config_persister'] = kcfg.save_changes
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in __init__(self, paths)
671 self._load_config_from_file_like_object(paths)
672 else:
--> 673 self._load_config_from_file_path(paths)
674
675 @property
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _load_config_from_file_path(self, string)
693 if os.path.exists(path):
694 self.paths.append(path)
--> 695 self.load_config(path)
696 self.config_saved = copy.deepcopy(self.config_files)
697
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_config(self, path)
703 config_merged = copy.deepcopy(config)
704 for item in ('clusters', 'contexts', 'users'):
--> 705 config_merged[item] = []
706 self.config_merged = ConfigNode(path, config_merged, path)
707 for item in ('clusters', 'contexts', 'users'):
TypeError: 'NoneType' object does not support item assignment

I have added a check to raise a ConfigException error if an empty file is encountered.
@k8s-ci-robot
k8s-ci-robot
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@k8s-ci-robotk8s-ci-robot
added
the 
cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
label
Jan 22, 2021
@k8s-ci-robot
k8s-ci-robot
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
Welcome @MridulS! 

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval. 

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation. 

You can also check if kubernetes-client/python-base has its own contribution guidelines. 

You may want to refer to our testing guide if you run into trouble with your tests not passing. 

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs! 

Thank you, and welcome to Kubernetes. 😃
@k8s-ci-robotk8s-ci-robot
added
the 
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Jan 22, 2021
@k8s-ci-robotk8s-ci-robot
added

cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
and removed

cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
labels
Jan 23, 2021
@MridulS
MridulS
commented
Jan 25, 2021

Copy link


Copy Markdown

ContributorAuthor
The travis error on functional tests seems to be because of a minikube error.
W0125 15:54:45.089355 4821 out.go:181] X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
493X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
494I0125 15:54:45.089376 4821 out.go:119] 495
496

@yliaog
yliaog
commented
Feb 1, 2021

Copy link


Copy Markdown

Contributor
/assign @fabianvf
fabianvf
fabianvf
reviewed
Feb 1, 2021
View reviewed changes
Comment threadconfig/kube_config_test.py
Outdated

@MridulS
MridulS
requested a review
from fabianvfFebruary 2, 2021 08:55
@MridulS
MridulS
commented
Feb 2, 2021

Copy link


Copy Markdown

ContributorAuthor
/retest
@k8s-ci-robot
k8s-ci-robot
commented
Feb 2, 2021

Copy link


Copy Markdown

Contributor
@MridulS: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
Details
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@yliaog
yliaog
commented
Feb 2, 2021

Copy link


Copy Markdown

Contributor
/ok-to-test
@k8s-ci-robotk8s-ci-robot
added
the 
ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
label
Feb 2, 2021
@MridulS
MridulS
commented
Feb 2, 2021

Copy link


Copy Markdown

ContributorAuthor
/retest
@MridulS
MridulS
commented
Feb 2, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Travis seems to be failing due to an unrelated test. Any ideas what's happening here? Travis is happy now :D
@MridulS
MridulS
commented
Feb 9, 2021

Copy link


Copy Markdown

ContributorAuthor
Just wanted to check in to see if this looks okay :)
@fabianvf
fabianvf
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
/lgtm
@k8s-ci-robotk8s-ci-robot
added
the 
lgtm
Indicates that a PR is ready to be merged.
label
Feb 9, 2021
@MridulS
MridulS
commented
Feb 9, 2021

Copy link


Copy Markdown

ContributorAuthor
/assign @yliaog
@yliaog
yliaog
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
/approve
@k8s-ci-robot
k8s-ci-robot
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fabianvf, MridulS, yliaog
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment

Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robotk8s-ci-robot
added
the 
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Feb 9, 2021
@k8s-ci-robot
k8s-ci-robot
merged commit 04feb9f
into
kubernetes-client:masterFeb 9, 2021
@MridulSMridulS
mentioned this pull request
Feb 9, 2021

Closed

@chrisayoubchrisayoub
mentioned this pull request
Feb 25, 2021
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
May 12, 2026
 Merged

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@roycaihwroycaihwAwaiting requested review from roycaihw
@yliaogyliaogAwaiting requested review from yliaog

1 more reviewer

@fabianvffabianvffabianvf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fabianvffabianvf
@yliaogyliaog

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.size/SDenotes a PR that changes 10-29 lines, ignoring generated files.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@MridulS@k8s-ci-robot@yliaog@fabianvf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
raise exception when an empty config file is passed to load_kube_config by MridulS · Pull Request #223 · kubernetes-client/python-base · GitHub
Skip to content

This repository was archived by the owner on Mar 13, 2022. It is now read-only.

raise exception when an empty config file is passed to load_kube_config - #223
Merged
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom 
MridulS:empty_file_error
Feb 9, 2021
Merged
raise exception when an empty config file is passed to load_kube_config#223
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom 
MridulS:empty_file_error
Conversation
@MridulS
@MridulSMridulS
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
load_kube_config currently fails with a nondescript TypeError: 'NoneType' error if an empty kube_config file is used.
Error log
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_kube_config(config_file, context, client_configuration, persist_config)
790 config_file = KUBE_CONFIG_DEFAULT_LOCATION
791
--> 792 loader = _get_kube_config_loader(
793 filename=config_file, active_context=context,
794 persist_config=persist_config)
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _get_kube_config_loader(filename, config_dict, persist_config, **kwargs)
744 **kwargs):
745 if config_dict is None:
--> 746 kcfg = KubeConfigMerger(filename)
747 if persist_config and 'config_persister' not in kwargs:
748 kwargs['config_persister'] = kcfg.save_changes
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in __init__(self, paths)
671 self._load_config_from_file_like_object(paths)
672 else:
--> 673 self._load_config_from_file_path(paths)
674
675 @property
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _load_config_from_file_path(self, string)
693 if os.path.exists(path):
694 self.paths.append(path)
--> 695 self.load_config(path)
696 self.config_saved = copy.deepcopy(self.config_files)
697
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_config(self, path)
703 config_merged = copy.deepcopy(config)
704 for item in ('clusters', 'contexts', 'users'):
--> 705 config_merged[item] = []
706 self.config_merged = ConfigNode(path, config_merged, path)
707 for item in ('clusters', 'contexts', 'users'):
TypeError: 'NoneType' object does not support item assignment

I have added a check to raise a ConfigException error if an empty file is encountered.
@k8s-ci-robot
k8s-ci-robot
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@k8s-ci-robotk8s-ci-robot
added
the 
cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
label
Jan 22, 2021
@k8s-ci-robot
k8s-ci-robot
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
Welcome @MridulS! 

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval. 

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation. 

You can also check if kubernetes-client/python-base has its own contribution guidelines. 

You may want to refer to our testing guide if you run into trouble with your tests not passing. 

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs! 

Thank you, and welcome to Kubernetes. 😃
@k8s-ci-robotk8s-ci-robot
added
the 
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Jan 22, 2021
@k8s-ci-robotk8s-ci-robot
added

cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
and removed

cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
labels
Jan 23, 2021
@MridulS
MridulS
commented
Jan 25, 2021

Copy link


Copy Markdown

ContributorAuthor
The travis error on functional tests seems to be because of a minikube error.
W0125 15:54:45.089355 4821 out.go:181] X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
493X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
494I0125 15:54:45.089376 4821 out.go:119] 495
496

@yliaog
yliaog
commented
Feb 1, 2021

Copy link


Copy Markdown

Contributor
/assign @fabianvf
fabianvf
fabianvf
reviewed
Feb 1, 2021
View reviewed changes
Comment threadconfig/kube_config_test.py
Outdated

@MridulS
MridulS
requested a review
from fabianvfFebruary 2, 2021 08:55
@MridulS
MridulS
commented
Feb 2, 2021

Copy link


Copy Markdown

ContributorAuthor
/retest
@k8s-ci-robot
k8s-ci-robot
commented
Feb 2, 2021

Copy link


Copy Markdown

Contributor
@MridulS: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
Details
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@yliaog
yliaog
commented
Feb 2, 2021

Copy link


Copy Markdown

Contributor
/ok-to-test
@k8s-ci-robotk8s-ci-robot
added
the 
ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
label
Feb 2, 2021
@MridulS
MridulS
commented
Feb 2, 2021

Copy link


Copy Markdown

ContributorAuthor
/retest
@MridulS
MridulS
commented
Feb 2, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Travis seems to be failing due to an unrelated test. Any ideas what's happening here? Travis is happy now :D
@MridulS
MridulS
commented
Feb 9, 2021

Copy link


Copy Markdown

ContributorAuthor
Just wanted to check in to see if this looks okay :)
@fabianvf
fabianvf
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
/lgtm
@k8s-ci-robotk8s-ci-robot
added
the 
lgtm
Indicates that a PR is ready to be merged.
label
Feb 9, 2021
@MridulS
MridulS
commented
Feb 9, 2021

Copy link


Copy Markdown

ContributorAuthor
/assign @yliaog
@yliaog
yliaog
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
/approve
@k8s-ci-robot
k8s-ci-robot
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fabianvf, MridulS, yliaog
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment

Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robotk8s-ci-robot
added
the 
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Feb 9, 2021
@k8s-ci-robot
k8s-ci-robot
merged commit 04feb9f
into
kubernetes-client:masterFeb 9, 2021
@MridulSMridulS
mentioned this pull request
Feb 9, 2021

Closed

@chrisayoubchrisayoub
mentioned this pull request
Feb 25, 2021
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
May 12, 2026
 Merged

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@roycaihwroycaihwAwaiting requested review from roycaihw
@yliaogyliaogAwaiting requested review from yliaog

1 more reviewer

@fabianvffabianvffabianvf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fabianvffabianvf
@yliaogyliaog

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.size/SDenotes a PR that changes 10-29 lines, ignoring generated files.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@MridulS@k8s-ci-robot@yliaog@fabianvf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
raise exception when an empty config file is passed to load_kube_config by MridulS · Pull Request #223 · kubernetes-client/python-base · GitHub
Skip to content

This repository was archived by the owner on Mar 13, 2022. It is now read-only.

raise exception when an empty config file is passed to load_kube_config - #223
Merged
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom 
MridulS:empty_file_error
Feb 9, 2021
Merged
raise exception when an empty config file is passed to load_kube_config#223
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom 
MridulS:empty_file_error
Conversation
@MridulS
@MridulSMridulS
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
load_kube_config currently fails with a nondescript TypeError: 'NoneType' error if an empty kube_config file is used.
Error log
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_kube_config(config_file, context, client_configuration, persist_config)
790 config_file = KUBE_CONFIG_DEFAULT_LOCATION
791
--> 792 loader = _get_kube_config_loader(
793 filename=config_file, active_context=context,
794 persist_config=persist_config)
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _get_kube_config_loader(filename, config_dict, persist_config, **kwargs)
744 **kwargs):
745 if config_dict is None:
--> 746 kcfg = KubeConfigMerger(filename)
747 if persist_config and 'config_persister' not in kwargs:
748 kwargs['config_persister'] = kcfg.save_changes
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in __init__(self, paths)
671 self._load_config_from_file_like_object(paths)
672 else:
--> 673 self._load_config_from_file_path(paths)
674
675 @property
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _load_config_from_file_path(self, string)
693 if os.path.exists(path):
694 self.paths.append(path)
--> 695 self.load_config(path)
696 self.config_saved = copy.deepcopy(self.config_files)
697
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_config(self, path)
703 config_merged = copy.deepcopy(config)
704 for item in ('clusters', 'contexts', 'users'):
--> 705 config_merged[item] = []
706 self.config_merged = ConfigNode(path, config_merged, path)
707 for item in ('clusters', 'contexts', 'users'):
TypeError: 'NoneType' object does not support item assignment

I have added a check to raise a ConfigException error if an empty file is encountered.
@k8s-ci-robot
k8s-ci-robot
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@k8s-ci-robotk8s-ci-robot
added
the 
cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
label
Jan 22, 2021
@k8s-ci-robot
k8s-ci-robot
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
Welcome @MridulS! 

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval. 

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation. 

You can also check if kubernetes-client/python-base has its own contribution guidelines. 

You may want to refer to our testing guide if you run into trouble with your tests not passing. 

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs! 

Thank you, and welcome to Kubernetes. 😃
@k8s-ci-robotk8s-ci-robot
added
the 
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Jan 22, 2021
@k8s-ci-robotk8s-ci-robot
added

cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
and removed

cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
labels
Jan 23, 2021
@MridulS
MridulS
commented
Jan 25, 2021

Copy link


Copy Markdown

ContributorAuthor
The travis error on functional tests seems to be because of a minikube error.
W0125 15:54:45.089355 4821 out.go:181] X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
493X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
494I0125 15:54:45.089376 4821 out.go:119] 495
496

@yliaog
yliaog
commented
Feb 1, 2021

Copy link


Copy Markdown

Contributor
/assign @fabianvf
fabianvf
fabianvf
reviewed
Feb 1, 2021
View reviewed changes
Comment threadconfig/kube_config_test.py
Outdated

@MridulS
MridulS
requested a review
from fabianvfFebruary 2, 2021 08:55
@MridulS
MridulS
commented
Feb 2, 2021

Copy link


Copy Markdown

ContributorAuthor
/retest
@k8s-ci-robot
k8s-ci-robot
commented
Feb 2, 2021

Copy link


Copy Markdown

Contributor
@MridulS: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
Details
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@yliaog
yliaog
commented
Feb 2, 2021

Copy link


Copy Markdown

Contributor
/ok-to-test
@k8s-ci-robotk8s-ci-robot
added
the 
ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
label
Feb 2, 2021
@MridulS
MridulS
commented
Feb 2, 2021

Copy link


Copy Markdown

ContributorAuthor
/retest
@MridulS
MridulS
commented
Feb 2, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Travis seems to be failing due to an unrelated test. Any ideas what's happening here? Travis is happy now :D
@MridulS
MridulS
commented
Feb 9, 2021

Copy link


Copy Markdown

ContributorAuthor
Just wanted to check in to see if this looks okay :)
@fabianvf
fabianvf
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
/lgtm
@k8s-ci-robotk8s-ci-robot
added
the 
lgtm
Indicates that a PR is ready to be merged.
label
Feb 9, 2021
@MridulS
MridulS
commented
Feb 9, 2021

Copy link


Copy Markdown

ContributorAuthor
/assign @yliaog
@yliaog
yliaog
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
/approve
@k8s-ci-robot
k8s-ci-robot
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fabianvf, MridulS, yliaog
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment

Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robotk8s-ci-robot
added
the 
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Feb 9, 2021
@k8s-ci-robot
k8s-ci-robot
merged commit 04feb9f
into
kubernetes-client:masterFeb 9, 2021
@MridulSMridulS
mentioned this pull request
Feb 9, 2021

Closed

@chrisayoubchrisayoub
mentioned this pull request
Feb 25, 2021
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
May 12, 2026
 Merged

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@roycaihwroycaihwAwaiting requested review from roycaihw
@yliaogyliaogAwaiting requested review from yliaog

1 more reviewer

@fabianvffabianvffabianvf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fabianvffabianvf
@yliaogyliaog

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.size/SDenotes a PR that changes 10-29 lines, ignoring generated files.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@MridulS@k8s-ci-robot@yliaog@fabianvf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
raise exception when an empty config file is passed to load_kube_config by MridulS · Pull Request #223 · kubernetes-client/python-base · GitHub
Skip to content

This repository was archived by the owner on Mar 13, 2022. It is now read-only.

raise exception when an empty config file is passed to load_kube_config - #223
Merged
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom 
MridulS:empty_file_error
Feb 9, 2021
Merged
raise exception when an empty config file is passed to load_kube_config#223
k8s-ci-robot merged 3 commits into
kubernetes-client:masterfrom 
MridulS:empty_file_error
Conversation
@MridulS
@MridulSMridulS
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
load_kube_config currently fails with a nondescript TypeError: 'NoneType' error if an empty kube_config file is used.
Error log
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_kube_config(config_file, context, client_configuration, persist_config)
790 config_file = KUBE_CONFIG_DEFAULT_LOCATION
791
--> 792 loader = _get_kube_config_loader(
793 filename=config_file, active_context=context,
794 persist_config=persist_config)
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _get_kube_config_loader(filename, config_dict, persist_config, **kwargs)
744 **kwargs):
745 if config_dict is None:
--> 746 kcfg = KubeConfigMerger(filename)
747 if persist_config and 'config_persister' not in kwargs:
748 kwargs['config_persister'] = kcfg.save_changes
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in __init__(self, paths)
671 self._load_config_from_file_like_object(paths)
672 else:
--> 673 self._load_config_from_file_path(paths)
674
675 @property
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in _load_config_from_file_path(self, string)
693 if os.path.exists(path):
694 self.paths.append(path)
--> 695 self.load_config(path)
696 self.config_saved = copy.deepcopy(self.config_files)
697
~/miniconda3/envs/dask/lib/python3.8/site-packages/kubernetes/config/kube_config.py in load_config(self, path)
703 config_merged = copy.deepcopy(config)
704 for item in ('clusters', 'contexts', 'users'):
--> 705 config_merged[item] = []
706 self.config_merged = ConfigNode(path, config_merged, path)
707 for item in ('clusters', 'contexts', 'users'):
TypeError: 'NoneType' object does not support item assignment

I have added a check to raise a ConfigException error if an empty file is encountered.
@k8s-ci-robot
k8s-ci-robot
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@k8s-ci-robotk8s-ci-robot
added
the 
cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
label
Jan 22, 2021
@k8s-ci-robot
k8s-ci-robot
commented
Jan 22, 2021

Copy link


Copy Markdown

Contributor
Welcome @MridulS! 

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval. 

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation. 

You can also check if kubernetes-client/python-base has its own contribution guidelines. 

You may want to refer to our testing guide if you run into trouble with your tests not passing. 

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs! 

Thank you, and welcome to Kubernetes. 😃
@k8s-ci-robotk8s-ci-robot
added
the 
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Jan 22, 2021
@k8s-ci-robotk8s-ci-robot
added

cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
and removed

cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
labels
Jan 23, 2021
@MridulS
MridulS
commented
Jan 25, 2021

Copy link


Copy Markdown

ContributorAuthor
The travis error on functional tests seems to be because of a minikube error.
W0125 15:54:45.089355 4821 out.go:181] X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
493X Exiting due to RSRC_INSUFFICIENT_CORES: Requested cpu count 1 is less than the minimum allowed of 2
494I0125 15:54:45.089376 4821 out.go:119] 495
496

@yliaog
yliaog
commented
Feb 1, 2021

Copy link


Copy Markdown

Contributor
/assign @fabianvf
fabianvf
fabianvf
reviewed
Feb 1, 2021
View reviewed changes
Comment threadconfig/kube_config_test.py
Outdated

@MridulS
MridulS
requested a review
from fabianvfFebruary 2, 2021 08:55
@MridulS
MridulS
commented
Feb 2, 2021

Copy link


Copy Markdown

ContributorAuthor
/retest
@k8s-ci-robot
k8s-ci-robot
commented
Feb 2, 2021

Copy link


Copy Markdown

Contributor
@MridulS: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
Details
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@yliaog
yliaog
commented
Feb 2, 2021

Copy link


Copy Markdown

Contributor
/ok-to-test
@k8s-ci-robotk8s-ci-robot
added
the 
ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
label
Feb 2, 2021
@MridulS
MridulS
commented
Feb 2, 2021

Copy link


Copy Markdown

ContributorAuthor
/retest
@MridulS
MridulS
commented
Feb 2, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Travis seems to be failing due to an unrelated test. Any ideas what's happening here? Travis is happy now :D
@MridulS
MridulS
commented
Feb 9, 2021

Copy link


Copy Markdown

ContributorAuthor
Just wanted to check in to see if this looks okay :)
@fabianvf
fabianvf
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
/lgtm
@k8s-ci-robotk8s-ci-robot
added
the 
lgtm
Indicates that a PR is ready to be merged.
label
Feb 9, 2021
@MridulS
MridulS
commented
Feb 9, 2021

Copy link


Copy Markdown

ContributorAuthor
/assign @yliaog
@yliaog
yliaog
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
/approve
@k8s-ci-robot
k8s-ci-robot
commented
Feb 9, 2021

Copy link


Copy Markdown

Contributor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fabianvf, MridulS, yliaog
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment

Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robotk8s-ci-robot
added
the 
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Feb 9, 2021
@k8s-ci-robot
k8s-ci-robot
merged commit 04feb9f
into
kubernetes-client:masterFeb 9, 2021
@MridulSMridulS
mentioned this pull request
Feb 9, 2021

Closed

@chrisayoubchrisayoub
mentioned this pull request
Feb 25, 2021
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
May 12, 2026
 Merged

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@roycaihwroycaihwAwaiting requested review from roycaihw
@yliaogyliaogAwaiting requested review from yliaog

1 more reviewer

@fabianvffabianvffabianvf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fabianvffabianvf
@yliaogyliaog

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.size/SDenotes a PR that changes 10-29 lines, ignoring generated files.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@MridulS@k8s-ci-robot@yliaog@fabianvf