Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Keep the watch action working forever#36

Merged
mbohlool merged 2 commits into from
Jan 10, 2018
Merged

Keep the watch action working forever #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f7b490
Add flag to enable keep the watch action working all the time
Oct 17, 2017
aec1c52
Update continue the watch with resource_version
Oct 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions watch/watch.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ def __init__(self, return_type=None):
self._raw_return_type = return_type
self._stop = False
self._api_client = client.ApiClient()
self.resource_version = 0

def stop(self):
self._stop = True
Expand All@@ -81,6 +82,8 @@ def unmarshal_event(self, data, return_type):
if return_type:
obj = SimpleNamespace(data=json.dumps(js['raw_object']))
js['object'] = self._api_client.deserialize(obj, return_type)
if hasattr(js['object'], 'metadata'):
self.resource_version = js['object'].metadata.resource_version
return js

def stream(self, func, *args, **kwargs):
Expand DownExpand Up@@ -113,12 +116,19 @@ def stream(self, func, *args, **kwargs):
return_type = self.get_return_type(func)
kwargs['watch'] = True
kwargs['_preload_content'] = False
resp = func(*args, **kwargs)
try:
for line in iter_resp_lines(resp):
yield self.unmarshal_event(line, return_type)
if self._stop:
break
finally:
resp.close()
resp.release_conn()

timeouts = ('timeout_seconds' in kwargs)
while True:
resp = func(*args, **kwargs)
try:
for line in iter_resp_lines(resp):
yield self.unmarshal_event(line, return_type)
if self._stop:
break
finally:
kwargs['resource_version'] = self.resource_version
resp.close()
resp.release_conn()

if timeouts or self._stop:

@mbohloolmbohloolOct 31, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the user set timeouts but it has not been passed yet?

@lichen2013lichen2013Oct 31, 2017•
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still trying to find the proof that the exit happens we saw at the beginning is caused by the client side.

I do find the flag 'min-request-timeout' in doc kube-apiserver, and it is said that the apiserver actually has a timeout setting by itself:

--min-request-timeout=1800: An optional field indicating the minimum number of seconds a handler must keep a request open before timing it out. Currently only honored by the watch request handler, which picks a randomized value above this number as the connection timeout, to spread out load.

And if it is not set, the default value is 1800:

https://github.com/kubernetes/apiserver/blob/master/pkg/server/config.go#L248

MinRequestTimeout: 1800,

So, base on what I know now: I don't think timeout will happen before the timeouts setting.

break
32 changes: 32 additions & 0 deletions watch/watch_test.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,38 @@ def test_watch_stream_twice(self):
fake_resp.close.assert_called_once()
fake_resp.release_conn.assert_called_once()

def test_watch_stream_loop(self):
w = Watch(float)

fake_resp = Mock()
fake_resp.close = Mock()
fake_resp.release_conn = Mock()
fake_resp.read_chunked = Mock(
return_value=['{"type": "ADDED", "object": 1}\n'])

fake_api = Mock()
fake_api.get_namespaces = Mock(return_value=fake_resp)
fake_api.get_namespaces.__doc__ = ':return: V1NamespaceList'

count = 0

# when timeout_seconds is set, auto-exist when timeout reaches
for e in w.stream(fake_api.get_namespaces, timeout_seconds=1):
count = count + 1
self.assertEqual(count, 1)

# when no timeout_seconds, only exist when w.stop() is called
for e in w.stream(fake_api.get_namespaces):
count = count + 1
if count == 2:
w.stop()

self.assertEqual(count, 2)
self.assertEqual(fake_api.get_namespaces.call_count, 2)
self.assertEqual(fake_resp.read_chunked.call_count, 2)
self.assertEqual(fake_resp.close.call_count, 2)
self.assertEqual(fake_resp.release_conn.call_count, 2)

def test_unmarshal_with_float_object(self):
w = Watch()
event = w.unmarshal_event('{"type": "ADDED", "object": 1}', 'float')
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Keep the watch action working forever by lichen2013 · Pull Request #36 · kubernetes-client/python-base · GitHub
Skip to content

This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Keep the watch action working forever#36
 Merged

mbohlool
merged 2 commits into

from

Jan 10, 2018
 Merged


Keep the watch action working forever
#36
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8f7b490

Add flag to enable keep the watch action working all the time

Oct 17, 2017
aec1c52

Update continue the watch with resource_version

Oct 26, 2017

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


28 changes: 19 additions & 9 deletions
watch/watch.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ def __init__(self, return_type=None):
 self._raw_return_type = return_type
 self._stop = False
 self._api_client = client.ApiClient()
 self.resource_version = 0

 def stop(self):
 self._stop = True
Expand All@@ -81,6 +82,8 @@ def unmarshal_event(self, data, return_type):
 if return_type:
 obj = SimpleNamespace(data=json.dumps(js['raw_object']))
 js['object'] = self._api_client.deserialize(obj, return_type)
 if hasattr(js['object'], 'metadata'):
 self.resource_version = js['object'].metadata.resource_version
 return js

 def stream(self, func, *args, **kwargs):
Expand DownExpand Up@@ -113,12 +116,19 @@ def stream(self, func, *args, **kwargs):
 return_type = self.get_return_type(func)
 kwargs['watch'] = True
 kwargs['_preload_content'] = False
 resp = func(*args, **kwargs)
 try:
 for line in iter_resp_lines(resp):
 yield self.unmarshal_event(line, return_type)
 if self._stop:
 break
 finally:
 resp.close()
 resp.release_conn()

 timeouts = ('timeout_seconds' in kwargs)
 while True:
 resp = func(*args, **kwargs)
 try:
 for line in iter_resp_lines(resp):
 yield self.unmarshal_event(line, return_type)
 if self._stop:
 break
 finally:
 kwargs['resource_version'] = self.resource_version
 resp.close()
 resp.release_conn()

 if timeouts or self._stop:
@mbohloolmbohloolOct 31, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the user set timeouts but it has not been passed yet?
@lichen2013lichen2013Oct 31, 2017•

edited

Loading

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still trying to find the proof that the exit happens we saw at the beginning is caused by the client side.
I do find the flag 'min-request-timeout' in doc kube-apiserver, and it is said that the apiserver actually has a timeout setting by itself:
--min-request-timeout=1800: An optional field indicating the minimum number of seconds a handler must keep a request open before timing it out. Currently only honored by the watch request handler, which picks a randomized value above this number as the connection timeout, to spread out load.
And if it is not set, the default value is 1800:
https://github.com/kubernetes/apiserver/blob/master/pkg/server/config.go#L248
MinRequestTimeout: 1800,

So, base on what I know now: I don't think timeout will happen before the timeouts setting.
 break

32 changes: 32 additions & 0 deletions
watch/watch_test.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,38 @@ def test_watch_stream_twice(self):
 fake_resp.close.assert_called_once()
 fake_resp.release_conn.assert_called_once()

 def test_watch_stream_loop(self):
 w = Watch(float)

 fake_resp = Mock()
 fake_resp.close = Mock()
 fake_resp.release_conn = Mock()
 fake_resp.read_chunked = Mock(
 return_value=['{"type": "ADDED", "object": 1}\n'])

 fake_api = Mock()
 fake_api.get_namespaces = Mock(return_value=fake_resp)
 fake_api.get_namespaces.__doc__ = ':return: V1NamespaceList'

 count = 0

 # when timeout_seconds is set, auto-exist when timeout reaches
 for e in w.stream(fake_api.get_namespaces, timeout_seconds=1):
 count = count + 1
 self.assertEqual(count, 1)

 # when no timeout_seconds, only exist when w.stop() is called
 for e in w.stream(fake_api.get_namespaces):
 count = count + 1
 if count == 2:
 w.stop()

 self.assertEqual(count, 2)
 self.assertEqual(fake_api.get_namespaces.call_count, 2)
 self.assertEqual(fake_resp.read_chunked.call_count, 2)
 self.assertEqual(fake_resp.close.call_count, 2)
 self.assertEqual(fake_resp.release_conn.call_count, 2)

 def test_unmarshal_with_float_object(self):
 w = Watch()
 event = w.unmarshal_event('{"type": "ADDED", "object": 1}', 'float')
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Keep the watch action working forever by lichen2013 · Pull Request #36 · kubernetes-client/python-base · GitHub
Skip to content

This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Keep the watch action working forever#36
 Merged

mbohlool
merged 2 commits into

from

Jan 10, 2018
 Merged


Keep the watch action working forever
#36
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8f7b490

Add flag to enable keep the watch action working all the time

Oct 17, 2017
aec1c52

Update continue the watch with resource_version

Oct 26, 2017

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


28 changes: 19 additions & 9 deletions
watch/watch.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ def __init__(self, return_type=None):
 self._raw_return_type = return_type
 self._stop = False
 self._api_client = client.ApiClient()
 self.resource_version = 0

 def stop(self):
 self._stop = True
Expand All@@ -81,6 +82,8 @@ def unmarshal_event(self, data, return_type):
 if return_type:
 obj = SimpleNamespace(data=json.dumps(js['raw_object']))
 js['object'] = self._api_client.deserialize(obj, return_type)
 if hasattr(js['object'], 'metadata'):
 self.resource_version = js['object'].metadata.resource_version
 return js

 def stream(self, func, *args, **kwargs):
Expand DownExpand Up@@ -113,12 +116,19 @@ def stream(self, func, *args, **kwargs):
 return_type = self.get_return_type(func)
 kwargs['watch'] = True
 kwargs['_preload_content'] = False
 resp = func(*args, **kwargs)
 try:
 for line in iter_resp_lines(resp):
 yield self.unmarshal_event(line, return_type)
 if self._stop:
 break
 finally:
 resp.close()
 resp.release_conn()

 timeouts = ('timeout_seconds' in kwargs)
 while True:
 resp = func(*args, **kwargs)
 try:
 for line in iter_resp_lines(resp):
 yield self.unmarshal_event(line, return_type)
 if self._stop:
 break
 finally:
 kwargs['resource_version'] = self.resource_version
 resp.close()
 resp.release_conn()

 if timeouts or self._stop:
@mbohloolmbohloolOct 31, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the user set timeouts but it has not been passed yet?
@lichen2013lichen2013Oct 31, 2017•

edited

Loading

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still trying to find the proof that the exit happens we saw at the beginning is caused by the client side.
I do find the flag 'min-request-timeout' in doc kube-apiserver, and it is said that the apiserver actually has a timeout setting by itself:
--min-request-timeout=1800: An optional field indicating the minimum number of seconds a handler must keep a request open before timing it out. Currently only honored by the watch request handler, which picks a randomized value above this number as the connection timeout, to spread out load.
And if it is not set, the default value is 1800:
https://github.com/kubernetes/apiserver/blob/master/pkg/server/config.go#L248
MinRequestTimeout: 1800,

So, base on what I know now: I don't think timeout will happen before the timeouts setting.
 break

32 changes: 32 additions & 0 deletions
watch/watch_test.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,38 @@ def test_watch_stream_twice(self):
 fake_resp.close.assert_called_once()
 fake_resp.release_conn.assert_called_once()

 def test_watch_stream_loop(self):
 w = Watch(float)

 fake_resp = Mock()
 fake_resp.close = Mock()
 fake_resp.release_conn = Mock()
 fake_resp.read_chunked = Mock(
 return_value=['{"type": "ADDED", "object": 1}\n'])

 fake_api = Mock()
 fake_api.get_namespaces = Mock(return_value=fake_resp)
 fake_api.get_namespaces.__doc__ = ':return: V1NamespaceList'

 count = 0

 # when timeout_seconds is set, auto-exist when timeout reaches
 for e in w.stream(fake_api.get_namespaces, timeout_seconds=1):
 count = count + 1
 self.assertEqual(count, 1)

 # when no timeout_seconds, only exist when w.stop() is called
 for e in w.stream(fake_api.get_namespaces):
 count = count + 1
 if count == 2:
 w.stop()

 self.assertEqual(count, 2)
 self.assertEqual(fake_api.get_namespaces.call_count, 2)
 self.assertEqual(fake_resp.read_chunked.call_count, 2)
 self.assertEqual(fake_resp.close.call_count, 2)
 self.assertEqual(fake_resp.release_conn.call_count, 2)

 def test_unmarshal_with_float_object(self):
 w = Watch()
 event = w.unmarshal_event('{"type": "ADDED", "object": 1}', 'float')
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Keep the watch action working forever by lichen2013 · Pull Request #36 · kubernetes-client/python-base · GitHub
Skip to content

This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Keep the watch action working forever#36
 Merged

mbohlool
merged 2 commits into

from

Jan 10, 2018
 Merged


Keep the watch action working forever
#36
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8f7b490

Add flag to enable keep the watch action working all the time

Oct 17, 2017
aec1c52

Update continue the watch with resource_version

Oct 26, 2017

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


28 changes: 19 additions & 9 deletions
watch/watch.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ def __init__(self, return_type=None):
 self._raw_return_type = return_type
 self._stop = False
 self._api_client = client.ApiClient()
 self.resource_version = 0

 def stop(self):
 self._stop = True
Expand All@@ -81,6 +82,8 @@ def unmarshal_event(self, data, return_type):
 if return_type:
 obj = SimpleNamespace(data=json.dumps(js['raw_object']))
 js['object'] = self._api_client.deserialize(obj, return_type)
 if hasattr(js['object'], 'metadata'):
 self.resource_version = js['object'].metadata.resource_version
 return js

 def stream(self, func, *args, **kwargs):
Expand DownExpand Up@@ -113,12 +116,19 @@ def stream(self, func, *args, **kwargs):
 return_type = self.get_return_type(func)
 kwargs['watch'] = True
 kwargs['_preload_content'] = False
 resp = func(*args, **kwargs)
 try:
 for line in iter_resp_lines(resp):
 yield self.unmarshal_event(line, return_type)
 if self._stop:
 break
 finally:
 resp.close()
 resp.release_conn()

 timeouts = ('timeout_seconds' in kwargs)
 while True:
 resp = func(*args, **kwargs)
 try:
 for line in iter_resp_lines(resp):
 yield self.unmarshal_event(line, return_type)
 if self._stop:
 break
 finally:
 kwargs['resource_version'] = self.resource_version
 resp.close()
 resp.release_conn()

 if timeouts or self._stop:
@mbohloolmbohloolOct 31, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the user set timeouts but it has not been passed yet?
@lichen2013lichen2013Oct 31, 2017•

edited

Loading

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still trying to find the proof that the exit happens we saw at the beginning is caused by the client side.
I do find the flag 'min-request-timeout' in doc kube-apiserver, and it is said that the apiserver actually has a timeout setting by itself:
--min-request-timeout=1800: An optional field indicating the minimum number of seconds a handler must keep a request open before timing it out. Currently only honored by the watch request handler, which picks a randomized value above this number as the connection timeout, to spread out load.
And if it is not set, the default value is 1800:
https://github.com/kubernetes/apiserver/blob/master/pkg/server/config.go#L248
MinRequestTimeout: 1800,

So, base on what I know now: I don't think timeout will happen before the timeouts setting.
 break

32 changes: 32 additions & 0 deletions
watch/watch_test.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,38 @@ def test_watch_stream_twice(self):
 fake_resp.close.assert_called_once()
 fake_resp.release_conn.assert_called_once()

 def test_watch_stream_loop(self):
 w = Watch(float)

 fake_resp = Mock()
 fake_resp.close = Mock()
 fake_resp.release_conn = Mock()
 fake_resp.read_chunked = Mock(
 return_value=['{"type": "ADDED", "object": 1}\n'])

 fake_api = Mock()
 fake_api.get_namespaces = Mock(return_value=fake_resp)
 fake_api.get_namespaces.__doc__ = ':return: V1NamespaceList'

 count = 0

 # when timeout_seconds is set, auto-exist when timeout reaches
 for e in w.stream(fake_api.get_namespaces, timeout_seconds=1):
 count = count + 1
 self.assertEqual(count, 1)

 # when no timeout_seconds, only exist when w.stop() is called
 for e in w.stream(fake_api.get_namespaces):
 count = count + 1
 if count == 2:
 w.stop()

 self.assertEqual(count, 2)
 self.assertEqual(fake_api.get_namespaces.call_count, 2)
 self.assertEqual(fake_resp.read_chunked.call_count, 2)
 self.assertEqual(fake_resp.close.call_count, 2)
 self.assertEqual(fake_resp.release_conn.call_count, 2)

 def test_unmarshal_with_float_object(self):
 w = Watch()
 event = w.unmarshal_event('{"type": "ADDED", "object": 1}', 'float')
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Keep the watch action working forever by lichen2013 · Pull Request #36 · kubernetes-client/python-base · GitHub
Skip to content

This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Keep the watch action working forever#36
 Merged

mbohlool
merged 2 commits into

from

Jan 10, 2018
 Merged


Keep the watch action working forever
#36
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8f7b490

Add flag to enable keep the watch action working all the time

Oct 17, 2017
aec1c52

Update continue the watch with resource_version

Oct 26, 2017

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


28 changes: 19 additions & 9 deletions
watch/watch.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ def __init__(self, return_type=None):
 self._raw_return_type = return_type
 self._stop = False
 self._api_client = client.ApiClient()
 self.resource_version = 0

 def stop(self):
 self._stop = True
Expand All@@ -81,6 +82,8 @@ def unmarshal_event(self, data, return_type):
 if return_type:
 obj = SimpleNamespace(data=json.dumps(js['raw_object']))
 js['object'] = self._api_client.deserialize(obj, return_type)
 if hasattr(js['object'], 'metadata'):
 self.resource_version = js['object'].metadata.resource_version
 return js

 def stream(self, func, *args, **kwargs):
Expand DownExpand Up@@ -113,12 +116,19 @@ def stream(self, func, *args, **kwargs):
 return_type = self.get_return_type(func)
 kwargs['watch'] = True
 kwargs['_preload_content'] = False
 resp = func(*args, **kwargs)
 try:
 for line in iter_resp_lines(resp):
 yield self.unmarshal_event(line, return_type)
 if self._stop:
 break
 finally:
 resp.close()
 resp.release_conn()

 timeouts = ('timeout_seconds' in kwargs)
 while True:
 resp = func(*args, **kwargs)
 try:
 for line in iter_resp_lines(resp):
 yield self.unmarshal_event(line, return_type)
 if self._stop:
 break
 finally:
 kwargs['resource_version'] = self.resource_version
 resp.close()
 resp.release_conn()

 if timeouts or self._stop:
@mbohloolmbohloolOct 31, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the user set timeouts but it has not been passed yet?
@lichen2013lichen2013Oct 31, 2017•

edited

Loading

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still trying to find the proof that the exit happens we saw at the beginning is caused by the client side.
I do find the flag 'min-request-timeout' in doc kube-apiserver, and it is said that the apiserver actually has a timeout setting by itself:
--min-request-timeout=1800: An optional field indicating the minimum number of seconds a handler must keep a request open before timing it out. Currently only honored by the watch request handler, which picks a randomized value above this number as the connection timeout, to spread out load.
And if it is not set, the default value is 1800:
https://github.com/kubernetes/apiserver/blob/master/pkg/server/config.go#L248
MinRequestTimeout: 1800,

So, base on what I know now: I don't think timeout will happen before the timeouts setting.
 break

32 changes: 32 additions & 0 deletions
watch/watch_test.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,38 @@ def test_watch_stream_twice(self):
 fake_resp.close.assert_called_once()
 fake_resp.release_conn.assert_called_once()

 def test_watch_stream_loop(self):
 w = Watch(float)

 fake_resp = Mock()
 fake_resp.close = Mock()
 fake_resp.release_conn = Mock()
 fake_resp.read_chunked = Mock(
 return_value=['{"type": "ADDED", "object": 1}\n'])

 fake_api = Mock()
 fake_api.get_namespaces = Mock(return_value=fake_resp)
 fake_api.get_namespaces.__doc__ = ':return: V1NamespaceList'

 count = 0

 # when timeout_seconds is set, auto-exist when timeout reaches
 for e in w.stream(fake_api.get_namespaces, timeout_seconds=1):
 count = count + 1
 self.assertEqual(count, 1)

 # when no timeout_seconds, only exist when w.stop() is called
 for e in w.stream(fake_api.get_namespaces):
 count = count + 1
 if count == 2:
 w.stop()

 self.assertEqual(count, 2)
 self.assertEqual(fake_api.get_namespaces.call_count, 2)
 self.assertEqual(fake_resp.read_chunked.call_count, 2)
 self.assertEqual(fake_resp.close.call_count, 2)
 self.assertEqual(fake_resp.release_conn.call_count, 2)

 def test_unmarshal_with_float_object(self):
 w = Watch()
 event = w.unmarshal_event('{"type": "ADDED", "object": 1}', 'float')
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Keep the watch action working forever by lichen2013 · Pull Request #36 · kubernetes-client/python-base · GitHub
Skip to content

This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Keep the watch action working forever#36
 Merged

mbohlool
merged 2 commits into

from

Jan 10, 2018
 Merged


Keep the watch action working forever
#36
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8f7b490

Add flag to enable keep the watch action working all the time

Oct 17, 2017
aec1c52

Update continue the watch with resource_version

Oct 26, 2017

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


28 changes: 19 additions & 9 deletions
watch/watch.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ def __init__(self, return_type=None):
 self._raw_return_type = return_type
 self._stop = False
 self._api_client = client.ApiClient()
 self.resource_version = 0

 def stop(self):
 self._stop = True
Expand All@@ -81,6 +82,8 @@ def unmarshal_event(self, data, return_type):
 if return_type:
 obj = SimpleNamespace(data=json.dumps(js['raw_object']))
 js['object'] = self._api_client.deserialize(obj, return_type)
 if hasattr(js['object'], 'metadata'):
 self.resource_version = js['object'].metadata.resource_version
 return js

 def stream(self, func, *args, **kwargs):
Expand DownExpand Up@@ -113,12 +116,19 @@ def stream(self, func, *args, **kwargs):
 return_type = self.get_return_type(func)
 kwargs['watch'] = True
 kwargs['_preload_content'] = False
 resp = func(*args, **kwargs)
 try:
 for line in iter_resp_lines(resp):
 yield self.unmarshal_event(line, return_type)
 if self._stop:
 break
 finally:
 resp.close()
 resp.release_conn()

 timeouts = ('timeout_seconds' in kwargs)
 while True:
 resp = func(*args, **kwargs)
 try:
 for line in iter_resp_lines(resp):
 yield self.unmarshal_event(line, return_type)
 if self._stop:
 break
 finally:
 kwargs['resource_version'] = self.resource_version
 resp.close()
 resp.release_conn()

 if timeouts or self._stop:
@mbohloolmbohloolOct 31, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the user set timeouts but it has not been passed yet?
@lichen2013lichen2013Oct 31, 2017•

edited

Loading

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still trying to find the proof that the exit happens we saw at the beginning is caused by the client side.
I do find the flag 'min-request-timeout' in doc kube-apiserver, and it is said that the apiserver actually has a timeout setting by itself:
--min-request-timeout=1800: An optional field indicating the minimum number of seconds a handler must keep a request open before timing it out. Currently only honored by the watch request handler, which picks a randomized value above this number as the connection timeout, to spread out load.
And if it is not set, the default value is 1800:
https://github.com/kubernetes/apiserver/blob/master/pkg/server/config.go#L248
MinRequestTimeout: 1800,

So, base on what I know now: I don't think timeout will happen before the timeouts setting.
 break

32 changes: 32 additions & 0 deletions
watch/watch_test.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,38 @@ def test_watch_stream_twice(self):
 fake_resp.close.assert_called_once()
 fake_resp.release_conn.assert_called_once()

 def test_watch_stream_loop(self):
 w = Watch(float)

 fake_resp = Mock()
 fake_resp.close = Mock()
 fake_resp.release_conn = Mock()
 fake_resp.read_chunked = Mock(
 return_value=['{"type": "ADDED", "object": 1}\n'])

 fake_api = Mock()
 fake_api.get_namespaces = Mock(return_value=fake_resp)
 fake_api.get_namespaces.__doc__ = ':return: V1NamespaceList'

 count = 0

 # when timeout_seconds is set, auto-exist when timeout reaches
 for e in w.stream(fake_api.get_namespaces, timeout_seconds=1):
 count = count + 1
 self.assertEqual(count, 1)

 # when no timeout_seconds, only exist when w.stop() is called
 for e in w.stream(fake_api.get_namespaces):
 count = count + 1
 if count == 2:
 w.stop()

 self.assertEqual(count, 2)
 self.assertEqual(fake_api.get_namespaces.call_count, 2)
 self.assertEqual(fake_resp.read_chunked.call_count, 2)
 self.assertEqual(fake_resp.close.call_count, 2)
 self.assertEqual(fake_resp.release_conn.call_count, 2)

 def test_unmarshal_with_float_object(self):
 w = Watch()
 event = w.unmarshal_event('{"type": "ADDED", "object": 1}', 'float')
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Keep the watch action working forever by lichen2013 · Pull Request #36 · kubernetes-client/python-base · GitHub
Skip to content

This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Keep the watch action working forever#36
 Merged

mbohlool
merged 2 commits into

from

Jan 10, 2018
 Merged


Keep the watch action working forever
#36
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8f7b490

Add flag to enable keep the watch action working all the time

Oct 17, 2017
aec1c52

Update continue the watch with resource_version

Oct 26, 2017

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


28 changes: 19 additions & 9 deletions
watch/watch.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ def __init__(self, return_type=None):
 self._raw_return_type = return_type
 self._stop = False
 self._api_client = client.ApiClient()
 self.resource_version = 0

 def stop(self):
 self._stop = True
Expand All@@ -81,6 +82,8 @@ def unmarshal_event(self, data, return_type):
 if return_type:
 obj = SimpleNamespace(data=json.dumps(js['raw_object']))
 js['object'] = self._api_client.deserialize(obj, return_type)
 if hasattr(js['object'], 'metadata'):
 self.resource_version = js['object'].metadata.resource_version
 return js

 def stream(self, func, *args, **kwargs):
Expand DownExpand Up@@ -113,12 +116,19 @@ def stream(self, func, *args, **kwargs):
 return_type = self.get_return_type(func)
 kwargs['watch'] = True
 kwargs['_preload_content'] = False
 resp = func(*args, **kwargs)
 try:
 for line in iter_resp_lines(resp):
 yield self.unmarshal_event(line, return_type)
 if self._stop:
 break
 finally:
 resp.close()
 resp.release_conn()

 timeouts = ('timeout_seconds' in kwargs)
 while True:
 resp = func(*args, **kwargs)
 try:
 for line in iter_resp_lines(resp):
 yield self.unmarshal_event(line, return_type)
 if self._stop:
 break
 finally:
 kwargs['resource_version'] = self.resource_version
 resp.close()
 resp.release_conn()

 if timeouts or self._stop:
@mbohloolmbohloolOct 31, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the user set timeouts but it has not been passed yet?
@lichen2013lichen2013Oct 31, 2017•

edited

Loading

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still trying to find the proof that the exit happens we saw at the beginning is caused by the client side.
I do find the flag 'min-request-timeout' in doc kube-apiserver, and it is said that the apiserver actually has a timeout setting by itself:
--min-request-timeout=1800: An optional field indicating the minimum number of seconds a handler must keep a request open before timing it out. Currently only honored by the watch request handler, which picks a randomized value above this number as the connection timeout, to spread out load.
And if it is not set, the default value is 1800:
https://github.com/kubernetes/apiserver/blob/master/pkg/server/config.go#L248
MinRequestTimeout: 1800,

So, base on what I know now: I don't think timeout will happen before the timeouts setting.
 break

32 changes: 32 additions & 0 deletions
watch/watch_test.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,38 @@ def test_watch_stream_twice(self):
 fake_resp.close.assert_called_once()
 fake_resp.release_conn.assert_called_once()

 def test_watch_stream_loop(self):
 w = Watch(float)

 fake_resp = Mock()
 fake_resp.close = Mock()
 fake_resp.release_conn = Mock()
 fake_resp.read_chunked = Mock(
 return_value=['{"type": "ADDED", "object": 1}\n'])

 fake_api = Mock()
 fake_api.get_namespaces = Mock(return_value=fake_resp)
 fake_api.get_namespaces.__doc__ = ':return: V1NamespaceList'

 count = 0

 # when timeout_seconds is set, auto-exist when timeout reaches
 for e in w.stream(fake_api.get_namespaces, timeout_seconds=1):
 count = count + 1
 self.assertEqual(count, 1)

 # when no timeout_seconds, only exist when w.stop() is called
 for e in w.stream(fake_api.get_namespaces):
 count = count + 1
 if count == 2:
 w.stop()

 self.assertEqual(count, 2)
 self.assertEqual(fake_api.get_namespaces.call_count, 2)
 self.assertEqual(fake_resp.read_chunked.call_count, 2)
 self.assertEqual(fake_resp.close.call_count, 2)
 self.assertEqual(fake_resp.release_conn.call_count, 2)

 def test_unmarshal_with_float_object(self):
 w = Watch()
 event = w.unmarshal_event('{"type": "ADDED", "object": 1}', 'float')
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Keep the watch action working forever by lichen2013 · Pull Request #36 · kubernetes-client/python-base · GitHub
Skip to content

This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Keep the watch action working forever#36
 Merged

mbohlool
merged 2 commits into

from

Jan 10, 2018
 Merged


Keep the watch action working forever
#36
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8f7b490

Add flag to enable keep the watch action working all the time

Oct 17, 2017
aec1c52

Update continue the watch with resource_version

Oct 26, 2017

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


28 changes: 19 additions & 9 deletions
watch/watch.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ def __init__(self, return_type=None):
 self._raw_return_type = return_type
 self._stop = False
 self._api_client = client.ApiClient()
 self.resource_version = 0

 def stop(self):
 self._stop = True
Expand All@@ -81,6 +82,8 @@ def unmarshal_event(self, data, return_type):
 if return_type:
 obj = SimpleNamespace(data=json.dumps(js['raw_object']))
 js['object'] = self._api_client.deserialize(obj, return_type)
 if hasattr(js['object'], 'metadata'):
 self.resource_version = js['object'].metadata.resource_version
 return js

 def stream(self, func, *args, **kwargs):
Expand DownExpand Up@@ -113,12 +116,19 @@ def stream(self, func, *args, **kwargs):
 return_type = self.get_return_type(func)
 kwargs['watch'] = True
 kwargs['_preload_content'] = False
 resp = func(*args, **kwargs)
 try:
 for line in iter_resp_lines(resp):
 yield self.unmarshal_event(line, return_type)
 if self._stop:
 break
 finally:
 resp.close()
 resp.release_conn()

 timeouts = ('timeout_seconds' in kwargs)
 while True:
 resp = func(*args, **kwargs)
 try:
 for line in iter_resp_lines(resp):
 yield self.unmarshal_event(line, return_type)
 if self._stop:
 break
 finally:
 kwargs['resource_version'] = self.resource_version
 resp.close()
 resp.release_conn()

 if timeouts or self._stop:
@mbohloolmbohloolOct 31, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the user set timeouts but it has not been passed yet?
@lichen2013lichen2013Oct 31, 2017•

edited

Loading

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still trying to find the proof that the exit happens we saw at the beginning is caused by the client side.
I do find the flag 'min-request-timeout' in doc kube-apiserver, and it is said that the apiserver actually has a timeout setting by itself:
--min-request-timeout=1800: An optional field indicating the minimum number of seconds a handler must keep a request open before timing it out. Currently only honored by the watch request handler, which picks a randomized value above this number as the connection timeout, to spread out load.
And if it is not set, the default value is 1800:
https://github.com/kubernetes/apiserver/blob/master/pkg/server/config.go#L248
MinRequestTimeout: 1800,

So, base on what I know now: I don't think timeout will happen before the timeouts setting.
 break

32 changes: 32 additions & 0 deletions
watch/watch_test.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,38 @@ def test_watch_stream_twice(self):
 fake_resp.close.assert_called_once()
 fake_resp.release_conn.assert_called_once()

 def test_watch_stream_loop(self):
 w = Watch(float)

 fake_resp = Mock()
 fake_resp.close = Mock()
 fake_resp.release_conn = Mock()
 fake_resp.read_chunked = Mock(
 return_value=['{"type": "ADDED", "object": 1}\n'])

 fake_api = Mock()
 fake_api.get_namespaces = Mock(return_value=fake_resp)
 fake_api.get_namespaces.__doc__ = ':return: V1NamespaceList'

 count = 0

 # when timeout_seconds is set, auto-exist when timeout reaches
 for e in w.stream(fake_api.get_namespaces, timeout_seconds=1):
 count = count + 1
 self.assertEqual(count, 1)

 # when no timeout_seconds, only exist when w.stop() is called
 for e in w.stream(fake_api.get_namespaces):
 count = count + 1
 if count == 2:
 w.stop()

 self.assertEqual(count, 2)
 self.assertEqual(fake_api.get_namespaces.call_count, 2)
 self.assertEqual(fake_resp.read_chunked.call_count, 2)
 self.assertEqual(fake_resp.close.call_count, 2)
 self.assertEqual(fake_resp.release_conn.call_count, 2)

 def test_unmarshal_with_float_object(self):
 w = Watch()
 event = w.unmarshal_event('{"type": "ADDED", "object": 1}', 'float')
Expand Down