Uh oh!
There was an error while loading. Please reload this page.
Update Examples to stop using deprecated versions - #1155
Conversation
k8s-ci-robot
commented
Apr 29, 2020
Welcome @MoShitrit! |
moshevayner
commented
Apr 30, 2020
/assign @yliaog |
codecov-io
commented
Apr 30, 2020
Codecov Report
|
palnabarun
commented
May 1, 2020
/assign |
moshevayner
commented
May 10, 2020
Hey @roycaihw! |
| "metadata": { | ||
| "deletable": true, | ||
| "editable": true | ||
| }, |
There was a problem hiding this comment.
Are these changes auto-generated? If so, could you split the generated change into a separate commit? That will make it easier to review
There was a problem hiding this comment.
I actually edited these files in an IDE that has an integration with Jupyter notebook integration (IntelliJ IDEA, fwiw) so it gives a pretty convenient way to edit the file in a convenient way.
Nothing was auto-generated here.
I guess it might've added some additional fields which it wasn't supposed to.
Let me see if I can reduce the amount of changes here.
There was a problem hiding this comment.
@roycaihw OK I was able to clean up the mess that was made there, it's looking better now.
To sum up: I updated the versions to use the current ones, and removed the examples that are no longer relevant (Create DeploymentRollback object). There was also an empty cell at the bottom that didn't seem to have any purpose, so I took the liberty of removing that as well.
Please let me know if any further changes are needed.
Thanks!
palnabarun
commented
May 12, 2020
Thanks @MoShitrit for updating the examples. /lgtm |
roycaihw
commented
May 12, 2020
/lgtm |
k8s-ci-robot
commented
May 12, 2020
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MoShitrit, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes#967